public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Siluvery, Arun" <arun.siluvery@linux.intel.com>
To: Damien Lespiau <damien.lespiau@intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 0/5] A few fixes on top of the wa_regs patches
Date: Sun, 31 Aug 2014 20:32:55 +0100	[thread overview]
Message-ID: <54037867.6060100@linux.intel.com> (raw)
In-Reply-To: <1409413863-7681-1-git-send-email-damien.lespiau@intel.com>

On 30/08/2014 16:50, Damien Lespiau wrote:
> Hi Arun,
>
> I've compiled a few patches that I think solve some small-ish issues around
> your wa_regs series. Could you please have a look at them and comment/give your
> r-b tag if you judge appropriate?
>
> On top of those patches, I'd love some comments on the issues I raised in the
> other mail and possible follow up patches to address them.
>
>    http://lists.freedesktop.org/archives/intel-gfx/2014-August/051514.html

Hi Damien,

I really appreciate you taking time to not just give review comments but 
also sending patches to fix those issues.

Chris suggested a way of emitting all LRIs using a simple function and I 
really wanted to rework everything based on that suggestion.

The LRIs are now organized in an array as opposed to sending them 
individually also debugfs patch can make use of it. I have removed the 
temporary array included in driver private structure.
I think now it looks clean and we can easily add new w/a with minimal 
changes.

Since all of the patches are modified I think it is better to squash 
them with the merged ones rather than updating them with new patches so 
I have folded your patches during rework and will send them after 
testing, please review them and give your comments.

regards
Arun

>
> At some point, we'll also need a bit of coherence with what Mika has been doing:
>
>    http://lists.freedesktop.org/archives/intel-gfx/2014-August/050000.html
>

  parent reply	other threads:[~2014-08-31 19:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-30 15:50 [PATCH 0/5] A few fixes on top of the wa_regs patches Damien Lespiau
2014-08-30 15:50 ` [PATCH 1/5] drm/i915: Rename intel_wa_registers with a i915_ prefix Damien Lespiau
2014-09-01 11:06   ` Siluvery, Arun
2014-08-30 15:51 ` [PATCH 2/5] drm/i915: Don't overrun the intel_wa_regs array Damien Lespiau
2014-08-30 15:51 ` [PATCH 3/5] drm/i915: Don't silently discard workarounds Damien Lespiau
2014-08-30 15:51 ` [PATCH 4/5] drm/i915: Remove unneeded brackets Damien Lespiau
2014-08-30 15:51 ` [PATCH 5/5] drm/i915: Don't restrict i915_wa_registers to BDW Damien Lespiau
2014-09-01 11:33   ` Siluvery, Arun
2014-08-31 19:32 ` Siluvery, Arun [this message]
2014-09-01  9:08   ` [PATCH 0/5] A few fixes on top of the wa_regs patches Daniel Vetter
2014-09-01  9:29     ` Siluvery, Arun
2014-09-03  9:18 ` Siluvery, Arun
2014-09-03 10:40   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54037867.6060100@linux.intel.com \
    --to=arun.siluvery@linux.intel.com \
    --cc=damien.lespiau@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox