From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Siluvery, Arun" <arun.siluvery@linux.intel.com>
Subject: Re: [PATCH 5/5] drm/i915: Don't restrict
	i915_wa_registers to BDW
Date: Mon, 01 Sep 2014 12:33:50 +0100
Message-ID: <5404599E.7080208@linux.intel.com>
References: <1409413863-7681-1-git-send-email-damien.lespiau@intel.com>
 <1409413863-7681-6-git-send-email-damien.lespiau@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTP id B340D89ED3
 for <intel-gfx@lists.freedesktop.org>; Mon,  1 Sep 2014 04:33:53 -0700 (PDT)
In-Reply-To: <1409413863-7681-6-git-send-email-damien.lespiau@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Damien Lespiau <damien.lespiau@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On 30/08/2014 16:51, Damien Lespiau wrote:
> We have CHV code that already makes the test obsolete. Besides, when
> num_wa_regs is 0 (platforms not gathering that W/A data), we expose
> something sensible already.
>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
>   drivers/gpu/drm/i915/i915_debugfs.c | 5 -----
>   1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index fc3d582a..cd4f045 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -2636,11 +2636,6 @@ static int i915_wa_registers(struct seq_file *m, void *unused)
>   	struct drm_device *dev = node->minor->dev;
>   	struct drm_i915_private *dev_priv = dev->dev_private;
>
> -	if (!IS_BROADWELL(dev)) {
> -		DRM_DEBUG_DRIVER("Workaround table not available !!\n");
> -		return -EINVAL;
> -	}
> -
>   	ret = mutex_lock_interruptible(&dev->struct_mutex);
>   	if (ret)
>   		return ret;
>
This can also be taken, so patches 1 and 5 in this series.
Reviewed-by: Arun Siluvery <arun.siluvery@linux.intel.com>

regards
Arun