From: Deepak S <deepak.s@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Don't use WaGsvRC0ResidenncyMethod on chv
Date: Tue, 02 Sep 2014 08:05:24 +0530 [thread overview]
Message-ID: <54052CEC.1060400@intel.com> (raw)
In-Reply-To: <20140829112127.GG3557@nuc-i3427.alporthouse.com>
On Friday 29 August 2014 04:51 PM, Chris Wilson wrote:
> On Fri, Aug 29, 2014 at 02:14:07PM +0300, ville.syrjala@linux.intel.com wrote:
>> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>
>> WaGsvRC0ResidenncyMethod is for vlv, it doesn't deal with chv
>> appropriately (eg. doesn't limit rps values to even numbers).
>>
>> Fix a typo in the w/a name while at it.
> You could review my changes for the vlv manual calculations that would
> fix it for chv as well...
> -Chris
Hi Chris,
I have reviewed your patch. It should directly work for CHV. We still need Ville patch, as "WaGsvRC0ResidenncyMethod (EI_expired)" interrupts are not needed for chv.
I can test your patch on CHV, if someone else can test you patch on VLV, i can add my r-b
Thanks
Deepak
next prev parent reply other threads:[~2014-09-01 2:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 11:14 [PATCH] drm/i915: Don't use WaGsvRC0ResidenncyMethod on chv ville.syrjala
2014-08-29 11:21 ` Chris Wilson
2014-08-29 12:09 ` Ville Syrjälä
2014-08-29 12:51 ` Chris Wilson
2014-08-29 13:01 ` Ville Syrjälä
2014-09-02 2:35 ` Deepak S [this message]
2014-08-31 6:18 ` Deepak S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54052CEC.1060400@intel.com \
--to=deepak.s@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox