From mboxrd@z Thu Jan 1 00:00:00 1970 From: Deepak S Subject: Re: [PATCH] drm/i915: Don't use WaGsvRC0ResidenncyMethod on chv Date: Tue, 02 Sep 2014 08:05:24 +0530 Message-ID: <54052CEC.1060400@intel.com> References: <1409310847-24105-1-git-send-email-ville.syrjala@linux.intel.com> <20140829112127.GG3557@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; Format="flowed" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id CA0496E195 for ; Sun, 31 Aug 2014 19:40:37 -0700 (PDT) In-Reply-To: <20140829112127.GG3557@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Friday 29 August 2014 04:51 PM, Chris Wilson wrote: > On Fri, Aug 29, 2014 at 02:14:07PM +0300, ville.syrjala@linux.intel.com w= rote: >> From: Ville Syrj=E4l=E4 >> >> WaGsvRC0ResidenncyMethod is for vlv, it doesn't deal with chv >> appropriately (eg. doesn't limit rps values to even numbers). >> >> Fix a typo in the w/a name while at it. > You could review my changes for the vlv manual calculations that would > fix it for chv as well... > -Chris Hi Chris, I have reviewed your patch. It should directly work for CHV. We still need = Ville patch, as "WaGsvRC0ResidenncyMethod (EI_expired)" interrupts are not = needed for chv. I can test your patch on CHV, if someone else can test you patch on VLV, i = can add my r-b Thanks Deepak