From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Richter Subject: Re: [PATCH] drm/i915: Fix SRC_COPY width on 830/845g Date: Fri, 12 Sep 2014 09:20:51 +0200 Message-ID: <54129ED3.8060105@math.tu-berlin.de> References: <23616_1410503880_541294C8_23616_19426_1_1410503862-29589-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-2.alumni.tu-berlin.de (mail-2.alumni.tu-berlin.de [130.149.5.29]) by gabe.freedesktop.org (Postfix) with ESMTP id F17D289BCD for ; Fri, 12 Sep 2014 00:20:54 -0700 (PDT) In-Reply-To: <23616_1410503880_541294C8_23616_19426_1_1410503862-29589-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Jani Nikula , stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org Am 12.09.2014 08:37, schrieb Chris Wilson: > One small change I forgot to make in > > commit c4d69da167fa967749aeb70bc0e94a457e5d00c1 > Author: Chris Wilson > Date: Mon Sep 8 14:25:41 2014 +0100 > > drm/i915: Evict CS TLBs between batches > > was to update the copy width for the compact BLT copy instruction. > > Reported-by: Thomas Richter > Signed-off-by: Chris Wilson > Cc: Thomas Richter > Cc: Jani Nikula > Cc: stable@vger.kernel.org > --- > drivers/gpu/drm/i915/intel_ringbuffer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c > index d0156d6..45d70fd 100644 > --- a/drivers/gpu/drm/i915/intel_ringbuffer.c > +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c > @@ -1386,7 +1386,7 @@ i830_emit_batchbuffer(struct i915_gem_request *rq, > */ > intel_ring_emit(ring, SRC_COPY_BLT_CMD | BLT_WRITE_RGBA); > intel_ring_emit(ring, BLT_DEPTH_32 | BLT_ROP_SRC_COPY | 4096); > - intel_ring_emit(ring, DIV_ROUND_UP(len, 4096) << 16 | 1024); > + intel_ring_emit(ring, DIV_ROUND_UP(len, 4096) << 16 | 4096); > intel_ring_emit(ring, cs_offset); > intel_ring_emit(ring, 4096); > intel_ring_emit(ring, offset); Thanks Chris, this has done the trick! I get again a working display and a working GPU on my 830 machine. Tested-by: Thomas Richter