From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michel Thierry Subject: Re: [PATCH] drm/i915/ppgtt: Load address space after mi_set_context Date: Fri, 12 Sep 2014 17:56:30 +0100 Message-ID: <541325BE.5080302@intel.com> References: <1410534601-11523-1-git-send-email-michel.thierry@intel.com> <20140912153510.GC12416@intel.com> <20140912154047.GJ16043@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; Format="flowed" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 3AF586E1EF for ; Fri, 12 Sep 2014 09:56:33 -0700 (PDT) In-Reply-To: <20140912154047.GJ16043@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , =?windows-1252?Q?Ville_Syr?= =?windows-1252?Q?j=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On 9/12/2014 4:40 PM, Chris Wilson wrote: > On Fri, Sep 12, 2014 at 06:35:10PM +0300, Ville Syrj=E4l=E4 wrote: >> On Fri, Sep 12, 2014 at 04:10:01PM +0100, Michel Thierry wrote: >>> From: Ben Widawsky >>> >>> The simple explanation is, the docs say to do this for GEN8. Perhaps we >>> want to do this for GEN7 too, I am not certain. >>> >>> PDPs are saved and restored with context. Contexts (without execlists) >>> only exist on the render ring. The docs say that PDPs are not power >>> context save/restored. I've learned that this actually means something >>> which SW doesn't care about. So pretend the statement doesn't exist. >>> For non RCS, nothing changes. > > Hang on. This is exactly what I was worried about... Which PDPs are > saved with context? Why doesn't this mean that we aren't overwitting > PDPs in use on other rings when RCS loads a new context? > -Chris > I was wondering the same when I read Ben's original comment. Could this = be GEN8 specific?