From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jike Song <jike.song@intel.com>
Subject: Re: [PATCH 4/8] drm/i915: Disable framebuffer
 compression for i915 driver in VM
Date: Mon, 22 Sep 2014 15:10:05 +0800
Message-ID: <541FCB4D.5030905@intel.com>
References: <1411152428-7226-1-git-send-email-jike.song@intel.com>
 <1411152428-7226-5-git-send-email-jike.song@intel.com>
 <20140919080740.GD21738@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by gabe.freedesktop.org (Postfix) with ESMTP id 1D4E26E090
 for <intel-gfx@lists.freedesktop.org>; Mon, 22 Sep 2014 00:14:28 -0700 (PDT)
In-Reply-To: <20140919080740.GD21738@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, daniel.vetter@intel.com, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On 09/19/2014 04:07 PM, Chris Wilson wrote:
> On Sat, Sep 20, 2014 at 02:47:04AM +0800, Jike Song wrote:
>> From: Yu Zhang <yu.c.zhang@intel.com>
>>
>> Framebuffer compression is disabled when driver detects it's
>> running in XenGT VM, because XenGT does not provide emulations
>> for FBC related operations, and we do not expose stolen memory
>> to the VM.
>>
>> Signed-off-by: Yu Zhang <yu.c.zhang@intel.com>
>> Signed-off-by: Jike Song <jike.song@intel.com>
>> Signed-off-by: Zhiyuan Lv <zhiyuan.lv@intel.com>
>> ---
>>   drivers/gpu/drm/i915/i915_dma.c | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
>> index 927acea..bb4ad52 100644
>> --- a/drivers/gpu/drm/i915/i915_dma.c
>> +++ b/drivers/gpu/drm/i915/i915_dma.c
>> @@ -1741,6 +1741,10 @@ int i915_driver_load(struct drm_device *dev, unsigned long flags)
>>
>>   	i915_check_vgpu(dev);
>>
>> +	/* disable framebuffer compression in vgt */
>> +	if (intel_vgpu_active(dev))
>> +		i915.enable_fbc = 0;
>
> This should be done inside intel_enable_fbc() so that the correct reason
> is given as to why it is disabled.

I'm sorry, but do you mean intel_update_fbc()?


> -Chris
>

--
Thanks,
Jike