Re: [PATCH 0/9] BYT DSI Dual Link Support

[Shobhit Kumar <shobhit.kumar@linux.intel.com>]

On Wednesday 24 September 2014 02:31 PM, Daniel Vetter wrote:
> On Wed, Sep 24, 2014 at 02:16:49PM +0530, Gaurav K Singh wrote:
>> Hi,
>> These set of patches build on top of the existing DSI Video mode support to
>> enable dual link MIPI panels with high resolutions. These patches have been
>> tested on a 25x16 panel and works well.
>
> Except for the first patch (which only has a trivial "this is prep work"
> sentence) all your patches lack a commit message. If you do mechanical and
> trivial changes all over the driver split up into a bunch of patches this
> is ok, but for everything else it makes reviewing your code really hard
> since the reviewer has no idea _why_ some change is done.
>
> So please give your patches some good commit messages, focusing
> specifically on why you change things like you do (and also e.g. why other
> approaches would be worse). Also, the subject/summary should be at most 50
> chars (with a hard limit at 80 characters), lots of them are longer. So
> probably some of the details of what exactly a patch changes should also
> be moved into the commit message.
>
> See "2) Describe your changes" in Documentation/SubmittingPatches for a
> some good examples and explanations. Also my review BKM training has some
> material about what a good commit message should entail.
>

Yeah I agree, more information is needed and we will submit patches 
again after addressing comments from Jani as well.

Regards
Shobhit