From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Yu, Zhang" <yu.c.zhang@linux.intel.com>
Subject: Re: [PATCH 2/8] drm/i915: Adds graphic address space
 ballooning logic
Date: Fri, 26 Sep 2014 16:46:42 +0800
Message-ID: <542527F2.2070505@linux.intel.com>
References: <1411152428-7226-3-git-send-email-jike.song@intel.com>
 <20140919080557.GC21738@nuc-i3427.alporthouse.com>
 <AADFC41AFE54684AB9EE6CBC0274A5D12608A151@SHSMSX101.ccr.corp.intel.com>
 <20140919200000.GH21738@nuc-i3427.alporthouse.com>
 <20140923082626.GV15734@phenom.ffwll.local>
 <20140923091902.GG8727@nuc-i3427.alporthouse.com>
 <20140923112503.GD15734@phenom.ffwll.local>
 <5422BAA6.8090105@linux.intel.com>
 <20140924132118.GA30278@nuc-i3427.alporthouse.com>
 <5425232C.3030107@linux.intel.com>
 <20140926084807.GF24221@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTP id 727EC6E2DB
 for <intel-gfx@lists.freedesktop.org>; Fri, 26 Sep 2014 01:52:50 -0700 (PDT)
In-Reply-To: <20140926084807.GF24221@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, Daniel Vetter <daniel@ffwll.ch>, "Tian, Kevin" <kevin.tian@intel.com>, "Song, Jike" <jike.song@intel.com>, "Vetter, Daniel" <daniel.vetter@intel.com>, "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org



On 9/26/2014 4:48 PM, Chris Wilson wrote:
> On Fri, Sep 26, 2014 at 04:26:20PM +0800, Zhang, Yu wrote:
>> Hi Chris & Daniel,
>>
>>    Thanks for your comments. Following are my understandings about
>> the changes needed for this patch:
>>
>> 1> We do not need the guard page anymore between different VMs. For
>> the very last physical GTT entry, let's keep it pointing to a guard
>> page.
>>
>> 2> To reserve the GMs in our balloon code, drm_mm_reserve_node() is
>> preferred than the current drm_mm_insert_node_in_range_generic().
>>
>>    Am I correct? Please correct me if anything wrong. Thanks! :)
>
> Agreed. If you care to respin the patch, I'll see if anything else
> alarms me ;-)

Got it. Thank you, Chris.
> -Chris
>