From: Jike Song <jike.song@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 02/11] drm/i915: Clarify event_lock locking, irq&mixed context
Date: Mon, 29 Sep 2014 14:20:27 +0800 [thread overview]
Message-ID: <5428FA2B.8030005@intel.com> (raw)
In-Reply-To: <1410785732-18553-3-git-send-email-daniel.vetter@ffwll.ch>
On 09/15/2014 08:55 PM, Daniel Vetter wrote:
> Now we tackle the functions also called from interrupt handlers.
>
> - intel_check_page_flip is exclusively called from irq handlers, so a
> plain spin_lock is all we need. In i915_irq.c we have the convention
> to give all such functions an _irq_handler postfix, but that would
> look strange and als be a bit a misleading name. I've opted for a
> WARN_ON(!in_irq()) instead.
Hi Daniel,
Is it possible to use in_interrupt() instead? Sorry to tell that, in
our iGVT-g implementation, the host i915 irq handler needs to be called
in a non hardirq driven context. i.e. a tasklet or workqueue.
Will send you the RFC patches soon. Just saw a warning after rebased
upon new drm-intel-nightly.
--
Thanks,
Jike
next prev parent reply other threads:[~2014-09-29 6:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 12:55 [PATCH 00/11] Spinlock use clarification in i915 Daniel Vetter
2014-09-15 12:55 ` [PATCH 01/11] drm/i915: Clarify event_lock locking, process context Daniel Vetter
2014-09-15 12:55 ` [PATCH 02/11] drm/i915: Clarify event_lock locking, irq&mixed context Daniel Vetter
2014-09-29 6:20 ` Jike Song [this message]
2014-09-29 12:20 ` Daniel Vetter
2014-09-29 12:45 ` Jike Song
2014-09-29 13:27 ` Daniel Vetter
2014-09-30 10:22 ` Jike Song
2014-09-15 12:55 ` [PATCH 03/11] drm/i915: Clarify gpu_error.lock locking Daniel Vetter
2014-09-15 12:55 ` [PATCH 04/11] drm/i915: Clarify irq_lock locking, intel_tv_detect Daniel Vetter
2014-09-15 12:55 ` [PATCH 05/11] drm/i915: Clarify irq_lock locking, work functions Daniel Vetter
2014-09-15 12:55 ` [PATCH 06/11] drm/i915: Clarify irq_lock locking, interrupt install/uninstall Daniel Vetter
2014-09-15 12:55 ` [PATCH 07/11] drm/i915: Clarify irq_lock locking, irq handlers Daniel Vetter
2014-09-15 12:55 ` [PATCH 08/11] drm/i915: Clarify irq_lock locking, special cases Daniel Vetter
2014-09-15 12:55 ` [PATCH 09/11] drm/i915: Convert backlight_lock to a mutex Daniel Vetter
2014-09-15 12:55 ` [PATCH 10/11] drm/i915: Clarify uncore.lock locking Daniel Vetter
2014-09-15 12:55 ` [PATCH 11/11] drm/i915: Clarify mmio_flip_lock locking Daniel Vetter
2014-09-17 15:46 ` [PATCH 00/11] Spinlock use clarification in i915 Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5428FA2B.8030005@intel.com \
--to=jike.song@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox