From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH] drm/i915/skl: Use correct use counters for
 force wakes
Date: Tue, 30 Sep 2014 16:58:54 +0100
Message-ID: <542AD33E.1030300@linux.intel.com>
References: <1411640220-32696-1-git-send-email-tvrtko.ursulin@linux.intel.com>
 <1412086082-10144-1-git-send-email-tvrtko.ursulin@linux.intel.com>
 <20140930145703.GN19278@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTP id F047B6F3F3
 for <Intel-gfx@lists.freedesktop.org>; Tue, 30 Sep 2014 08:59:00 -0700 (PDT)
In-Reply-To: <20140930145703.GN19278@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, Intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org



On 09/30/2014 03:57 PM, Chris Wilson wrote:
> On Tue, Sep 30, 2014 at 03:08:02PM +0100, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Write and reads following the block changed use engine specific use counters
>> and unless that is matched here force wake use counting goes bad. Same
>> force wake is attempted to be taken twice which leads to at least time outs.
>>
>> NOTE: Depending on feedback from hardware designers it may not be necessary
>> to grab force wakes on Gen9 here. But for Gen8 it is needed due to a race
>> between RC6 and ELSP writes.
>>
>> v2: Added blitter force wake engine and made more future proof.
>>      Added commit note.
>
> Speaking of futureproofing, what did you think of my patch to remove the
> duplicated counting logic?

[For reference it is called "[PATCH] drm/i915: Reduce duplicated 
forcewake logic".]

Disclaimer: I don't know this code that well - only had to dig into it a 
few days back when I hit this bug which resulted in my patch.

But from a glance your patch does make it look cleaner and indeed more 
future proof (much better separation between platform specific and 
generic). Does it need a proper review to move it forward?

Regards,

Tvrtko