Re: [PATCH] drm/i915: Reduce duplicated forcewake logic

[Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>]

On 10/01/2014 04:53 PM, Tvrtko Ursulin wrote:
>
> On 09/10/2014 07:34 PM, Chris Wilson wrote:
>> Introduce a structure to track the individual forcewake domains and use
>> that to eliminated duplicate logic.
>> ---
>>   drivers/gpu/drm/i915/i915_debugfs.c |  41 +++---
>>   drivers/gpu/drm/i915/i915_drv.h     |  32 +++--
>>   drivers/gpu/drm/i915/intel_uncore.c | 265
>> ++++++++++++++++--------------------
>>   3 files changed, 157 insertions(+), 181 deletions(-)
>
> As said yesterday I like the idea, some comments and questions inline.

Forgot about intel_lrc.c which looks like wouldn't compile after this 
patch. :)

Regards,

Tvrtko