From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Reduce duplicated forcewake logic
Date: Wed, 01 Oct 2014 17:02:38 +0100
Message-ID: <542C259E.5090801@linux.intel.com>
References: <20140910155116.GD31074@nuc-i3427.alporthouse.com>
 <1410374094-5210-1-git-send-email-chris@chris-wilson.co.uk>
 <542C2363.1080603@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by gabe.freedesktop.org (Postfix) with ESMTP id A676C6E0BB
 for <intel-gfx@lists.freedesktop.org>; Wed,  1 Oct 2014 09:03:14 -0700 (PDT)
In-Reply-To: <542C2363.1080603@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org


On 10/01/2014 04:53 PM, Tvrtko Ursulin wrote:
>
> On 09/10/2014 07:34 PM, Chris Wilson wrote:
>> Introduce a structure to track the individual forcewake domains and use
>> that to eliminated duplicate logic.
>> ---
>>   drivers/gpu/drm/i915/i915_debugfs.c |  41 +++---
>>   drivers/gpu/drm/i915/i915_drv.h     |  32 +++--
>>   drivers/gpu/drm/i915/intel_uncore.c | 265
>> ++++++++++++++++--------------------
>>   3 files changed, 157 insertions(+), 181 deletions(-)
>
> As said yesterday I like the idea, some comments and questions inline.

Forgot about intel_lrc.c which looks like wouldn't compile after this 
patch. :)

Regards,

Tvrtko