From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Taking tiling and rotation into account in watermark computations Date: Mon, 06 Oct 2014 17:11:57 +0100 Message-ID: <5432BF4D.1010900@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id BB2BA6E09E for ; Mon, 6 Oct 2014 09:11:59 -0700 (PDT) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx List-Id: intel-gfx@lists.freedesktop.org Hi all, We need to refactor the current code a bit to allow parameters like plane rotation and framebuffer tiling mode be taken into account when calculating display watermarks. I looked into this code a bit and am at the moment a bit confused with what is where and why. For example the purpose of plane_config in intel_crtc seems a bit thin, or why it is created once on driver init. Then again watermark parameters are embedded in intel_plane, which is separate from plane_config. And where is the link between intel_crtc and intel_plane, or why intel_crtc has a plane field - is it not that there are multiple planes per pipe/crtc? Part one would be trying to understand how things are. Then part two would be coming up with a design, if justified by the extent of work required, to implement this requirement. Thanks, Tvrtko