From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Harrison Subject: Re: [RFC 00/21] Replace seqno values with request structures Date: Fri, 10 Oct 2014 13:03:17 +0100 Message-ID: <5437CB05.3040403@Intel.com> References: <1412604925-11290-1-git-send-email-John.C.Harrison@Intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0406058893==" Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 3D17B6E287 for ; Fri, 10 Oct 2014 05:03:32 -0700 (PDT) In-Reply-To: <1412604925-11290-1-git-send-email-John.C.Harrison@Intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Intel-GFX@Lists.FreeDesktop.Org List-Id: intel-gfx@lists.freedesktop.org This is a multi-part message in MIME format. --===============0406058893== Content-Type: multipart/alternative; boundary="------------060305040901030309020102" This is a multi-part message in MIME format. --------------060305040901030309020102 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit I have just posted an updated subset of the patch series. Note that one patch has been inserted in the middle and the first one has been dropped. The correct sequence is now: 01 drm/i915: Remove redundant parameter to i915_gem_object_wait_rendering__tail() 02 drm/i915: Ensure OLS & PLR are always in sync 03 drm/i915: Add reference count to request structure 04 drm/i915: Add helper functions to aid seqno -> request transition 05 drm/i915: Replace last_[rwf]_seqno with last_[rwf]_req 06 drm/i915: Ensure requests stick around during waits 07 drm/i915: Remove 'outstanding_lazy_seqno' 08 drm/i915: Make 'i915_gem_check_olr' actually check by request not seqno 09 drm/i915: Convert 'last_flip_req' to be a request not a seqno 10 drm/i915: Convert i915_wait_seqno to i915_wait_request 11 drm/i915: Convert 'i915_add_request' to take a request not a seqno 12 drm/i915: Convert mmio_flip::seqno to struct request 13 drm/i915: Convert 'flip_queued_seqno' into 'flip_queued_request' 14 drm/i915: Connect requests to rings at creation not submission 15 drm/i915: Convert most 'i915_seqno_passed' calls into 'i915_gem_request_completed' 16 drm/i915: Convert __wait_seqno() to __wait_request() 17 drm/i915: Convert trace functions from seqno to request 18 drm/i915: Convert 'trace_irq' to use requests rather than seqnos 19 drm/i915: Convert semaphores to handle requests not seqnos 20 drm/i915: Convert 'ring_idle()' to use requests not seqnos 21 drm/i915: Remove 'obj->ring' 22 drm/i915: Cache request completion status 23 drm/i915: Zero fill the request structure 24 drm/i915: Defer seqno allocation until actual hardware submission time The whole set in its latest and greatest form has also been uploaded to the drm-private git as 'topic/seqno-request'. On 06/10/2014 15:15, John.C.Harrison@Intel.com wrote: > From: John Harrison > > Work in progress for replacing seqno usage with requst structures. > > There is a general feeling that it is better to move away from using a simple > integer 'seqno' value to track batch buffer completion. Instead, the request > structure should be used. That provides for much more flexibility going > forwards. Especially which things like a GPU scheduler (which can re-order batch > buffers and hence seqnos after submission to the hardware), Android sync points > and other such features which potentially make seqno usage more and more > complex. > > The current set of patches do most of the seqno to request structure conversion. > There are still a couple of direct seqno comparisons in the semaphore code. The > final conversion of a seqno test into a 'completed' flag inside the request > structure is still do to as well. Along with whatever changes are required to > maintain such a flag. > > The patches are being posted now to make sure that the various people involved > agree that it is heading in the right direction. > > [Patches against drm-intel-nightly tree fetched 11/09/2014] > > John Harrison (21): > Bug: missing i915_seqno_passed() call? > drm/i915: Remove redundant parameter to i915_gem_object_wait_rendering__tail() > drm/i915: Ensure OLS & PLR are always in sync > drm/i915: Add reference count to request structure > drm/i915: Add helper functions to aid seqno -> request transition > drm/i915: Replace last_[rwf]_seqno with last_[rwf]_req > drm/i915: Ensure requests stick around during waits > drm/i915: Remove 'outstanding_lazy_seqno' > drm/i915: Make 'i915_gem_check_olr' actually check by request not seqno > drm/i915: Convert 'last_flip_req' to be a request not a seqno > drm/i915: Convert i915_wait_seqno to i915_wait_request > drm/i915: Convert 'i915_add_request' to take a request not a seqno > drm/i915: Convert mmio_flip::seqno to struct request > drm/i915: Convert 'flip_queued_seqno' into 'flip_queued_request' > drm/i915: Convert most 'i915_seqno_passed' calls into 'i915_gem_request_completed' > drm/i915: Convert __wait_seqno() to __wait_request() > drm/i915: Convert trace functions from seqno to request > drm/i915: Convert 'trace_irq' to use requests rather than seqnos > drm/i915: Convert semaphores to handle requests not seqnos > drm/i915: Convert 'ring_idle()' to use requests not seqnos > drm/i915: Remove 'obj->ring' > > drivers/gpu/drm/i915/i915_debugfs.c | 23 +-- > drivers/gpu/drm/i915/i915_drv.h | 64 +++++-- > drivers/gpu/drm/i915/i915_gem.c | 265 ++++++++++++++-------------- > drivers/gpu/drm/i915/i915_gem_context.c | 12 +- > drivers/gpu/drm/i915/i915_gem_execbuffer.c | 8 +- > drivers/gpu/drm/i915/i915_gem_gtt.h | 4 +- > drivers/gpu/drm/i915/i915_gem_tiling.c | 2 +- > drivers/gpu/drm/i915/i915_gpu_error.c | 19 +- > drivers/gpu/drm/i915/i915_irq.c | 12 +- > drivers/gpu/drm/i915/i915_trace.h | 47 ++--- > drivers/gpu/drm/i915/intel_display.c | 47 ++--- > drivers/gpu/drm/i915/intel_drv.h | 4 +- > drivers/gpu/drm/i915/intel_lrc.c | 49 ++--- > drivers/gpu/drm/i915/intel_overlay.c | 17 +- > drivers/gpu/drm/i915/intel_ringbuffer.c | 88 +++++---- > drivers/gpu/drm/i915/intel_ringbuffer.h | 24 ++- > 16 files changed, 392 insertions(+), 293 deletions(-) > --------------060305040901030309020102 Content-Type: text/html; charset=windows-1252 Content-Transfer-Encoding: quoted-printable I have just posted an updated subset of the patch series. Note that one patch has been inserted in the middle and the first one has been dropped. The correct sequence is now:
01 =A0=A0 drm/i915: Remove redundant parameter to i915_gem_object_wait_rendering__tail()
02=A0=A0=A0 drm/i915: Ensure OLS & PLR are always in s= ync
03=A0=A0=A0 drm/i915: Add reference count to request struc= ture
04=A0=A0=A0 drm/i915: Add helper functions to aid seqno -&= gt; request transition
05=A0=A0=A0 drm/i915: Replace last_[rwf]_seqno with last_[rwf]_req
06=A0=A0=A0 drm/i915: Ensure requests stick around during = waits
07=A0=A0=A0 drm/i915: Remove 'outstanding_lazy_seqno'=
08=A0=A0=A0 drm/i915: Make 'i915_gem_check_olr' actually c= heck by request not seqno
 09=A0=A0=A0 drm/i915: Convert 'last_flip_req' to be a request not= a seqno
10=A0=A0=A0 drm/i915: Convert i915_wait_seqno to i915_wait_request
11=A0=A0=A0 drm/i915: Convert 'i915_add_request' to take a request not a seqno
12=A0=A0=A0 drm/i915: Convert mmio_flip::seqno to struct request
 13=A0=A0=A0 drm/i915: Convert 'flip_queued_seqno' into 'flip_queued_request'
 14=A0=A0=A0 drm/i915: Connect requests to rings at creation not submission
 15=A0=A0=A0 drm/i915: Convert most 'i915_seqno_passed' calls into 'i915_gem_request_completed'
 16=A0=A0=A0 drm/i915: Convert __wait_seqno() to __wait_request()<= /tt>
 17=A0=A0=A0 drm/i915: Convert trace functions from seqno to reque= st
 18=A0=A0=A0 drm/i915: Convert 'trace_irq' to use requests rather = than seqnos
 19=A0=A0=A0 drm/i915: Convert semaphores to handle requests not s= eqnos
 20=A0=A0=A0 drm/i915: Convert 'ring_idle()' to use requests not s= eqnos
 21=A0=A0=A0 drm/i915: Remove 'obj->ring'
 22=A0=A0=A0 drm/i915: Cache request completion status 23 =A0=A0 drm/i915: Zero fill the request structure
 24 =A0=A0 drm/i915: Defer seqno allocation until actual hardware submission time

The whole set in its latest and greatest form has also been uploaded to the drm-private git as 'topic/seqno-request'.


On 06/10/2014 15:15, John.C.Harrison@Intel.com wrote:
From: John Harrison <John.C.Harrison@Intel.co=
m>

Work in progress for replacing seqno usage with requst structures.

There is a general feeling that it is better to move away from using a si=
mple
integer 'seqno' value to track batch buffer completion. Instead, the requ=
est
structure should be used. That provides for much more flexibility going
forwards. Especially which things like a GPU scheduler (which can re-orde=
r batch
buffers and hence seqnos after submission to the hardware), Android sync =
points
and other such features which potentially make seqno usage more and more
complex.

The current set of patches do most of the seqno to request structure conv=
ersion.
There are still a couple of direct seqno comparisons in the semaphore cod=
e. The
final conversion of a seqno test into a 'completed' flag inside the reque=
st
structure is still do to as well. Along with whatever changes are require=
d to
maintain such a flag.

The patches are being posted now to make sure that the various people inv=
olved
agree that it is heading in the right direction.

[Patches against drm-intel-nightly tree fetched 11/09/2014]

John Harrison (21):
  Bug: missing i915_seqno_passed() call?
  drm/i915: Remove redundant parameter to i915_gem_object_wait_rendering_=
_tail()
  drm/i915: Ensure OLS & PLR are always in sync
  drm/i915: Add reference count to request structure
  drm/i915: Add helper functions to aid seqno -> request transition
  drm/i915: Replace last_[rwf]_seqno with last_[rwf]_req
  drm/i915: Ensure requests stick around during waits
  drm/i915: Remove 'outstanding_lazy_seqno'
  drm/i915: Make 'i915_gem_check_olr' actually check by request not seqno
  drm/i915: Convert 'last_flip_req' to be a request not a seqno
  drm/i915: Convert i915_wait_seqno to i915_wait_request
  drm/i915: Convert 'i915_add_request' to take a request not a seqno
  drm/i915: Convert mmio_flip::seqno to struct request
  drm/i915: Convert 'flip_queued_seqno' into 'flip_queued_request'
  drm/i915: Convert most 'i915_seqno_passed' calls into 'i915_gem_request=
_completed'
  drm/i915: Convert __wait_seqno() to __wait_request()
  drm/i915: Convert trace functions from seqno to request
  drm/i915: Convert 'trace_irq' to use requests rather than seqnos
  drm/i915: Convert semaphores to handle requests not seqnos
  drm/i915: Convert 'ring_idle()' to use requests not seqnos
  drm/i915: Remove 'obj->ring'

 drivers/gpu/drm/i915/i915_debugfs.c        |   23 +--
 drivers/gpu/drm/i915/i915_drv.h            |   64 +++++--
 drivers/gpu/drm/i915/i915_gem.c            |  265 ++++++++++++++--------=
------
 drivers/gpu/drm/i915/i915_gem_context.c    |   12 +-
 drivers/gpu/drm/i915/i915_gem_execbuffer.c |    8 +-
 drivers/gpu/drm/i915/i915_gem_gtt.h        |    4 +-
 drivers/gpu/drm/i915/i915_gem_tiling.c     |    2 +-
 drivers/gpu/drm/i915/i915_gpu_error.c      |   19 +-
 drivers/gpu/drm/i915/i915_irq.c            |   12 +-
 drivers/gpu/drm/i915/i915_trace.h          |   47 ++---
 drivers/gpu/drm/i915/intel_display.c       |   47 ++---
 drivers/gpu/drm/i915/intel_drv.h           |    4 +-
 drivers/gpu/drm/i915/intel_lrc.c           |   49 ++---
 drivers/gpu/drm/i915/intel_overlay.c       |   17 +-
 drivers/gpu/drm/i915/intel_ringbuffer.c    |   88 +++++----
 drivers/gpu/drm/i915/intel_ringbuffer.h    |   24 ++-
 16 files changed, 392 insertions(+), 293 deletions(-)

--------------060305040901030309020102-- --===============0406058893== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0406058893==--