From mboxrd@z Thu Jan 1 00:00:00 1970 From: Todd Previte Subject: Re: [PATCH] drm/i915: Change order of operations for VLV/CHV to not train DP link before PHYs are ready Date: Fri, 10 Oct 2014 17:18:46 -0700 Message-ID: <54387766.4010702@gmail.com> References: <1412872632-49802-1-git-send-email-tprevite@gmail.com> <87lhoos63a.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com [209.85.220.48]) by gabe.freedesktop.org (Postfix) with ESMTP id 299496E0EB for ; Fri, 10 Oct 2014 17:18:50 -0700 (PDT) Received: by mail-pa0-f48.google.com with SMTP id eu11so2624815pac.7 for ; Fri, 10 Oct 2014 17:18:50 -0700 (PDT) In-Reply-To: <87lhoos63a.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMTAvMTAvMTQgMTowNCBBTSwgSmFuaSBOaWt1bGEgd3JvdGU6Cj4gT24gVGh1LCAwOSBPY3Qg MjAxNCwgVG9kZCBQcmV2aXRlPHRwcmV2aXRlQGdtYWlsLmNvbT4gIHdyb3RlOgo+PiBSZW9yZGVy IHRoZSBmdW5jdGlvbiBjYWxscyBpbiBjaHYvdmx2X3ByZV9lbmFibGVfZHAoKSBzdWNoIHRoYXQg bGluayB0cmFpbmluZyBpcyBub3QgaW5pdGlhdGVkCj4+IGJlZm9yZSB0aGUgUEhZcyBjb21lIHVw IG91dCBvZiByZXNldC4gQWxzbyBjaGVjayB0aGUgc3RhdHVzIG9mIHZsdl93YWl0X3BvcnRfcmVh ZHkoKSBhbmQKPj4gb25seSBhdHRlbXB0IHRvIHRyYWluIGlmIHRoZSBQSFlzIGFyZSBhY3R1YWxs eSBydW5uaW5nLgo+Pgo+PiBUaGUgc3BlY2lmaWNhdGlvbiBsaXN0cyB0aGUgd2FpdCBmb3IgdGhl IFBIWXMgYXMgb25lIG9mIHRoZSBmaW5hbCBzdGVwcyBpbiBlbmFibGluZwo+PiB0aGUgRGlzcGxh eXBvcnQgaGFyZHdhcmUgZm9yIHVzZS4gIFdoaWxlIHRoZSBQSFlzIGFyZSBpbiByZXNldCwgbm8g Y29tbXVuaWNhdGlvbiBpcyBwCj4+IG9zc2libGUgYWNyb3NzIHRoZSBsaW5rLiBBdHRlbXB0aW5n IHRvIHRyYWluIHRoZSBsaW5rIHdoaWxlIHRoZSBQSFlzIGFyZSBpbiByZXNldCB3aWxsCj4+IHJl c3VsdCBpbiBsaW5rIHRyYWluaW5nIGZhaWx1cmUgd2l0aCBvbmUgb3IgbW9yZSBXQVJOKCkgaW4g dGhlIGxvZ3MuIE1vdmluZyB0aGUKPj4gaW50ZWxfZW5hYmxlX2RwKCkgZnVuY3Rpb24gYWZ0ZXIg dmx2X3dhaXRfcG9ydF9yZWFkeSgpIGFuZCBvbmx5IHdoZW4gdGhlIFBIWXMgYXJlIHJlYWR5Cj4+ IGhlbHBzIGVuc3VyZSByZWxpYWJsZSBvcGVyYXRpb24gb2YgdGhlIERpc3BsYXlwb3J0IGxpbmsu Cj4gVGhlcmUncyBiZWVuIHNvbWUgYmFjayBhbmQgZm9ydGggYWJvdXQgdGhlIG1vZGUgc2V0IHNl cXVlbmNlIG9yZGVyaW5nIGluCj4gdGhlIHBhc3QuIFRoZXJlJ3MgYWxzbyBzb21lIGRpc2FncmVl bWVudCBiZXR3ZWVuIHNvbWUgc3BlY3MgYWJvdXQKPiB0aGlzLiBUaGUgcHVibGlzaGVkIGRpc3Bs YXkgc3BlYyBhdCAwMS5vcmcgc2F5cywKPgo+IOKAoiBFbmFibGUgcG9ydHMKPiDigKIgV2FpdCBm b3IgRFBJTyBwaHlzdGF0dXMgcmVhZHkgaW4gNjAxNAo+IOKAoiBFbmFibGUgcGlwZSBBL0IKPiDi gKIgRW5hYmxlIHBsYW5lcyAoVkdBIG9yIGhpcmVzKQo+Cj4gVGhpcyBpcyBpbiBsaW5lIHdpdGgg dGhlIGN1cnJlbnQgaW1wbGVtZW50YXRpb24uIEhvd2V2ZXIsIHRoZXJlJ3Mgbm8KPiBkZXRhaWxz IGFib3V0IHRoZSBsaW5rIHRyYWluaW5nIC0gcGVyaGFwcyB5b3UgY291bGQgdHJ5IHdhaXRpbmcg Zm9yIERQSU8KPiBwaHlzdGF0dXMgcmVhZHkgcmlnaHQgYWZ0ZXIgaW50ZWxfZHBfZW5hYmxlX3Bv cnQoKSBidXQgYmVmb3JlIGxpbmsKPiB0cmFpbmluZz8KPgo+IEJSLAo+IEphbmkuCj4KPgo+IFBT LiBQbGVhc2Ugd3JhcCB0aGUgY29tbWl0IG1lc3NhZ2VzIGF0LCBzYXksIDcyIGNoYXJhY3RlcnMu IEJlbG93IDgwCj4gYW55d2F5LgpUaGFua3MgZm9yIHRoZSBmZWVkYmFjaywgSmFuaS4gVGhhdCBt aWdodCBiZSBhIGdvb2Qgb3B0aW9uLiBUaGF0IAplc3NlbnRpYWxseSBtb3ZlcyB0aGUgd2FpdF9w b3J0X3JlYWR5IGludG8gdGhlIGludGVsX2VuYWJsZV9kcCgpIApmdW5jdGlvbiwgc28gaXQgd291 bGQgbmVlZCBhIHBsYXRmb3JtIGNoZWNrIHRoZXJlIGFzIHdlbGwuIE5vdCBhIGJpZyAKZGVhbCwg cmVhbGx5LiBBbHRlcm5hdGl2ZWx5LCAgaXQgbG9va3MgbGlrZSBpbnRlbF9kcF9lbmFibGVfcG9y dCgpIGNhbiAKYmUgbW92ZWQgb3V0IG9mIGludGVsX2VuYWJsZV9kcCgpIGFuZCBwbGFjZWQgcmln aHQgYmVmb3JlIHRoZSBjYWxsIHRvIAp2bHZfd2FpdF9wb3J0X3JlYWR5KCkuIFRoZXJlJ3Mgb25s eSBhIGZldyBwbGFjZXMgd2hlcmUgaW50ZWxfZW5hYmxlX2RwKCkgCmlzIGNhbGxlZCwgaXQgc2hv dWxkbid0IGJlIHRvbyBtdWNoIG9mIGFuIGlzc3VlIHRvIHB1bGwgCmludGVsX2RwX2VuYWJsZV9w b3J0KCkgb3V0IGFuZCBwbGFjZSBpdCB3aGVyZSBuZWNlc3NhcnkuIEknbGwgcG9zdCB0aGUgCnVw ZGF0ZWQgcGF0Y2ggYXMgc29vbiBhcyBpdCdzIHJlYWR5LgoKSSdsbCBhbWVuZCB0aGUgY29tbWl0 IG1lc3NhZ2UgYW5kIHdyYXAgaXQgdW5kZXIgODAgY2hhcnMsIHRvby4KCi1UCgo+PiBTaWduZWQt b2ZmLWJ5OiBUb2RkIFByZXZpdGU8dHByZXZpdGVAZ21haWwuY29tPgo+PiAtLS0KPj4gICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAgOCArKysrKystLQo+PiAgIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgICAgICB8IDEwICsrKystLS0tLS0KPj4gICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCAgICAgfCAgMiArLQo+PiAgIDMgZmlsZXMgY2hh bmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Rpc3BsYXkuYwo+PiBpbmRleCBjNTFkOTUwLi40YjI4MGMxIDEwMDY0NAo+PiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4+IEBAIC0xNzIzLDcgKzE3MjMsNyBAQCBz dGF0aWMgdm9pZCBjaHZfZGlzYWJsZV9wbGwoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2LCBlbnVtIHBpcGUgcGlwZSkKPj4gICAJbXV0ZXhfdW5sb2NrKCZkZXZfcHJpdi0+ZHBpb19s b2NrKTsKPj4gICB9Cj4+ICAgCj4+IC12b2lkIHZsdl93YWl0X3BvcnRfcmVhZHkoc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+PiAraW50IHZsdl93YWl0X3BvcnRfcmVhZHkoc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+PiAgIAkJc3RydWN0IGludGVsX2RpZ2l0 YWxfcG9ydCAqZHBvcnQpCj4+ICAgewo+PiAgIAl1MzIgcG9ydF9tYXNrOwo+PiBAQCAtMTc0Niw5 ICsxNzQ2LDEzIEBAIHZvaWQgdmx2X3dhaXRfcG9ydF9yZWFkeShzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYsCj4+ICAgCQlCVUcoKTsKPj4gICAJfQo+PiAgIAo+PiAtCWlmICh3YWl0 X2ZvcigoSTkxNV9SRUFEKGRwbGxfcmVnKSAmIHBvcnRfbWFzaykgPT0gMCwgMTAwMCkpCj4+ICsJ aWYgKHdhaXRfZm9yKChJOTE1X1JFQUQoZHBsbF9yZWcpICYgcG9ydF9tYXNrKSA9PSAwLCAxMDAw KSkgewo+PiAgIAkJV0FSTigxLCAidGltZWQgb3V0IHdhaXRpbmcgZm9yIHBvcnQgJWMgcmVhZHk6 IDB4JTA4eFxuIiwKPj4gICAJCSAgICAgcG9ydF9uYW1lKGRwb3J0LT5wb3J0KSwgSTkxNV9SRUFE KGRwbGxfcmVnKSk7Cj4+ICsJCXJldHVybiAtRUlPOwo+PiArCX0KPj4gKwo+PiArCXJldHVybiAw Owo+PiAgIH0KPj4gICAKPj4gICBzdGF0aWMgdm9pZCBpbnRlbF9wcmVwYXJlX3NoYXJlZF9kcGxs KHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZHAuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPj4gaW5k ZXggYTgzNTJjNC4uYWRhOGIwNyAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZHAuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4+IEBA IC0yNzA1LDkgKzI3MDUsOCBAQCBzdGF0aWMgdm9pZCB2bHZfcHJlX2VuYWJsZV9kcChzdHJ1Y3Qg aW50ZWxfZW5jb2RlciAqZW5jb2RlcikKPj4gICAJCXBwc191bmxvY2soaW50ZWxfZHApOwo+PiAg IAl9Cj4+ICAgCj4+IC0JaW50ZWxfZW5hYmxlX2RwKGVuY29kZXIpOwo+PiAtCj4+IC0Jdmx2X3dh aXRfcG9ydF9yZWFkeShkZXZfcHJpdiwgZHBvcnQpOwo+PiArCWlmICh2bHZfd2FpdF9wb3J0X3Jl YWR5KGRldl9wcml2LCBkcG9ydCkgPT0gMCkKPj4gKwkgICAgaW50ZWxfZW5hYmxlX2RwKGVuY29k ZXIpOwo+PiAgIH0KPj4gICAKPj4gICBzdGF0aWMgdm9pZCB2bHZfZHBfcHJlX3BsbF9lbmFibGUo c3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIpCj4+IEBAIC0yODA1LDkgKzI4MDQsOCBAQCBz dGF0aWMgdm9pZCBjaHZfcHJlX2VuYWJsZV9kcChzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2Rl cikKPj4gICAJCXBwc191bmxvY2soaW50ZWxfZHApOwo+PiAgIAl9Cj4+ICAgCj4+IC0JaW50ZWxf ZW5hYmxlX2RwKGVuY29kZXIpOwo+PiAtCj4+IC0Jdmx2X3dhaXRfcG9ydF9yZWFkeShkZXZfcHJp diwgZHBvcnQpOwo+PiArCWlmICh2bHZfd2FpdF9wb3J0X3JlYWR5KGRldl9wcml2LCBkcG9ydCkg PT0gMCkKPj4gKwkgICAgaW50ZWxfZW5hYmxlX2RwKGVuY29kZXIpOwo+PiAgIH0KPj4gICAKPj4g ICBzdGF0aWMgdm9pZCBjaHZfZHBfcHJlX3BsbF9lbmFibGUoc3RydWN0IGludGVsX2VuY29kZXIg KmVuY29kZXIpCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYu aCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4+IGluZGV4IGRjODA0NDQuLjJm ZjJjOGMgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4+IEBAIC04NzYsNyArODc2 LDcgQEAgaW50ZWxfd2FpdF9mb3JfdmJsYW5rKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIGludCBw aXBlKQo+PiAgIAlkcm1fd2FpdF9vbmVfdmJsYW5rKGRldiwgcGlwZSk7Cj4+ICAgfQo+PiAgIGlu dCBpcm9ubGFrZV9nZXRfbGFuZXNfcmVxdWlyZWQoaW50IHRhcmdldF9jbG9jaywgaW50IGxpbmtf YncsIGludCBicHApOwo+PiAtdm9pZCB2bHZfd2FpdF9wb3J0X3JlYWR5KHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiwKPj4gK2ludCB2bHZfd2FpdF9wb3J0X3JlYWR5KHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPj4gICAJCQkgc3RydWN0IGludGVsX2RpZ2l0YWxf cG9ydCAqZHBvcnQpOwo+PiAgIGJvb2wgaW50ZWxfZ2V0X2xvYWRfZGV0ZWN0X3BpcGUoc3RydWN0 IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPj4gICAJCQkJc3RydWN0IGRybV9kaXNwbGF5X21v ZGUgKm1vZGUsCj4+IC0tIAo+PiAxLjkuMQo+Pgo+PiBfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwo+PiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4+IEludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngK