From mboxrd@z Thu Jan  1 00:00:00 1970
From: Todd Previte <tprevite@gmail.com>
Subject: Re: [PATCH 10/10] drm/i915: Fix intel_dp_hot_plug()
Date: Fri, 10 Oct 2014 17:20:39 -0700
Message-ID: <543877D7.8030006@gmail.com>
References: <1412869090-48010-1-git-send-email-tprevite@gmail.com>	<1412869090-48010-11-git-send-email-tprevite@gmail.com>	<20141009154905.GM12897@nuc-i3427.alporthouse.com>
 <CAPM=9twtR6bCOs49qwAr0Q8+BeAtWH9PkQZOHcFg4NX8ppvD_A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-pd0-f180.google.com (mail-pd0-f180.google.com
 [209.85.192.180])
 by gabe.freedesktop.org (Postfix) with ESMTP id 965B489BFE
 for <intel-gfx@lists.freedesktop.org>; Fri, 10 Oct 2014 17:20:43 -0700 (PDT)
Received: by mail-pd0-f180.google.com with SMTP id fp1so2530035pdb.11
 for <intel-gfx@lists.freedesktop.org>; Fri, 10 Oct 2014 17:20:43 -0700 (PDT)
In-Reply-To: <CAPM=9twtR6bCOs49qwAr0Q8+BeAtWH9PkQZOHcFg4NX8ppvD_A@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Dave Airlie <airlied@gmail.com>, Chris Wilson <chris@chris-wilson.co.uk>, "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>, Dave Airlie <airlied@redhat.com>
List-Id: intel-gfx@lists.freedesktop.org

On 10/9/14 8:38 PM, Dave Airlie wrote:
> On 10 October 2014 01:49, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> On Thu, Oct 09, 2014 at 08:38:10AM -0700, Todd Previte wrote:
>>> The hot plug function for DP appears to have been broken somewhere along the way. Without
>>> this function being operational, hot plug events are not correctly received for compliance
>>> testing. This patch implements the necessary functionality to resolve that issue.
>> Perhaps a discussion of why it was removed and how the apparent conflict
>> should be resolved?
>>
>> In particular citing the commit that gutted the function and cc'ing the
>> author (Dave Airlie) and reviwers (you) are in order.
>>
>> commit 0e32b39ceed665bfa4a77a4bc307b6652b991632
>> Author: Dave Airlie <airlied@redhat.com>
>> Date:   Fri May 2 14:02:48 2014 +1000
>>
>>      drm/i915: add DP 1.2 MST support (v0.7)
> I'm sure this shouldn't be needed as we get short/long hotplug DP
> events in the pulse handler,
> not here.
>
> Dave.
Sounds good. Looking at the HPD pulse handler, I think I can get the 
necessary code in there for the non-MST case to get compliance testing 
working with just the pulse handler. The short pulse will catch it 
already, but I need to add code to the long pulse segment in order to 
get the correct notification there.

-T