From mboxrd@z Thu Jan  1 00:00:00 1970
From: Emil Velikov <emil.l.velikov@gmail.com>
Subject: Re: [RFC PATCH 3/3] libdrm: user mode helper for ipvr drm driver
Date: Thu, 16 Oct 2014 16:20:22 +0100
Message-ID: <543FE236.3000406@gmail.com>
References: <1413202558-31037-1-git-send-email-yao.cheng@intel.com>
 <543E3D2F.40707@gmail.com>
 <8FF7D634BEE4C2428EFFAB6B7E919E4B017BCEB8@shsmsx102.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
In-Reply-To: <8FF7D634BEE4C2428EFFAB6B7E919E4B017BCEB8@shsmsx102.ccr.corp.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: "Cheng, Yao" <yao.cheng@intel.com>, "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Cc: "Vetter, Daniel" <daniel.vetter@intel.com>, emil.l.velikov@gmail.com, "Jiang, Fei" <fei.jiang@intel.com>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On 16/10/14 15:33, Cheng, Yao wrote:
> Hi Emil,
> Sorry, what do you mean by "correctly aligned"? does it mean the paddings in this data structure?
> 
Afaict for compatibility reasons the struct size have to be "aligned"
(multiple of 8 bytes), or if you prefer - the struct is missing the
required padding :) I've only skimmed through the patch so it may be
that other structs are having this issue.

Cheers,
Emil

>> -----Original Message-----
>> From: Emil Velikov [mailto:emil.l.velikov@gmail.com]
>> Sent: Wednesday, October 15, 2014 5:24 PM
>> To: Cheng, Yao; intel-gfx@lists.freedesktop.org
>> Cc: emil.l.velikov@gmail.com; Jiang, Fei; dri-devel@lists.freedesktop.org;
>> Vetter, Daniel
>> Subject: Re: [RFC PATCH 3/3] libdrm: user mode helper for ipvr drm driver
>>
>> Hi Yao,
>>
>> struct drm_ipvr_gem_userptr does not seem to be correctly aligned - is
>> that intentional ? Might be worth checking if anything else in
>> ipvr_drm.h and ipvr_bufmgr.h is in the same boat.
>>
>> Cheers,
>> Emil
>>