public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Ander Conselvan de Oliveira <conselvan2@gmail.com>
To: "Daniel Vetter" <daniel@ffwll.ch>,
	"Damien Lespiau" <damien.lespiau@intel.com>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	ander.conselvan.de.oliveira@intel.com
Cc: intel-gfx@lists.freedesktop.org, gustavo.padovan@collabora.co.uk
Subject: Re: [PATCH 2/4] drm/i915: Introduce a vfunc for platform-specfic MMIO flip code
Date: Mon, 27 Oct 2014 16:38:04 +0200	[thread overview]
Message-ID: <544E58CC.10201@gmail.com> (raw)
In-Reply-To: <20141027142548.GQ26941@phenom.ffwll.local>

On 10/27/2014 04:25 PM, Daniel Vetter wrote:
> On Mon, Oct 27, 2014 at 11:08:20AM +0000, Damien Lespiau wrote:
>> On Mon, Oct 27, 2014 at 10:16:06AM +0100, Daniel Vetter wrote:
>>> On Sat, Oct 25, 2014 at 12:11:12AM +0100, Damien Lespiau wrote:
>>>> SKL will specialize it.
>>>>
>>>> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
>>>
>>> So with atomic I'd expect that we'd have one giant mmio_flip driver
>>> function and that just calls into the relevant platform/plane update
>>> hooks. Gustavo&Ville are working on that monster.
>>>
>>> Now this here seems to add another incarnation. Can't I have just one
>>> please?
>>
>> I'd be happy to have that, but are we talking before 3.19? SKL doesn't
>> flip at all without MMIO flips, so we'll need to have of of those by
>> 3.19.
>
> It shouldn't be a lot of fuzz really since it will more or less amount to
> calling the same low-level plane update functions for all of them. Or I'm
> confused about all this. Also I think Ander is starting to rework
> mmio_flip this week.

I did send a patch [1] related to mmio flip last week, but I wasn't 
aware of the grand plan for that "giant mmio_flip driver function". I'm 
learning the details as I go, so I should probably look into that, but 
at least for now I wasn't planning to much more than that patch.

Paulo gave me some comments (off-list, due to the mailman issues) that I 
plan to fix and then send a v2.

  [1] 
http://lists.freedesktop.org/archives/intel-gfx/2014-October/053792.html

Cheers,
Ander
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2014-10-27 14:38 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-24 23:11 [PATCH 1/4] drm/i915: Remove unnecessary test on the gen in intel_do_mmio_flip() Damien Lespiau
2014-10-24 23:11 ` [PATCH 2/4] drm/i915: Introduce a vfunc for platform-specfic MMIO flip code Damien Lespiau
2014-10-27  9:16   ` Daniel Vetter
2014-10-27 11:08     ` Damien Lespiau
2014-10-27 14:25       ` Daniel Vetter
2014-10-27 14:38         ` Ander Conselvan de Oliveira [this message]
2014-10-27 14:47           ` Ville Syrjälä
2014-10-27 14:53             ` Damien Lespiau
2014-10-28  7:25               ` Daniel Vetter
2014-10-28  7:42                 ` Damien Lespiau
2014-10-24 23:11 ` [PATCH 3/4] drm/i915: Add space between variable declarations and code Damien Lespiau
2014-10-25  9:03   ` Chris Wilson
2014-10-25 11:05     ` [PATCH 3/4 v2] " Damien Lespiau
2014-10-24 23:11 ` [PATCH 4/4] drm/i915/skl: Implement do_mmio_flip for SKL Damien Lespiau
2014-10-25 10:37   ` shuang.he
2014-10-25  9:01 ` [PATCH 1/4] drm/i915: Remove unnecessary test on the gen in intel_do_mmio_flip() Chris Wilson
2014-10-25  9:04   ` Chris Wilson
2014-10-25  9:05 ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=544E58CC.10201@gmail.com \
    --to=conselvan2@gmail.com \
    --cc=ander.conselvan.de.oliveira@intel.com \
    --cc=damien.lespiau@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=gustavo.padovan@collabora.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox