From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Harrison Subject: Re: [RFC 09/21] drm/i915: Make 'i915_gem_check_olr' actually check by request not seqno Date: Tue, 28 Oct 2014 14:01:52 +0000 Message-ID: <544FA1D0.8050307@Intel.com> References: <1412604925-11290-1-git-send-email-John.C.Harrison@Intel.com> <1412604925-11290-2-git-send-email-John.C.Harrison@Intel.com> <1412604925-11290-3-git-send-email-John.C.Harrison@Intel.com> <1412604925-11290-4-git-send-email-John.C.Harrison@Intel.com> <1412604925-11290-5-git-send-email-John.C.Harrison@Intel.com> <1412604925-11290-6-git-send-email-John.C.Harrison@Intel.com> <1412604925-11290-7-git-send-email-John.C.Harrison@Intel.com> <1412604925-11290-8-git-send-email-John.C.Harrison@Intel.com> <1412604925-11290-9-git-send-email-John.C.Harrison@Intel.com> <1412604925-11290-10-git-send-email-John.C.Harrison@Intel.com> <20141019125502.GW26941@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id F37196E3F4 for ; Tue, 28 Oct 2014 07:09:22 -0700 (PDT) In-Reply-To: <20141019125502.GW26941@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Intel-GFX@Lists.FreeDesktop.Org List-Id: intel-gfx@lists.freedesktop.org T24gMTkvMTAvMjAxNCAxMzo1NSwgRGFuaWVsIFZldHRlciB3cm90ZToKPiBPbiBNb24sIE9jdCAw NiwgMjAxNCBhdCAwMzoxNToxM1BNICswMTAwLCBKb2huLkMuSGFycmlzb25ASW50ZWwuY29tIHdy b3RlOgo+PiBGcm9tOiBKb2huIEhhcnJpc29uIDxKb2huLkMuSGFycmlzb25ASW50ZWwuY29tPgo+ IFRvIHRoaW4gY29tbWl0IG1lc3NhZ2UuCj4KPiBBbHNvIEkgd29uZGVyIHdoZXRoZXJlIHdlIHNo b3VsZCB0cmFjayB0aGUgb2xyIHN0YXRlIG1vcmUgZXhwbGljaXRseSBpbgo+IHRoZSByZXF1ZXN0 IHN0cnVjdHVyZSBpbnN0ZWFkIG9mIGp1bXBpbmcgdGhyb3VnaCBhbGwgdGhlc2UgaG9vcHMuIEFu ZAo+IGV4cGxpY2l0IG9sciBzdGF0ZSBmb3IgYSByZXF1ZXN0IG1pZ2h0IGFsc28gaGVscCB0byBj bGFyaWZ5IGNvbnRyb2wgZmxvdwo+IGFuZCBjaGVja3MgaW4gYSBidW5jaCBvZiBwbGFjZXMuCgpX aGF0IHdvdWxkIGJlIG5pY2VyIHdvdWxkIGJlIHRvIGdldCByaWQgb2YgdGhlIE9MUiBjb21wbGV0 ZWx5LiBJZiBjb2RlIAp3YW50cyB0byB3cml0ZSB0byB0aGUgcmluZyB0aGVuIGl0IHNob3VsZCBy ZXF1ZXN0IGEgcmVxdWVzdCBzdHJ1Y3R1cmUgYXQgCnRoZSBzdGFydCwgcGFzcyB0aGF0IHJlcXVl c3QgaW4gdG8gYWxsIHRoZSByaW5nIHdyaXRpbmcgY29kZSBhbmQgc3VibWl0IAp0aGUgc2FtZSBy ZXF1ZXN0IHN0cnVjdHVyZSBhdCB0aGUgZW5kLiBUaGUgd2hvbGUgaWRlYSBvZiBzb21lIHJhbmRv bSAKcmVxdWVzdCBmbG9hdGluZyBhcm91bmQgaW4gdGhlIGV0aGVyIHNjb29waW5nIHVwIGFueSBy aW5nIGFjY2Vzc2VzIHRoYXQgCmhhcHBlbiB0byBvY2N1ciB3aXRoIG5vIGlkZWEgYWJvdXQgb3du ZXJzaGlwLCBzZXF1ZW5jZSwgZXRjLiBqdXN0IHNlZW1zIApoaWdobHkgZG9kZ3kuIEluZGVlZCBp dCBkZWZpbml0ZWx5IGNhdXNlcyBpc3N1ZXMgd2l0aCB0aGUgc2NoZWR1bGVyIHdpdGggCnRoaW5n cyBsaWtlIHBhZ2UgZmxpcHMgYmVpbmcgbWl4ZWQgdXAgaW4gY29tcGxldGVseSB1bnJlbGF0ZWQg YmF0Y2ggCmJ1ZmZlciBzdWJtaXNzaW9ucyEgSSBiZWxpZXZlIHRoYXQgaXMgb25lIG9mIHRoZSB0 aGluZ3MgQ2hyaXMgZGlkIGluIGhpcyAKcmUtd3JpdGUgdGhlIHVuaXZlcnNlIHBhdGNoLgoKCj4+ IEZvcjogVklaLTQzNzcKPj4gU2lnbmVkLW9mZi1ieTogSm9obi5DLkhhcnJpc29uQEludGVsLmNv bQo+PiAtLS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oICAgICAgfCAgIDE3 ICsrKysrKysrKysrKysrKystCj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyAg ICAgIHwgICAyNSArKysrKysrKysrLS0tLS0tLS0tLS0tLS0tCj4+ICAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgICAgMiArLQo+PiAgIDMgZmlsZXMgY2hhbmdlZCwgMjcg aW5zZXJ0aW9ucygrKSwgMTcgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYu aAo+PiBpbmRleCAxNDAxMjY2Li45NTA0MjA2IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2Rydi5oCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2 LmgKPj4gQEAgLTI0ODMsNyArMjQ4Myw3IEBAIGJvb2wgaTkxNV9nZW1fcmV0aXJlX3JlcXVlc3Rz KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+PiAgIHZvaWQgaTkxNV9nZW1fcmV0aXJlX3JlcXVl c3RzX3Jpbmcoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqcmluZyk7Cj4+ICAgaW50IF9fbXVzdF9j aGVjayBpOTE1X2dlbV9jaGVja193ZWRnZShzdHJ1Y3QgaTkxNV9ncHVfZXJyb3IgKmVycm9yLAo+ PiAgIAkJCQkgICAgICBib29sIGludGVycnVwdGlibGUpOwo+PiAtaW50IF9fbXVzdF9jaGVjayBp OTE1X2dlbV9jaGVja19vbHIoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqcmluZywgdTMyIHNlcW5v KTsKPj4gK2ludCBfX211c3RfY2hlY2sgaTkxNV9nZW1fY2hlY2tfb2xyKHN0cnVjdCBkcm1faTkx NV9nZW1fcmVxdWVzdCAqcmVxKTsKPj4gICAKPj4gICBzdGF0aWMgaW5saW5lIGJvb2wgaTkxNV9y ZXNldF9pbl9wcm9ncmVzcyhzdHJ1Y3QgaTkxNV9ncHVfZXJyb3IgKmVycm9yKQo+PiAgIHsKPj4g QEAgLTMwMjAsNCArMzAyMCwxOSBAQCB3YWl0X3JlbWFpbmluZ19tc19mcm9tX2ppZmZpZXModW5z aWduZWQgbG9uZyB0aW1lc3RhbXBfamlmZmllcywgaW50IHRvX3dhaXRfbXMpCj4+ICAgCX0KPj4g ICB9Cj4+ICAgCj4+ICsvKioqKioqKioqKioqKioqKioqKioqKioqKiBEZXByZWNhdGVkICoqKioq KioqKioqKioqKioqKioqKioqKiovCj4gVGhlcmUncyBhIGdjYyBmbGFnIGZvciBmdW5jdGlvbnMg aWYgeW91IHdhbnQgdG8gbWFyayB0aGlzIGFzIGRlcHJhY2F0ZWQsCj4gb3RoZXJ3aXNlIEknZCBq dXN0IGdvIHdpdGggYSAiWFhYOiBUaGlzIHRlbXBvcmFyeSBmdW5jdGlvbiB3aWxsIGRpc2FwcGVh cgo+IGF0IHRoZSBlbmQgb2YgdGhlIHBhdGNoIHNlcmllcyIgc29tZXdoZXJlLgo+Cj4+ICtzdGF0 aWMgaW5saW5lIGludCBfX211c3RfY2hlY2sgaTkxNV9nZW1fY2hlY2tfb2xzKHN0cnVjdCBpbnRl bF9lbmdpbmVfY3MgKnJpbmcsIHUzMiBzZXFubykKPj4gK3sKPj4gKwlpbnQgcmV0Owo+PiArCj4+ ICsJQlVHX09OKCFtdXRleF9pc19sb2NrZWQoJnJpbmctPmRldi0+c3RydWN0X211dGV4KSk7Cj4g V0FSTl9PTiBpbnN0ZWFkIG9mIEJVR19PTiBmb3IgbG9ja2luZyBjaGVja3MuCj4KPj4gKwo+PiAr CXJldCA9IDA7Cj4+ICsJaWYgKHNlcW5vID09IGk5MTVfZ2VtX3JlcXVlc3RfZ2V0X3NlcW5vKHJp bmctPm91dHN0YW5kaW5nX2xhenlfcmVxdWVzdCkpCj4+ICsJCXJldCA9IGk5MTVfYWRkX3JlcXVl c3QocmluZywgTlVMTCk7Cj4+ICsKPj4gKwlyZXR1cm4gcmV0Owo+PiArfQo+PiArLyoqKioqKioq KioqKioqKioqKioqKioqKiogRGVwcmVjYXRlZCAqKioqKioqKioqKioqKioqKioqKioqKioqLwo+ PiArCj4+ICAgI2VuZGlmCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+PiBpbmRleCAwZDBlYjI2 Li4yYzdkZWNhIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5j Cj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPj4gQEAgLTEwOTcsMTkg KzEwOTcsMTggQEAgaTkxNV9nZW1fY2hlY2tfd2VkZ2Uoc3RydWN0IGk5MTVfZ3B1X2Vycm9yICpl cnJvciwKPj4gICB9Cj4+ICAgCj4+ICAgLyoKPj4gLSAqIENvbXBhcmUgc2Vxbm8gYWdhaW5zdCBv dXRzdGFuZGluZyBsYXp5IHJlcXVlc3QuIEVtaXQgYSByZXF1ZXN0IGlmIHRoZXkgYXJlCj4+IC0g KiBlcXVhbC4KPj4gKyAqIENvbXBhcmUgYXJiaXRyYXJ5IHJlcXVlc3QgYWdhaW5zdCBvdXRzdGFu ZGluZyBsYXp5IHJlcXVlc3QuIEVtaXQgb24gbWF0Y2guCj4+ICAgICovCj4+ICAgaW50Cj4+IC1p OTE1X2dlbV9jaGVja19vbHIoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqcmluZywgdTMyIHNlcW5v KQo+PiAraTkxNV9nZW1fY2hlY2tfb2xyKHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVx KQo+PiAgIHsKPj4gICAJaW50IHJldDsKPj4gICAKPj4gLQlCVUdfT04oIW11dGV4X2lzX2xvY2tl ZCgmcmluZy0+ZGV2LT5zdHJ1Y3RfbXV0ZXgpKTsKPj4gKwlCVUdfT04oIW11dGV4X2lzX2xvY2tl ZCgmcmVxLT5yaW5nLT5kZXYtPnN0cnVjdF9tdXRleCkpOwo+IFNhbWUgaGVyZS4gUGx1cyBwbGVh c2UgYSBzdGVybiB3YXJuaW5nIGluIHRoZSBjb21taXQgbWVzc2FnZSBhbmQgY2M6IHRvCj4gd2hv bWV2ZXIgd2hvIG1hbmFnZWQgdG8gc25lYWsgdGhpcyBpbiAoYW5kIGZhaWxlZCB0byBjYXRjaCBp dCBpbiByZXZpZXcpLgo+PiAgIAo+PiAgIAlyZXQgPSAwOwo+PiAtCWlmIChzZXFubyA9PSBpOTE1 X2dlbV9yZXF1ZXN0X2dldF9zZXFubyhyaW5nLT5vdXRzdGFuZGluZ19sYXp5X3JlcXVlc3QpKQo+ PiAtCQlyZXQgPSBpOTE1X2FkZF9yZXF1ZXN0KHJpbmcsIE5VTEwpOwo+PiArCWlmIChyZXEgPT0g cmVxLT5yaW5nLT5vdXRzdGFuZGluZ19sYXp5X3JlcXVlc3QpCj4+ICsJCXJldCA9IGk5MTVfYWRk X3JlcXVlc3QocmVxLT5yaW5nLCBOVUxMKTsKPj4gICAKPj4gICAJcmV0dXJuIHJldDsKPj4gICB9 Cj4+IEBAIC0xMjcxLDcgKzEyNzAsNyBAQCBpOTE1X3dhaXRfc2Vxbm8oc3RydWN0IGludGVsX2Vu Z2luZV9jcyAqcmluZywgdWludDMyX3Qgc2Vxbm8pCj4+ICAgCWlmIChyZXQpCj4+ICAgCQlyZXR1 cm4gcmV0Owo+PiAgIAo+PiAtCXJldCA9IGk5MTVfZ2VtX2NoZWNrX29scihyaW5nLCBzZXFubyk7 Cj4+ICsJcmV0ID0gaTkxNV9nZW1fY2hlY2tfb2xzKHJpbmcsIHNlcW5vKTsKPj4gICAJaWYgKHJl dCkKPj4gICAJCXJldHVybiByZXQ7Cj4+ICAgCj4+IEBAIC0xMzM4LDcgKzEzMzcsNiBAQCBpOTE1 X2dlbV9vYmplY3Rfd2FpdF9yZW5kZXJpbmdfX25vbmJsb2NraW5nKHN0cnVjdCBkcm1faTkxNV9n ZW1fb2JqZWN0ICpvYmosCj4+ICAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9 IGRldi0+ZGV2X3ByaXZhdGU7Cj4+ICAgCXN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcgPSBv YmotPnJpbmc7Cj4+ICAgCXVuc2lnbmVkIHJlc2V0X2NvdW50ZXI7Cj4+IC0JdTMyIHNlcW5vOwo+ PiAgIAlpbnQgcmV0Owo+PiAgIAo+PiAgIAlCVUdfT04oIW11dGV4X2lzX2xvY2tlZCgmZGV2LT5z dHJ1Y3RfbXV0ZXgpKTsKPj4gQEAgLTEzNDgsMjEgKzEzNDYsMTggQEAgaTkxNV9nZW1fb2JqZWN0 X3dhaXRfcmVuZGVyaW5nX19ub25ibG9ja2luZyhzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAq b2JqLAo+PiAgIAlpZiAoIXJlcSkKPj4gICAJCXJldHVybiAwOwo+PiAgIAo+PiAtCXNlcW5vID0g aTkxNV9nZW1fcmVxdWVzdF9nZXRfc2Vxbm8ocmVxKTsKPj4gLQlCVUdfT04oc2Vxbm8gPT0gMCk7 Cj4+IC0KPj4gICAJcmV0ID0gaTkxNV9nZW1fY2hlY2tfd2VkZ2UoJmRldl9wcml2LT5ncHVfZXJy b3IsIHRydWUpOwo+PiAgIAlpZiAocmV0KQo+PiAgIAkJcmV0dXJuIHJldDsKPj4gICAKPj4gLQly ZXQgPSBpOTE1X2dlbV9jaGVja19vbHIocmluZywgc2Vxbm8pOwo+PiArCXJldCA9IGk5MTVfZ2Vt X2NoZWNrX29scihyZXEpOwo+PiAgIAlpZiAocmV0KQo+PiAgIAkJcmV0dXJuIHJldDsKPj4gICAK Pj4gICAJcmVzZXRfY291bnRlciA9IGF0b21pY19yZWFkKCZkZXZfcHJpdi0+Z3B1X2Vycm9yLnJl c2V0X2NvdW50ZXIpOwo+PiAgIAlpOTE1X2dlbV9yZXF1ZXN0X3JlZmVyZW5jZShyZXEpOwo+PiAg IAltdXRleF91bmxvY2soJmRldi0+c3RydWN0X211dGV4KTsKPj4gLQlyZXQgPSBfX3dhaXRfc2Vx bm8ocmluZywgc2Vxbm8sIHJlc2V0X2NvdW50ZXIsIHRydWUsIE5VTEwsIGZpbGVfcHJpdik7Cj4+ ICsJcmV0ID0gX193YWl0X3NlcW5vKHJpbmcsIGk5MTVfZ2VtX3JlcXVlc3RfZ2V0X3NlcW5vKHJl cSksIHJlc2V0X2NvdW50ZXIsIHRydWUsIE5VTEwsIGZpbGVfcHJpdik7Cj4+ICAgCW11dGV4X2xv Y2soJmRldi0+c3RydWN0X211dGV4KTsKPj4gICAJaTkxNV9nZW1fcmVxdWVzdF91bnJlZmVyZW5j ZShyZXEpOwo+PiAgIAlpZiAocmV0KQo+PiBAQCAtMjc4Niw3ICsyNzgxLDcgQEAgaTkxNV9nZW1f b2JqZWN0X2ZsdXNoX2FjdGl2ZShzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqKQo+PiAg IAlpbnQgcmV0Owo+PiAgIAo+PiAgIAlpZiAob2JqLT5hY3RpdmUpIHsKPj4gLQkJcmV0ID0gaTkx NV9nZW1fY2hlY2tfb2xyKG9iai0+cmluZywgaTkxNV9nZW1fcmVxdWVzdF9nZXRfc2Vxbm8ob2Jq LT5sYXN0X3JlYWRfcmVxKSk7Cj4+ICsJCXJldCA9IGk5MTVfZ2VtX2NoZWNrX29scihvYmotPmxh c3RfcmVhZF9yZXEpOwo+PiAgIAkJaWYgKHJldCkKPj4gICAJCQlyZXR1cm4gcmV0Owo+PiAgIAo+ PiBAQCAtMjkxMyw3ICsyOTA4LDcgQEAgaTkxNV9nZW1fb2JqZWN0X3N5bmMoc3RydWN0IGRybV9p OTE1X2dlbV9vYmplY3QgKm9iaiwKPj4gICAJaWYgKHNlcW5vIDw9IGZyb20tPnNlbWFwaG9yZS5z eW5jX3NlcW5vW2lkeF0pIC8qIDwtLS0gYnJva2VuPyEgbmVlZHMgdG8gdXNlIGk5MTVfc2Vxbm9f cGFzc2VkKCk/Pz8gKi8KPj4gICAJCXJldHVybiAwOwo+PiAgIAo+PiAtCXJldCA9IGk5MTVfZ2Vt X2NoZWNrX29scihvYmotPnJpbmcsIHNlcW5vKTsKPj4gKwlyZXQgPSBpOTE1X2dlbV9jaGVja19v bHIob2JqLT5sYXN0X3JlYWRfcmVxKTsKPj4gICAJaWYgKHJldCkKPj4gICAJCXJldHVybiByZXQ7 Cj4+ICAgCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5 LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4gaW5kZXggNmRhMThj NS4uMmFmNDIxZSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+PiBA QCAtOTc3NSw3ICs5Nzc1LDcgQEAgc3RhdGljIGludCBpbnRlbF9wb3N0cG9uZV9mbGlwKHN0cnVj dCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmopCj4+ICAgCQkJICAgICAgaTkxNV9nZW1fcmVxdWVz dF9nZXRfc2Vxbm8ob2JqLT5sYXN0X3dyaXRlX3JlcSkpKQo+PiAgIAkJcmV0dXJuIDA7Cj4+ICAg Cj4+IC0JcmV0ID0gaTkxNV9nZW1fY2hlY2tfb2xyKHJpbmcsIGk5MTVfZ2VtX3JlcXVlc3RfZ2V0 X3NlcW5vKG9iai0+bGFzdF93cml0ZV9yZXEpKTsKPj4gKwlyZXQgPSBpOTE1X2dlbV9jaGVja19v bHIob2JqLT5sYXN0X3dyaXRlX3JlcSk7Cj4+ICAgCWlmIChyZXQpCj4+ICAgCQlyZXR1cm4gcmV0 Owo+PiAgIAo+PiAtLSAKPj4gMS43LjkuNQo+Pgo+PiBfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwo+PiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4+IEludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngK