From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ander Conselvan de Oliveira <conselvan2@gmail.com>
Subject: Re: [PATCH 1/6] drm/i915: factor out compute_config
 from __intel_set_mode
Date: Wed, 29 Oct 2014 16:30:43 +0200
Message-ID: <5450FA13.3080305@gmail.com>
References: <1414090247-28930-1-git-send-email-jbarnes@virtuousgeek.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTP id D24446E558
 for <intel-gfx@lists.freedesktop.org>; Wed, 29 Oct 2014 07:30:54 -0700 (PDT)
In-Reply-To: <1414090247-28930-1-git-send-email-jbarnes@virtuousgeek.org>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Jesse Barnes <jbarnes@virtuousgeek.org>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gMTAvMjMvMjAxNCAwOTo1MCBQTSwgSmVzc2UgQmFybmVzIHdyb3RlOgo+IFRoaXMgYWxsb3dz
IHVzIHRvIGNhbGN1bGF0ZSB0aGUgZnVsbCBwaXBlIGNvbmZpZyBiZWZvcmUgd2UgZG8gYW55IG1v
ZGUKPiBzZXR0aW5nIHdvcmsuCj4KPiBTaWduZWQtb2ZmLWJ5OiBKZXNzZSBCYXJuZXMgPGpiYXJu
ZXNAdmlydHVvdXNnZWVrLm9yZz4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs
X2Rpc3BsYXkuYyB8IDkzICsrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLQo+ICAg
MSBmaWxlIGNoYW5nZWQsIDY1IGluc2VydGlvbnMoKyksIDI4IGRlbGV0aW9ucygtKQo+Cj4gZGlm
ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMv
Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IGluZGV4IDZlNWJjM2MuLmQ1Zjk1ZTQgMTAw
NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIv
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTEwOTEwLDQ1ICsxMDkx
MCw2MiBAQCBzdGF0aWMgdm9pZCB1cGRhdGVfc2NhbmxpbmVfb2Zmc2V0KHN0cnVjdCBpbnRlbF9j
cnRjICpjcnRjKQo+ICAgCQljcnRjLT5zY2FubGluZV9vZmZzZXQgPSAxOwo+ICAgfQo+Cj4gK3N0
YXRpYyBpbnQgaW50ZWxfbW9kZXNldF9jb21wdXRlX2NvbmZpZyhzdHJ1Y3QgZHJtX2NydGMgKmNy
dGMsCgpzL2RybV9jcnRjL2ludGVsX2NydGMvCgo+ICsJCQkJCXN0cnVjdCBkcm1fZGlzcGxheV9t
b2RlICptb2RlLAo+ICsJCQkJCXN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiLAo+ICsJCQkJCXVu
c2lnbmVkICptb2Rlc2V0X3BpcGVzLAo+ICsJCQkJCXVuc2lnbmVkICpwcmVwYXJlX3BpcGVzLAo+
ICsJCQkJCXVuc2lnbmVkICpkaXNhYmxlX3BpcGVzKQo+ICt7Cj4gKwlzdHJ1Y3QgaW50ZWxfY3J0
Y19jb25maWcgKnBpcGVfY29uZmlnID0gTlVMTDsKPiArCWludCByZXQgPSAwOwo+ICsKPiArCWlu
dGVsX21vZGVzZXRfYWZmZWN0ZWRfcGlwZXMoY3J0YywgbW9kZXNldF9waXBlcywKPiArCQkJCSAg
ICAgcHJlcGFyZV9waXBlcywgZGlzYWJsZV9waXBlcyk7Cj4gKwo+ICsJaWYgKCFtb2Rlc2V0X3Bp
cGVzKQo+ICsJCWdvdG8gb3V0Owo+ICsKPiArCS8qIEhhY2s6IEJlY2F1c2Ugd2UgZG9uJ3QgKHll
dCkgc3VwcG9ydCBnbG9iYWwgbW9kZXNldCBvbiBtdWx0aXBsZQo+ICsJICogY3J0Y3MsIHdlIGRv
bid0IGtlZXAgdHJhY2sgb2YgdGhlIG5ldyBtb2RlIGZvciBtb3JlIHRoYW4gb25lIGNydGMuCj4g
KwkgKiBIZW5jZSBzaW1wbHkgY2hlY2sgd2hldGhlciBhbnkgYml0IGlzIHNldCBpbiBtb2Rlc2V0
X3BpcGVzIGluIGFsbCB0aGUKPiArCSAqIHBpZWNlcyBvZiBjb2RlIHRoYXQgYXJlIG5vdCB5ZXQg
Y29udmVydGVkIHRvIGRlYWwgd2l0aCBtdXRsaXBsZSBjcnRjcwo+ICsJICogY2hhbmdpbmcgdGhl
aXIgbW9kZSBhdCB0aGUgc2FtZSB0aW1lLiAqLwoKVGhpcyBjb21tZW50IHNlZW1zIG91dCBvZiBw
bGFjZSBoZXJlIHNpbmNlIGl0IHJlZmVycyB0byBjaGVja2luZyBmb3Igc2V0IApiaXRzIGluIG1v
ZGVzZXRfcGlwZXMuIEkgZ3Vlc3MgdGhlIGltcG9ydGFudCBwYXJ0IG9mIGl0IGlzIHRvIGV4cGxh
aW4gCnRoZSBmYWN0IHRoYXQgb25seSBvbmUgbmV3IHBpcGUgY29uZmlnIGlzIG9idGFpbmVkIGhl
cmUsIHNvIG1heWJlIGl0IGNhbiAKcmV3b3JkZWQgdG8gbWFrZSB0aGF0IGNsZWFyZXIuCgpBbmQg
dGhlcmUncyBhbm90aGVyICJpZiAobW9kZXNldF9waXBlcykiIGxlZnQgaW4gX19pbnRlbF9zZXRf
bW9kZSgpIHRvIAp3aGljaCB0aGlzIGNvbW1lbnQgYXBwbGllcy4KCj4gKwlwaXBlX2NvbmZpZyA9
IGludGVsX21vZGVzZXRfcGlwZV9jb25maWcoY3J0YywgZmIsIG1vZGUpOwo+ICsJaWYgKElTX0VS
UihwaXBlX2NvbmZpZykpIHsKPiArCQlyZXQgPSBQVFJfRVJSKHBpcGVfY29uZmlnKTsKPiArCQlw
aXBlX2NvbmZpZyA9IE5VTEw7Cj4gKwo+ICsJCWdvdG8gb3V0OwoKTm90aGluZyB3aWxsIHVzZSBw
aXBlX2NvbmZpZyBhZnRlciB0aGlzIHBvaW50LCBzbyB0aGVyZSdzIG5vIG5lZWQgdG8gc2V0IApp
dCB0byBOVUxMLgoKPiArCX0KPiArCWludGVsX2R1bXBfcGlwZV9jb25maWcodG9faW50ZWxfY3J0
YyhjcnRjKSwgcGlwZV9jb25maWcsCj4gKwkJCSAgICAgICAiW21vZGVzZXRdIik7Cj4gKwl0b19p
bnRlbF9jcnRjKGNydGMpLT5uZXdfY29uZmlnID0gcGlwZV9jb25maWc7Cj4gKwo+ICtvdXQ6Cj4g
KwlyZXR1cm4gcmV0OwoKVGhlcmUncyBub3RoaW5nIGJlaW5nIGRvbmUgaGVyZSwgc28gd2UgY291
bGQgYXZvaWQgdGhpcyBnb3RvIGRhbmNlIGFuZCAKanVzdCB1c2UgcmV0dXJucyBpbnN0ZWFkLgoK
QW55d2F5LCBtb3N0bHkgbml0IHBpY2tzLCBzbyBlaXRoZXIgd2F5LAoKUmV2aWV3ZWQtYnk6IEFu
ZGVyIENvbnNlbHZhbiBkZSBPbGl2ZWlyYSAKPGFuZGVyLmNvbnNlbHZhbi5kZS5vbGl2ZWlyYUBp
bnRlbC5jb20+Cgo+ICt9Cj4gKwo+ICAgc3RhdGljIGludCBfX2ludGVsX3NldF9tb2RlKHN0cnVj
dCBkcm1fY3J0YyAqY3J0YywKPiAgIAkJCSAgICBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9k
ZSwKPiAtCQkJICAgIGludCB4LCBpbnQgeSwgc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIpCj4g
KwkJCSAgICBpbnQgeCwgaW50IHksIHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiLAo+ICsJCQkg
ICAgdW5zaWduZWQgZGlzYWJsZV9waXBlcywKPiArCQkJICAgIHVuc2lnbmVkIHByZXBhcmVfcGlw
ZXMsCj4gKwkJCSAgICB1bnNpZ25lZCBtb2Rlc2V0X3BpcGVzKQo+ICAgewo+ICAgCXN0cnVjdCBk
cm1fZGV2aWNlICpkZXYgPSBjcnRjLT5kZXY7Cj4gICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg
KmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiAgIAlzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9k
ZSAqc2F2ZWRfbW9kZTsKPiAgIAlzdHJ1Y3QgaW50ZWxfY3J0Y19jb25maWcgKnBpcGVfY29uZmln
ID0gTlVMTDsKPiAgIAlzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YzsKPiAtCXVuc2lnbmVk
IGRpc2FibGVfcGlwZXMsIHByZXBhcmVfcGlwZXMsIG1vZGVzZXRfcGlwZXM7Cj4gICAJaW50IHJl
dCA9IDA7Cj4KPiAgIAlzYXZlZF9tb2RlID0ga21hbGxvYyhzaXplb2YoKnNhdmVkX21vZGUpLCBH
RlBfS0VSTkVMKTsKPiAgIAlpZiAoIXNhdmVkX21vZGUpCj4gICAJCXJldHVybiAtRU5PTUVNOwo+
Cj4gLQlpbnRlbF9tb2Rlc2V0X2FmZmVjdGVkX3BpcGVzKGNydGMsICZtb2Rlc2V0X3BpcGVzLAo+
IC0JCQkJICAgICAmcHJlcGFyZV9waXBlcywgJmRpc2FibGVfcGlwZXMpOwo+IC0KPiAgIAkqc2F2
ZWRfbW9kZSA9IGNydGMtPm1vZGU7Cj4KPiAtCS8qIEhhY2s6IEJlY2F1c2Ugd2UgZG9uJ3QgKHll
dCkgc3VwcG9ydCBnbG9iYWwgbW9kZXNldCBvbiBtdWx0aXBsZQo+IC0JICogY3J0Y3MsIHdlIGRv
bid0IGtlZXAgdHJhY2sgb2YgdGhlIG5ldyBtb2RlIGZvciBtb3JlIHRoYW4gb25lIGNydGMuCj4g
LQkgKiBIZW5jZSBzaW1wbHkgY2hlY2sgd2hldGhlciBhbnkgYml0IGlzIHNldCBpbiBtb2Rlc2V0
X3BpcGVzIGluIGFsbCB0aGUKPiAtCSAqIHBpZWNlcyBvZiBjb2RlIHRoYXQgYXJlIG5vdCB5ZXQg
Y29udmVydGVkIHRvIGRlYWwgd2l0aCBtdXRsaXBsZSBjcnRjcwo+IC0JICogY2hhbmdpbmcgdGhl
aXIgbW9kZSBhdCB0aGUgc2FtZSB0aW1lLiAqLwo+IC0JaWYgKG1vZGVzZXRfcGlwZXMpIHsKPiAt
CQlwaXBlX2NvbmZpZyA9IGludGVsX21vZGVzZXRfcGlwZV9jb25maWcoY3J0YywgZmIsIG1vZGUp
Owo+IC0JCWlmIChJU19FUlIocGlwZV9jb25maWcpKSB7Cj4gLQkJCXJldCA9IFBUUl9FUlIocGlw
ZV9jb25maWcpOwo+IC0JCQlwaXBlX2NvbmZpZyA9IE5VTEw7Cj4gLQo+IC0JCQlnb3RvIG91dDsK
PiAtCQl9Cj4gLQkJaW50ZWxfZHVtcF9waXBlX2NvbmZpZyh0b19pbnRlbF9jcnRjKGNydGMpLCBw
aXBlX2NvbmZpZywKPiAtCQkJCSAgICAgICAiW21vZGVzZXRdIik7Cj4gLQkJdG9faW50ZWxfY3J0
YyhjcnRjKS0+bmV3X2NvbmZpZyA9IHBpcGVfY29uZmlnOwo+IC0JfQo+IC0KPiAgIAkvKgo+ICAg
CSAqIFNlZSBpZiB0aGUgY29uZmlnIHJlcXVpcmVzIGFueSBhZGRpdGlvbmFsIHByZXBhcmF0aW9u
LCBlLmcuCj4gICAJICogdG8gYWRqdXN0IGdsb2JhbCBzdGF0ZSB3aXRoIHBpcGVzIG9mZi4gIFdl
IG5lZWQgdG8gZG8gdGhpcwo+IEBAIC0xMTA0MiwxOSArMTEwNTksMjIgQEAgZG9uZToKPiAgIAlp
ZiAocmV0ICYmIGNydGMtPmVuYWJsZWQpCj4gICAJCWNydGMtPm1vZGUgPSAqc2F2ZWRfbW9kZTsK
Pgo+IC1vdXQ6Cj4gICAJa2ZyZWUocGlwZV9jb25maWcpOwo+ICAgCWtmcmVlKHNhdmVkX21vZGUp
Owo+ICAgCXJldHVybiByZXQ7Cj4gICB9Cj4KPiAtc3RhdGljIGludCBpbnRlbF9zZXRfbW9kZShz
dHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gLQkJCSAgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1v
ZGUsCj4gLQkJCSAgaW50IHgsIGludCB5LCBzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYikKPiAr
c3RhdGljIGludCBpbnRlbF9zZXRfbW9kZV9waXBlcyhzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4g
KwkJCQlzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZSwKPiArCQkJCWludCB4LCBpbnQgeSwg
c3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIsCj4gKwkJCQl1bnNpZ25lZCBtb2Rlc2V0X3BpcGVz
LAo+ICsJCQkJdW5zaWduZWQgcHJlcGFyZV9waXBlcywKPiArCQkJCXVuc2lnbmVkIGRpc2FibGVf
cGlwZXMpCj4gICB7Cj4gICAJaW50IHJldDsKPgo+IC0JcmV0ID0gX19pbnRlbF9zZXRfbW9kZShj
cnRjLCBtb2RlLCB4LCB5LCBmYik7Cj4gKwlyZXQgPSBfX2ludGVsX3NldF9tb2RlKGNydGMsIG1v
ZGUsIHgsIHksIGZiLCBtb2Rlc2V0X3BpcGVzLAo+ICsJCQkgICAgICAgcHJlcGFyZV9waXBlcywg
ZGlzYWJsZV9waXBlcyk7Cj4KPiAgIAlpZiAocmV0ID09IDApCj4gICAJCWludGVsX21vZGVzZXRf
Y2hlY2tfc3RhdGUoY3J0Yy0+ZGV2KTsKPiBAQCAtMTEwNjIsNiArMTEwODIsMjMgQEAgc3RhdGlj
IGludCBpbnRlbF9zZXRfbW9kZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gICAJcmV0dXJuIHJl
dDsKPiAgIH0KPgo+ICtzdGF0aWMgaW50IGludGVsX3NldF9tb2RlKHN0cnVjdCBkcm1fY3J0YyAq
Y3J0YywKPiArCQkJICBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZSwKPiArCQkJICBpbnQg
eCwgaW50IHksIHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiKQo+ICt7Cj4gKwl1bnNpZ25lZCBt
b2Rlc2V0X3BpcGVzLCBwcmVwYXJlX3BpcGVzLCBkaXNhYmxlX3BpcGVzOwo+ICsJaW50IHJldDsK
PiArCj4gKwlyZXQgPSBpbnRlbF9tb2Rlc2V0X2NvbXB1dGVfY29uZmlnKGNydGMsIG1vZGUsIGZi
LAo+ICsJCQkJCSAgICZtb2Rlc2V0X3BpcGVzLCAmcHJlcGFyZV9waXBlcywKPiArCQkJCQkgICAm
ZGlzYWJsZV9waXBlcyk7Cj4gKwlpZiAocmV0KQo+ICsJCXJldHVybiByZXQ7Cj4gKwo+ICsJcmV0
dXJuIGludGVsX3NldF9tb2RlX3BpcGVzKGNydGMsIG1vZGUsIHgsIHksIGZiLCBtb2Rlc2V0X3Bp
cGVzLAo+ICsJCQkJICAgIHByZXBhcmVfcGlwZXMsIGRpc2FibGVfcGlwZXMpOwo+ICt9Cj4gKwo+
ICAgdm9pZCBpbnRlbF9jcnRjX3Jlc3RvcmVfbW9kZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4g
ICB7Cj4gICAJaW50ZWxfc2V0X21vZGUoY3J0YywgJmNydGMtPm1vZGUsIGNydGMtPngsIGNydGMt
PnksIGNydGMtPnByaW1hcnktPmZiKTsKPgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu
ZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0
aW5mby9pbnRlbC1nZngK