From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH] drm/i915: Bug fixes to ring 'head' updating Date: Tue, 04 Nov 2014 14:17:07 +0000 Message-ID: <5458DFE3.8030003@intel.com> References: <1415021344-24875-1-git-send-email-david.s.gordon@intel.com> <20141103205950.GI13658@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 6DC9B6E02E for ; Tue, 4 Nov 2014 06:18:20 -0800 (PST) In-Reply-To: <20141103205950.GI13658@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMDMvMTEvMTQgMjA6NTksIENocmlzIFdpbHNvbiB3cm90ZToKPiBPbiBNb24sIE5vdiAwMywg MjAxNCBhdCAwMToyOTowNFBNICswMDAwLCBEYXZlIEdvcmRvbiB3cm90ZToKPj4gRml4ZXMgdG8g Ym90aCB0aGUgTFJDIGFuZCB0aGUgbGVnYWN5IHJpbmdidWZmZXIgY29kZSB0byBjb3JyZWN0bHkK Pj4gY2FsY3VsYXRlIGFuZCB1cGRhdGUgdGhlIGF2YWlsYWJsZSBzcGFjZSBpbiBhIHJpbmcuCj4+ Cj4+IFRoZSBsb2dpY2FsIHJpbmcgY29kZSB3YXMgdXBkYXRpbmcgdGhlIHNvZnR3YXJlIHJpbmcg J2hlYWQnIHZhbHVlCj4+IGJ5IHJlYWRpbmcgdGhlIGhhcmR3YXJlICdIRUFEJyByZWdpc3Rlci4g SW4gTFJDIG1vZGUsIHRoaXMgaXMgbm90Cj4+IHZhbGlkIGFzIHRoZSBoYXJkd2FyZSBpcyBub3Qg bmVjZXNzYXJpbHkgZXhlY3V0aW5nIHRoZSBzYW1lIGNvbnRleHQKPj4gdGhhdCBpcyBiZWluZyBw cm9jZXNzZWQgYnkgdGhlIHNvZnR3YXJlLiBUaHVzIHJlYWRpbmcgdGhlIGgvdyBIRUFECj4+IGNv dWxkIHB1dCBhbiB1bnJlbGF0ZWQgKHVuZGVmaW5lZCwgZWZmZWN0aXZlbHkgcmFuZG9tKSB2YWx1 ZSBpbnRvCj4+IHRoZSBzL3cgJ2hlYWQnIC0tIEEgQmFkIFRoaW5nIGZvciB0aGUgZnJlZSBzcGFj ZSBjYWxjdWxhdGlvbnMuCj4+Cj4+IEluIGFkZGl0aW9uLCB0aGUgb2xkIGNvZGUgY291bGQgdXBk YXRlIGEgcmluZ2J1ZmZlcidzICdoZWFkJyB2YWx1ZQo+PiBmcm9tIHRoZSAnbGFzdF9yZXRpcmVk X2hlYWQnIGV2ZW4gd2hlbiB0aGUgbGF0dGVyIGhhZG4ndCBiZWVuIHJlY2VudGx5Cj4+IHVwZGF0 ZWQgYW5kIHRoZXJlZm9yZSBoYWQgYSB2YWx1ZSBvZiAtMTsgdGhpcyB3b3VsZCBhbHNvIGNvbmZ1 c2UgdGhlCj4+IGZyZWVzcGFjZSBjYWxjdWxhdGlvbnMuIE5vdywgd2UgY29uc3VtZSAnbGFzdF9y ZXRpcmVkX2hlYWQnIGluIGp1c3QKPj4gb25lIHBsYWNlLCBlbnN1cmluZyB0aGF0IHRoaXMgY29u ZnVzaW9uIGRvZXMgbm90IGFyaXNlLgo+IAo+IFdoYXQ/IE5vdCB1bmxlc3Mgc29tZW9uZSBoYWQg YnJva2VuIGl0Li4uCj4gCj4gVGhpcyBpcyB0aGUgY29kZSBJIGV4cGVjdCB0byBzZWUgaGVyZSBi YXNlZCBvbiByZXF1ZXN0czoKPiAKPiBzdGF0aWMgaW50IHJpbmdfd2FpdChzdHJ1Y3QgaW50ZWxf cmluZ2J1ZmZlciAqcmluZywgaW50IG4pCj4gewo+ICAgICAgICAgaW50IHJldDsKPiAKPiAgICAg ICAgIHRyYWNlX2ludGVsX3JpbmdidWZmZXJfd2FpdChyaW5nLCBuKTsKPiAKPiAgICAgICAgIGRv IHsKPiAgICAgICAgICAgICAgICAgc3RydWN0IGk5MTVfZ2VtX3JlcXVlc3QgKnJxOwo+IAo+ICAg ICAgICAgICAgICAgICBpOTE1X2dlbV9yZXRpcmVfcmVxdWVzdHNfX2VuZ2luZShyaW5nLT5lbmdp bmUpOwo+ICAgICAgICAgICAgICAgICBpZiAocmluZy0+cmV0aXJlZF9oZWFkICE9IC0xKSB7Cj4g ICAgICAgICAgICAgICAgICAgICAgICAgcmluZy0+aGVhZCA9IHJpbmctPnJldGlyZWRfaGVhZDsK PiAgICAgICAgICAgICAgICAgICAgICAgICByaW5nLT5yZXRpcmVkX2hlYWQgPSAtMTsKPiAKPiAg ICAgICAgICAgICAgICAgICAgICAgICByaW5nLT5zcGFjZSA9IGludGVsX3Jpbmdfc3BhY2Uocmlu Zyk7Cj4gICAgICAgICAgICAgICAgICAgICAgICAgaWYgKHJpbmctPnNwYWNlID49IG4pCj4gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gMDsKPiAgICAgICAgICAgICAgICAg fQo+IAo+ICAgICAgICAgICAgICAgICBsaXN0X2Zvcl9lYWNoX2VudHJ5KHJxLCAmcmluZy0+YnJl YWRjcnVtYnMsIGJyZWFkY3J1bWJfbGluaykKPiAgICAgICAgICAgICAgICAgICAgICAgICBpZiAo X19pbnRlbF9yaW5nX3NwYWNlKHJxLT50YWlsLCByaW5nLT50YWlsLAo+ICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmluZy0+c2l6ZSwgSTkxNV9SSU5HX1JT VkQpID49IG4pCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBicmVhazsKPiAKPiAg ICAgICAgICAgICAgICAgaWYgKFdBUk5fT04oJnJxLT5icmVhZGNydW1iX2xpbmsgPT0gJnJpbmct PmJyZWFkY3J1bWJzKSkKPiAgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gLUVERUFETEs7 Cj4gCj4gICAgICAgICAgICAgICAgIHJldCA9IGk5MTVfcmVxdWVzdF93YWl0KHJxKTsKPiAgICAg ICAgIH0gd2hpbGUgKHJldCA9PSAwKTsKPiAKPiAgICAgICAgIHJldHVybiByZXQ7Cj4gfQoKSSBs aWtlIHRoaXMgc2FtcGxlIGNvZGUgYmV0dGVyIHRoYW4gdGhlIHZlcnNpb24gY3VycmVudGx5IGlu IHRoZSBkcml2ZXIsCmJlY2F1c2UgaXQsIGxpa2UgbXkgcGF0Y2gsIGhhcyBvbmx5IG9uZSBwbGFj ZSB3aGVyZSB0aGUgdmFsdWUgaXMKdHJhbnNmZXJyZWQgZnJvbSAncmV0aXJlZF9oZWFkJyB0byAn aGVhZCcsIGFuZCBpdCdzIGNsZWFybHkgZ3VhcmRlZCBieSBhCnRlc3QgdGhhdCAncmV0aXJlZF9o ZWFkJyBpcyBub3QgLTEuIEJ1dCB0aGlzIGlzbid0IGFjdHVhbGx5IHRoZSBjb2RlIHdlCmhhdmUs IHdoaWNoIGhhcyBmb3VyIHBsYWNlcyB3aGVyZSB0aGlzIGNvcHlpbmcgaXMgZG9uZSAodHdvIGZv ciBMUkMgYW5kCnR3byBmb3IgbGVnYWN5KSwgYW5kIG9uZSBpbiBlYWNoIHBhdGggaXMgbm90IHNv IGd1YXJkZWQuIFNvICp0aGF0J3MqCndoYXQgSSdtIGZpeGluZy4KCkl0IGxvb2tzIGxpa2UgdGhp cyBjb2RlIGFsc28gYXNzdW1lcyBvbmUgcmVxdWVzdCBxdWV1ZSBwZXIgcmluZ2J1ZmZlciwKcmF0 aGVyIHRoYW4gb25lIHBlciBlbmdpbmUsIHdoaWNoIG1heSBiZSBuaWNlciBidXQgaXNuJ3Qgd2hh dCB3ZQpjdXJyZW50bHkgaGF2ZS4KCj4gYW5kIHRoYXQgd29ya3MgZm9yIGJvdGggZXhlY2xpc3Rz IGFuZCByZWd1bGFyLi4uCj4gLUNocmlzCgpNeSBjYWxjdWxhdGUtZnJlZXNwYWNlIGFuZCB1cGRh dGUtZnJlZXNwYWNlIGZ1bmN0aW9ucyBhcmUgbGlrZXdpc2UKTFJDLWFnbm9zdGljLCBhbHRob3Vn aCB0aGUgd2FpdF9mb3JfcmVxdWVzdC93YWl0X2Zvcl9zcGFjZSBmdW5jdGlvbnMKdGhhdCB0aGV5 J3JlIGNhbGxlZCBmcm9tIGhhdmUgKHJlZ3JldHRhYmx5KSBiZWVuIGR1cGxpY2F0ZWQuIE5vdCBt eQpjYWxsLCB0aG91Z2guCgpGaW5hbGx5LCBteSBuZXcgY29kZSBpcyBtb3JlIHJlc2lsaWVudCBh Z2FpbnN0IG1pc3VzZSB0aGFuIHRoZSBjdXJyZW50CnZlcnNpb24uIEF0IHByZXNlbnQsIGlmIGEg c2VxdWVuY2Ugb2YgZW1pdCgpcyBvdmVycnVucyB0aGUgYWxsb2NhdGVkCmxlbmd0aCAocG9zc2li bHkgZHVlIHRvIGRpc3BsYXkgY29kZSBpbmplY3RpbmcgZXh0cmEgaW5zdHJ1Y3Rpb24gd2l0aG91 dApzZXR0aW5nIHVwIGl0cyBvd24gcmluZ19iZWdpbi9hZGRfcmVxdWVzdCBwYWlyLCBvciBzaW1w bHkgYSBidWcpLCB0aGVuCnRoZSByaW5nIHNwYWNlIGNhbGN1bGF0aW9uIGNhbiBpbiBzb21lIGNh c2VzIGNsYWltIHRoYXQgdGhlcmUncyBzdWRkZW5seQphIExPVCBvZiBzcGFjZSAoZHVlIHRvIHRo ZSB3YXkgdGhlIG1vZHVsbyBhcml0aG1ldGljIGlzIGRvbmUpIGFuZApjb25mdXNpb24gd2lsbCBm b2xsb3cuIE15IHZlcnNpb24gd2lsbCByZXR1cm4gIm5vIHNwYWNlIiByYXRoZXIgdGhhbiAiYQps b3Qgb2Ygc3BhY2UiIGluIHRoaXMgc2l0dWF0aW9uLgoKQlRXLCBJIGhhdmUgc29tZSBsb2NhbCBw YXRjaGVzIHdoaWNoIGVuZm9yY2Ugc3RyaWN0IGNoZWNraW5nIG9mCnJpbmdfYmVnaW4vYWRkX3Jl cXVlc3QgcGFpcmluZyBhbmQgZ2VuZXJhdGVzIHdhcm5pbmdzIGlmIHRoZXJlJ3MgYQptaXNtYXRj aCBvciBhbiBvdmVycnVuIG9yIGFueSBvdGhlciBtaXN1c2UuIFdlJ3ZlIGJlZW4gdXNpbmcgdGhl c2UgdG8KaGVscCBpZGVudGlmeSBhbmQgZWxpbWluYXRlIGNvZGUgdGhhdCBqdXN0IHN0dWZmcyBp bnN0cnVjdGlvbnMgaW50byB0aGUKcmluZyB3aXRob3V0IG5vdGlmeWluZyB0aGUgc2NoZWR1bGVy LiBJbnRlcmVzdGVkPwoKLkRhdmUuCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cg==