From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ander Conselvan de Oliveira Subject: Re: [PATCH 2/6] drm/i915: use compute_config in set_config v3 Date: Fri, 07 Nov 2014 11:41:48 +0200 Message-ID: <545C93DC.8060305@gmail.com> References: <1415226371-1880-1-git-send-email-jbarnes@virtuousgeek.org> <1415226371-1880-2-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id BC01C6F31F for ; Fri, 7 Nov 2014 01:41:47 -0800 (PST) In-Reply-To: <1415226371-1880-2-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jesse Barnes , intel-gfx@lists.freedesktop.org Cc: shuang.he@linux.intel.com List-Id: intel-gfx@lists.freedesktop.org T24gMTEvMDYvMjAxNCAxMjoyNiBBTSwgSmVzc2UgQmFybmVzIHdyb3RlOgo+IFRoaXMgd2lsbCBh bGxvdyB1cyB0byBjb25zdWx0IG1vcmUgaW5mbyBiZWZvcmUgZGVjaWRpbmcgd2hldGhlciB0byBm bGlwCj4gb3IgZG8gYSBmdWxsIG1vZGUgc2V0Lgo+Cj4gdjI6Cj4gICAgLSBkb24ndCB1c2UgdW5p bml0aWFsaXplZCBvciBpbmNvcnJlY3QgcGlwZSBtYXNrcyBpbiBzZXRfY29uZmlnCj4gICAgICBm YWlsdXJlIHBhdGggKEFuZGVyKQo+IHYzOgo+ICAgIC0gZml4dXAgZm9yIHBpcGVfY29uZmlnIGNo YW5nZXMgaW4gY29tcHV0ZV9jb25maWcgKEplc3NlKQo+Cj4gU2lnbmVkLW9mZi1ieTogSmVzc2Ug QmFybmVzIDxqYmFybmVzQHZpcnR1b3VzZ2Vlay5vcmc+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAzNiArKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKystLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAzMyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9u cygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXku YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IGluZGV4IGEzZWJhYjgu LmNiOTZmMTEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh eS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTEx MTc4LDYgKzExMTc4LDggQEAgc3RhdGljIGludCBpbnRlbF9jcnRjX3NldF9jb25maWcoc3RydWN0 IGRybV9tb2RlX3NldCAqc2V0KQo+ICAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXY7Cj4gICAJc3Ry dWN0IGRybV9tb2RlX3NldCBzYXZlX3NldDsKPiAgIAlzdHJ1Y3QgaW50ZWxfc2V0X2NvbmZpZyAq Y29uZmlnOwo+ICsJc3RydWN0IGludGVsX2NydGNfY29uZmlnICpwaXBlX2NvbmZpZzsKPiArCXVu c2lnbmVkIG1vZGVzZXRfcGlwZXMsIHByZXBhcmVfcGlwZXMsIGRpc2FibGVfcGlwZXM7Cj4gICAJ aW50IHJldDsKPgo+ICAgCUJVR19PTighc2V0KTsKPiBAQCAtMTEyMjMsOSArMTEyMjUsMjMgQEAg c3RhdGljIGludCBpbnRlbF9jcnRjX3NldF9jb25maWcoc3RydWN0IGRybV9tb2RlX3NldCAqc2V0 KQo+ICAgCWlmIChyZXQpCj4gICAJCWdvdG8gZmFpbDsKPgo+ICsJcGlwZV9jb25maWcgPSBpbnRl bF9tb2Rlc2V0X2NvbXB1dGVfY29uZmlnKHNldC0+Y3J0Yywgc2V0LT5tb2RlLAo+ICsJCQkJCQkg ICBzZXQtPmZiLAo+ICsJCQkJCQkgICAmbW9kZXNldF9waXBlcywKPiArCQkJCQkJICAgJnByZXBh cmVfcGlwZXMsCj4gKwkJCQkJCSAgICZkaXNhYmxlX3BpcGVzKTsKPiArCWlmIChJU19FUlIocGlw ZV9jb25maWcpKQo+ICsJCWdvdG8gZmFpbDsKPiArCj4gKwkvKiBzZXRfbW9kZSB3aWxsIGZyZWUg aXQgaW4gdGhlIG1vZGVfY2hhbmdlZCBjYXNlICovCj4gKwlpZiAoIWNvbmZpZy0+bW9kZV9jaGFu Z2VkKQo+ICsJCWtmcmVlKHBpcGVfY29uZmlnKTsKPiArCj4gICAJaWYgKGNvbmZpZy0+bW9kZV9j aGFuZ2VkKSB7Cj4gLQkJcmV0ID0gaW50ZWxfc2V0X21vZGUoc2V0LT5jcnRjLCBzZXQtPm1vZGUs Cj4gLQkJCQkgICAgIHNldC0+eCwgc2V0LT55LCBzZXQtPmZiKTsKPiArCQlyZXQgPSBpbnRlbF9z ZXRfbW9kZV9waXBlcyhzZXQtPmNydGMsIHNldC0+bW9kZSwKPiArCQkJCQkgICBzZXQtPngsIHNl dC0+eSwgc2V0LT5mYiwgcGlwZV9jb25maWcsCj4gKwkJCQkJICAgbW9kZXNldF9waXBlcywgcHJl cGFyZV9waXBlcywKPiArCQkJCQkgICBkaXNhYmxlX3BpcGVzKTsKPiAgIAl9IGVsc2UgaWYgKGNv bmZpZy0+ZmJfY2hhbmdlZCkgewo+ICAgCQlzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YyA9 IHRvX2ludGVsX2NydGMoc2V0LT5jcnRjKTsKPgo+IEBAIC0xMzE5OCw2ICsxMzIxNCwyMCBAQCB2 b2lkIGludGVsX21vZGVzZXRfc2V0dXBfaHdfc3RhdGUoc3RydWN0IGRybV9kZXZpY2UgKmRldiwK PiAgIAkJZm9yX2VhY2hfcGlwZShkZXZfcHJpdiwgcGlwZSkgewo+ICAgCQkJc3RydWN0IGRybV9j cnRjICpjcnRjID0KPiAgIAkJCQlkZXZfcHJpdi0+cGlwZV90b19jcnRjX21hcHBpbmdbcGlwZV07 Cj4gKwkJCXN0cnVjdCBpbnRlbF9jcnRjX2NvbmZpZyAqcGlwZV9jb25maWc7Cj4gKwkJCXVuc2ln bmVkIG1vZGVzZXRfcGlwZXMsIHByZXBhcmVfcGlwZXMsIGRpc2FibGVfcGlwZXM7Cj4gKwo+ICsJ CQlwaXBlX2NvbmZpZyA9IGludGVsX21vZGVzZXRfY29tcHV0ZV9jb25maWcoY3J0YywKPiArCQkJ CQkJCQkgICAmY3J0Yy0+bW9kZSwKPiArCQkJCQkJCQkgICBjcnRjLT5wcmltYXJ5LT5mYiwKPiAr CQkJCQkJCQkgICAmbW9kZXNldF9waXBlcywKPiArCQkJCQkJCQkgICAmcHJlcGFyZV9waXBlcywK PiArCQkJCQkJCQkgICAmZGlzYWJsZV9waXBlcyk7Cj4gKwkJCWlmIChJU19FUlIocGlwZV9jb25m aWcpKSB7Cj4gKwkJCQlEUk1fREVCVUdfS01TKCJwcmVwYXJlIGZhaWxlZFxuIik7Cj4gKwkJCQlr ZnJlZShwaXBlX2NvbmZpZyk7Cj4gKwkJCQlnb3RvIG91dDsKPiArCQkJfQo+Cj4gICAJCQlpbnRl bF9zZXRfbW9kZShjcnRjLCAmY3J0Yy0+bW9kZSwgY3J0Yy0+eCwgY3J0Yy0+eSwKPiAgIAkJCQkg ICAgICAgY3J0Yy0+cHJpbWFyeS0+ZmIpOwoKRGlkIHlvdSBtZWFuIHRvIGNvbnZlcnQgdGhpcyB0 byBpbnRlbF9zZXRfbW9kZV9waXBlcygpPyBTaW5jZSB5b3UgCmNoYW5nZWQgaW50ZWxfc2V0X21v ZGUoKSB0byBkbyBleGFjdGx5IHRoZSBzYW1lIHRoaW5nIGFzIGFib3ZlLCB0aGUgCndob2xlIGh1 bmsgc2VlbXMgdW5uZWNlc3NhcnkgdW5sZXNzIHlvdSByZWFsbHkgY2FyZSBhYm91dCBsb2dnaW5n IHRoYXQgCml0IHdhcyB0aGUgcHJlcGFyZSBzdGVwIHRoYXQgZmFpbGVkLgoKQW5kZXIKCj4gQEAg LTEzMjA1LDcgKzEzMjM1LDcgQEAgdm9pZCBpbnRlbF9tb2Rlc2V0X3NldHVwX2h3X3N0YXRlKHN0 cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gICAJfSBlbHNlIHsKPiAgIAkJaW50ZWxfbW9kZXNldF91 cGRhdGVfc3RhZ2VkX291dHB1dF9zdGF0ZShkZXYpOwo+ICAgCX0KPiAtCj4gK291dDoKPiAgIAlp bnRlbF9tb2Rlc2V0X2NoZWNrX3N0YXRlKGRldik7Cj4gICB9Cj4KPgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK