From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH] Revert "drm/i915/vlv: Remove check for Old Ack during forcewake" Date: Fri, 07 Nov 2014 14:58:37 +0000 Message-ID: <545CDE1D.9060506@intel.com> References: <20141105124202.GK26941@phenom.ffwll.local> <1415201452-28754-1-git-send-email-mika.kuoppala@intel.com> <20141106140915.GC26941@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id AA5DA6E8FA for ; Fri, 7 Nov 2014 06:58:40 -0800 (PST) In-Reply-To: <20141106140915.GC26941@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ben Widawsky , Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMDYvMTEvMTQgMTQ6MDksIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gT24gV2VkLCBOb3YgMDUs IDIwMTQgYXQgMDU6MzA6NTJQTSArMDIwMCwgTWlrYSBLdW9wcGFsYSB3cm90ZToKPj4gVGhpcyBy ZXZlcnRzIGNvbW1pdCA1Y2IxM2MwN2RhZTczMzgwZDhiM2RkYzc5Mjc0MDQ4N2I4NzQyOTM4Lgo+ Pgo+PiBXaGlsZSB0aGUgcmVsZXZhbmNlIGZvciBXYVJzRG9udFBvbGxGb3JBY2tPbkNsZWFyaW5n RldCaXRzIGlzIHVuZGVyCj4+IGludmVzdGlnYXRpb24sIHJldmVydCB0aGlzIGFzIHJlZ3Jlc3Np b24uCj4+Cj4+IEJ1Z3ppbGxhOiBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVn LmNnaT9pZD04NTY4NAo+PiBUZXN0ZWQtYnk6ICAgVGVzdGVkLWJ5OiBsdSBodWEgPGh1YXgubHVA aW50ZWwuY29tPgo+PiBDYzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+ Cj4+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ PiBDYzogUywgRGVlcGFrIDxkZWVwYWsuc0BpbnRlbC5jb20+Cj4+IFNpZ25lZC1vZmYtYnk6IE1p a2EgS3VvcHBhbGEgPG1pa2Eua3VvcHBhbGFAaW50ZWwuY29tPgo+IAo+IFF1ZXVlZCBmb3IgLW5l eHQsIHRoYW5rcyBmb3IgdGhlIHBhdGNoLgo+IC1EYW5pZWwKPiAKCkhpLAoKd2hpbGUgbG9va2lu ZyBhdCB0aGUgKHNlbWktZ2VuZXJpYykgZm9yY2Ugd2FrZSBjb2RlIGluIHRoZSBmdW5jdGlvbgpn ZW42X2d0X2ZvcmNlX3dha2VfZ2V0KCksIEkgbm90aWNlZCB0aGF0IGlmIHRoZSBwbGF0Zm9ybSBk b2Vzbid0IHByb3ZpZGUKYSBsb3ctbGV2ZWwgZm9yY2V3YWtlIHJlZ2lzdGVyLWFjY2VzcyBmdW5j dGlvbiwgdGhlbiB3ZSBvbWl0IHRoZSBQTQpnZXQvcHV0IGNhbGxzIGFzIHdlbGwuCgo+IHZvaWQg Z2VuNl9ndF9mb3JjZV93YWtlX2dldChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYs IGludCBmd19lbmdpbmUpCj4gewo+ICAgICAgICAgdW5zaWduZWQgbG9uZyBpcnFmbGFnczsKPiAK PiAgICAgICAgIGlmICghZGV2X3ByaXYtPnVuY29yZS5mdW5jcy5mb3JjZV93YWtlX2dldCkKPiAg ICAgICAgICAgICAgICAgcmV0dXJuOwo+IAo+ICAgICAgICAgaW50ZWxfcnVudGltZV9wbV9nZXQo ZGV2X3ByaXYpOwo+IAo+ICAgICAgICAgLyogUmVkaXJlY3QgdG8gR2VuOSBzcGVjaWZpYyByb3V0 aW5lICovCj4gICAgICAgICBpZiAoSVNfR0VOOShkZXZfcHJpdi0+ZGV2KSkKPiAgICAgICAgICAg ICAgICAgcmV0dXJuIGdlbjlfZm9yY2Vfd2FrZV9nZXQoZGV2X3ByaXYsIGZ3X2VuZ2luZSk7Cj4g Cj4gICAgICAgICAvKiBSZWRpcmVjdCB0byBWTFYgc3BlY2lmaWMgcm91dGluZSAqLwo+ICAgICAg ICAgaWYgKElTX1ZBTExFWVZJRVcoZGV2X3ByaXYtPmRldikpCj4gICAgICAgICAgICAgICAgIHJl dHVybiB2bHZfZm9yY2Vfd2FrZV9nZXQoZGV2X3ByaXYsIGZ3X2VuZ2luZSk7Cj4gCj4gICAgICAg ICBzcGluX2xvY2tfaXJxc2F2ZSgmZGV2X3ByaXYtPnVuY29yZS5sb2NrLCBpcnFmbGFncyk7Cj4g ICAgICAgICBpZiAoZGV2X3ByaXYtPnVuY29yZS5mb3JjZXdha2VfY291bnQrKyA9PSAwKQo+ICAg ICAgICAgICAgICAgICBkZXZfcHJpdi0+dW5jb3JlLmZ1bmNzLmZvcmNlX3dha2VfZ2V0KGRldl9w cml2LCBGT1JDRVdBS0VfQUxMKTsKPiAgICAgICAgIHNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmRl dl9wcml2LT51bmNvcmUubG9jaywgaXJxZmxhZ3MpOwo+IH0KCkRvZXMgYW55b25lIGtub3cgd2hl dGhlciB0aGlzIGlzIGludGVudGlvbmFsLCBvciBqdXN0IGFuIGFjY2lkZW50IG9mIHRoZQpjdXJy ZW50IGltcGxlbWVudGF0aW9uPyBQcmVzdW1hYmx5IHdlIGRvbid0IGhhdmUgYW55IHBsYXRmb3Jt cyB3aGVyZQp0aGlzIGFwcGxpZXMsIGJ1dCB3ZSBpcyBpdCBwbGF1c2libGUgdGhhdCBzb21lIGZ1 dHVyZSBkZXZpY2UgbWlnaHQgd2FudAp0aGUgcnVudGltZSBQTSBlZmZlY3RzIHdpdGhvdXQgYWN0 dWFsbHkgaGF2aW5nIGgvdyBzdXBwb3J0CmZvciBmb3JjZXdha2U/CgpBbHRlcm5hdGl2ZWx5LCB3 aHkgZG8gd2UgbmVlZCB0aGUgcnVudGltZSBQTSBjYWxscyBpbiBoZXJlPyBJIGNhbiBzZWUKUGFv bG8ncyBjb21taXQgImM4YzhmYjMgZHJtL2k5MTU6IGFkZCBzb21lIHJ1bnRpbWUgUE0gZ2V0L3B1 dCBjYWxscyIKYWRkZWQgbG90cyBvZiBnZXQvcHV0IHBhaXJzIHJvdW5kIHZhcmlvdXMgc2VxdWVu Y2VzIG9mIG9wZXJhdGlvbnMgaW4KZGVidWdmcyBldGMsIHNvIHdoeSBkbyB3ZSBhbHNvIG5lZWQg dGhlbSBhdCB0aGlzIGlubmVyIGxldmVsPyBJcyBpdCBqdXN0CnRvIGNhdGNoIGFueSBjYXNlcyB3 aGVyZSB0aGUgY2FsbGVyIHNob3VsZCBoYXZlIChidXQgZGlkbid0KSBkZWFsIHdpdGgKcnVudGlt ZSBQTSBhbHJlYWR5PwoKVGhhbmtzLApEYXZlCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg==