From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ander Conselvan de Oliveira <conselvan2@gmail.com>
Subject: Re: [PATCH 1/6] drm/i915: factor out compute_config
 from __intel_set_mode v3
Date: Mon, 10 Nov 2014 18:08:42 +0200
Message-ID: <5460E30A.20906@gmail.com>
References: <1415226371-1880-1-git-send-email-jbarnes@virtuousgeek.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by gabe.freedesktop.org (Postfix) with ESMTP id 37BB66F9F3
 for <intel-gfx@lists.freedesktop.org>; Mon, 10 Nov 2014 08:10:11 -0800 (PST)
In-Reply-To: <1415226371-1880-1-git-send-email-jbarnes@virtuousgeek.org>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Jesse Barnes <jbarnes@virtuousgeek.org>, intel-gfx@lists.freedesktop.org
Cc: shuang.he@linux.intel.com
List-Id: intel-gfx@lists.freedesktop.org

UmV2aWV3ZWQtYnk6IEFuZGVyIENvbnNlbHZhbiBkZSBPbGl2ZWlyYSA8YW5kZXIuY29uc2VsdmFu
LmRlLm9saXZlaXJhQGludGVsLmNvbT4KCk9uIDExLzA2LzIwMTQgMTI6MjYgQU0sIEplc3NlIEJh
cm5lcyB3cm90ZToKPiBUaGlzIGFsbG93cyB1cyB0byBjYWxjdWxhdGUgdGhlIGZ1bGwgcGlwZSBj
b25maWcgYmVmb3JlIHdlIGRvIGFueSBtb2RlCj4gc2V0dGluZyB3b3JrLgo+IAo+IHYyOgo+ICAg
IC0gY2xhcmlmeSBjb21tZW50cyBhYm91dCBnbG9iYWwgdnMuIHBlci1jcnRjIG1vZGUgc2V0IChB
bmRlcikKPiAgICAtIGNsZWFuIHVwIHVubmVjZXNzYXJ5IHBpcGVfY29uZmlnID0gTlVMTCBzZXR0
aW5nIChBbmRlcikKPiB2MzoKPiAgICAtIGZpeCBwaXBlX2NvbmZpZyBoYW5kbGluZyAoYWxsb2Mg
aW4gY29tcHV0ZV9jb25maWcsIGZyZWUgaW4gc2V0X21vZGUpIChKZXNzZSkKPiAgICAtIGZpeCBh
cmcgb3JkZXIgaW4gc2V0X21vZGUgKEplc3NlKQo+ICAgIC0gZml4IGZhaWx1cmUgcGF0aCBvZiBz
ZXRfY29uZmlnIChBbmRlcikKPiAKPiBTaWduZWQtb2ZmLWJ5OiBKZXNzZSBCYXJuZXMgPGpiYXJu
ZXNAdmlydHVvdXNnZWVrLm9yZz4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs
X2Rpc3BsYXkuYyB8IDEwNSArKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLQo+ICAg
MSBmaWxlIGNoYW5nZWQsIDc0IGluc2VydGlvbnMoKyksIDMxIGRlbGV0aW9ucygtKQo+IAo+IGRp
ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJz
L2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBpbmRleCBhOWRmODVmLi5hM2ViYWI4IDEw
MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBi
L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC0xMDY1Niw0NSArMTA2
NTYsNjAgQEAgc3RhdGljIHZvaWQgdXBkYXRlX3NjYW5saW5lX29mZnNldChzdHJ1Y3QgaW50ZWxf
Y3J0YyAqY3J0YykKPiAgIAkJY3J0Yy0+c2NhbmxpbmVfb2Zmc2V0ID0gMTsKPiAgIH0KPiAgIAo+
ICtzdGF0aWMgc3RydWN0IGludGVsX2NydGNfY29uZmlnICoKPiAraW50ZWxfbW9kZXNldF9jb21w
dXRlX2NvbmZpZyhzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gKwkJCSAgICAgc3RydWN0IGRybV9k
aXNwbGF5X21vZGUgKm1vZGUsCj4gKwkJCSAgICAgc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIs
Cj4gKwkJCSAgICAgdW5zaWduZWQgKm1vZGVzZXRfcGlwZXMsCj4gKwkJCSAgICAgdW5zaWduZWQg
KnByZXBhcmVfcGlwZXMsCj4gKwkJCSAgICAgdW5zaWduZWQgKmRpc2FibGVfcGlwZXMpCj4gK3sK
PiArCXN0cnVjdCBpbnRlbF9jcnRjX2NvbmZpZyAqcGlwZV9jb25maWcgPSBOVUxMOwo+ICsKPiAr
CWludGVsX21vZGVzZXRfYWZmZWN0ZWRfcGlwZXMoY3J0YywgbW9kZXNldF9waXBlcywKPiArCQkJ
CSAgICAgcHJlcGFyZV9waXBlcywgZGlzYWJsZV9waXBlcyk7Cj4gKwo+ICsJaWYgKCgqbW9kZXNl
dF9waXBlcykgPT0gMCkKPiArCQlnb3RvIG91dDsKPiArCj4gKwkvKgo+ICsJICogTm90ZSB0aGlz
IG5lZWRzIGNoYW5nZXMgd2hlbiB3ZSBzdGFydCB0cmFja2luZyBtdWx0aXBsZSBtb2Rlcwo+ICsJ
ICogYW5kIGNydGNzLiAgQXQgdGhhdCBwb2ludCB3ZSdsbCBuZWVkIHRvIGNvbXB1dGUgdGhlIHdo
b2xlIGNvbmZpZwo+ICsJICogKGkuZS4gb25lIHBpcGVfY29uZmlnIGZvciBlYWNoIGNydGMpIHJh
dGhlciB0aGFuIGp1c3QgdGhlIG9uZQo+ICsJICogZm9yIHRoaXMgY3J0Yy4KPiArCSAqLwo+ICsJ
cGlwZV9jb25maWcgPSBpbnRlbF9tb2Rlc2V0X3BpcGVfY29uZmlnKGNydGMsIGZiLCBtb2RlKTsK
PiArCWlmIChJU19FUlIocGlwZV9jb25maWcpKSB7Cj4gKwkJZ290byBvdXQ7Cj4gKwl9Cj4gKwlp
bnRlbF9kdW1wX3BpcGVfY29uZmlnKHRvX2ludGVsX2NydGMoY3J0YyksIHBpcGVfY29uZmlnLAo+
ICsJCQkgICAgICAgIlttb2Rlc2V0XSIpOwo+ICsJdG9faW50ZWxfY3J0YyhjcnRjKS0+bmV3X2Nv
bmZpZyA9IHBpcGVfY29uZmlnOwo+ICsKPiArb3V0Ogo+ICsJcmV0dXJuIHBpcGVfY29uZmlnOwo+
ICt9Cj4gKwo+ICAgc3RhdGljIGludCBfX2ludGVsX3NldF9tb2RlKHN0cnVjdCBkcm1fY3J0YyAq
Y3J0YywKPiAgIAkJCSAgICBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZSwKPiAtCQkJICAg
IGludCB4LCBpbnQgeSwgc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIpCj4gKwkJCSAgICBpbnQg
eCwgaW50IHksIHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiLAo+ICsJCQkgICAgc3RydWN0IGlu
dGVsX2NydGNfY29uZmlnICpwaXBlX2NvbmZpZywKPiArCQkJICAgIHVuc2lnbmVkIG1vZGVzZXRf
cGlwZXMsCj4gKwkJCSAgICB1bnNpZ25lZCBwcmVwYXJlX3BpcGVzLAo+ICsJCQkgICAgdW5zaWdu
ZWQgZGlzYWJsZV9waXBlcykKPiAgIHsKPiAgIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gY3J0
Yy0+ZGV2Owo+ICAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2
X3ByaXZhdGU7Cj4gICAJc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKnNhdmVkX21vZGU7Cj4gLQlz
dHJ1Y3QgaW50ZWxfY3J0Y19jb25maWcgKnBpcGVfY29uZmlnID0gTlVMTDsKPiAgIAlzdHJ1Y3Qg
aW50ZWxfY3J0YyAqaW50ZWxfY3J0YzsKPiAtCXVuc2lnbmVkIGRpc2FibGVfcGlwZXMsIHByZXBh
cmVfcGlwZXMsIG1vZGVzZXRfcGlwZXM7Cj4gICAJaW50IHJldCA9IDA7Cj4gICAKPiAgIAlzYXZl
ZF9tb2RlID0ga21hbGxvYyhzaXplb2YoKnNhdmVkX21vZGUpLCBHRlBfS0VSTkVMKTsKPiAgIAlp
ZiAoIXNhdmVkX21vZGUpCj4gICAJCXJldHVybiAtRU5PTUVNOwo+ICAgCj4gLQlpbnRlbF9tb2Rl
c2V0X2FmZmVjdGVkX3BpcGVzKGNydGMsICZtb2Rlc2V0X3BpcGVzLAo+IC0JCQkJICAgICAmcHJl
cGFyZV9waXBlcywgJmRpc2FibGVfcGlwZXMpOwo+IC0KPiAgIAkqc2F2ZWRfbW9kZSA9IGNydGMt
Pm1vZGU7Cj4gICAKPiAtCS8qIEhhY2s6IEJlY2F1c2Ugd2UgZG9uJ3QgKHlldCkgc3VwcG9ydCBn
bG9iYWwgbW9kZXNldCBvbiBtdWx0aXBsZQo+IC0JICogY3J0Y3MsIHdlIGRvbid0IGtlZXAgdHJh
Y2sgb2YgdGhlIG5ldyBtb2RlIGZvciBtb3JlIHRoYW4gb25lIGNydGMuCj4gLQkgKiBIZW5jZSBz
aW1wbHkgY2hlY2sgd2hldGhlciBhbnkgYml0IGlzIHNldCBpbiBtb2Rlc2V0X3BpcGVzIGluIGFs
bCB0aGUKPiAtCSAqIHBpZWNlcyBvZiBjb2RlIHRoYXQgYXJlIG5vdCB5ZXQgY29udmVydGVkIHRv
IGRlYWwgd2l0aCBtdXRsaXBsZSBjcnRjcwo+IC0JICogY2hhbmdpbmcgdGhlaXIgbW9kZSBhdCB0
aGUgc2FtZSB0aW1lLiAqLwo+IC0JaWYgKG1vZGVzZXRfcGlwZXMpIHsKPiAtCQlwaXBlX2NvbmZp
ZyA9IGludGVsX21vZGVzZXRfcGlwZV9jb25maWcoY3J0YywgZmIsIG1vZGUpOwo+IC0JCWlmIChJ
U19FUlIocGlwZV9jb25maWcpKSB7Cj4gLQkJCXJldCA9IFBUUl9FUlIocGlwZV9jb25maWcpOwo+
IC0JCQlwaXBlX2NvbmZpZyA9IE5VTEw7Cj4gLQo+IC0JCQlnb3RvIG91dDsKPiAtCQl9Cj4gLQkJ
aW50ZWxfZHVtcF9waXBlX2NvbmZpZyh0b19pbnRlbF9jcnRjKGNydGMpLCBwaXBlX2NvbmZpZywK
PiAtCQkJCSAgICAgICAiW21vZGVzZXRdIik7Cj4gLQkJdG9faW50ZWxfY3J0YyhjcnRjKS0+bmV3
X2NvbmZpZyA9IHBpcGVfY29uZmlnOwo+IC0JfQo+IC0KPiAgIAkvKgo+ICAgCSAqIFNlZSBpZiB0
aGUgY29uZmlnIHJlcXVpcmVzIGFueSBhZGRpdGlvbmFsIHByZXBhcmF0aW9uLCBlLmcuCj4gICAJ
ICogdG8gYWRqdXN0IGdsb2JhbCBzdGF0ZSB3aXRoIHBpcGVzIG9mZi4gIFdlIG5lZWQgdG8gZG8g
dGhpcwo+IEBAIC0xMDcxOSw2ICsxMDczNCwxMCBAQCBzdGF0aWMgaW50IF9faW50ZWxfc2V0X21v
ZGUoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAgCj4gICAJLyogY3J0Yy0+bW9kZSBpcyBhbHJl
YWR5IHVzZWQgYnkgdGhlIC0+bW9kZV9zZXQgY2FsbGJhY2tzLCBoZW5jZSB3ZSBuZWVkCj4gICAJ
ICogdG8gc2V0IGl0IGhlcmUgYWxyZWFkeSBkZXNwaXRlIHRoYXQgd2UgcGFzcyBpdCBkb3duIHRo
ZSBjYWxsY2hhaW4uCj4gKwkgKgo+ICsJICogTm90ZSB3ZSdsbCBuZWVkIHRvIGZpeCB0aGlzIHVw
IHdoZW4gd2Ugc3RhcnQgdHJhY2tpbmcgbXVsdGlwbGUKPiArCSAqIHBpcGVzOyBoZXJlIHdlIGFz
c3VtZSBhIHNpbmdsZSBtb2Rlc2V0X3BpcGUgYW5kIG9ubHkgdHJhY2sgdGhlCj4gKwkgKiBzaW5n
bGUgY3J0YyBhbmQgbW9kZS4KPiAgIAkgKi8KPiAgIAlpZiAobW9kZXNldF9waXBlcykgewo+ICAg
CQljcnRjLT5tb2RlID0gKm1vZGU7Cj4gQEAgLTEwNzg3LDE5ICsxMDgwNiwyMyBAQCBkb25lOgo+
ICAgCWlmIChyZXQgJiYgY3J0Yy0+ZW5hYmxlZCkKPiAgIAkJY3J0Yy0+bW9kZSA9ICpzYXZlZF9t
b2RlOwo+ICAgCj4gLW91dDoKPiAgIAlrZnJlZShwaXBlX2NvbmZpZyk7Cj4gICAJa2ZyZWUoc2F2
ZWRfbW9kZSk7Cj4gICAJcmV0dXJuIHJldDsKPiAgIH0KPiAgIAo+IC1zdGF0aWMgaW50IGludGVs
X3NldF9tb2RlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAtCQkJICBzdHJ1Y3QgZHJtX2Rpc3Bs
YXlfbW9kZSAqbW9kZSwKPiAtCQkJICBpbnQgeCwgaW50IHksIHN0cnVjdCBkcm1fZnJhbWVidWZm
ZXIgKmZiKQo+ICtzdGF0aWMgaW50IGludGVsX3NldF9tb2RlX3BpcGVzKHN0cnVjdCBkcm1fY3J0
YyAqY3J0YywKPiArCQkJCXN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICptb2RlLAo+ICsJCQkJaW50
IHgsIGludCB5LCBzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiwKPiArCQkJCXN0cnVjdCBpbnRl
bF9jcnRjX2NvbmZpZyAqcGlwZV9jb25maWcsCj4gKwkJCQl1bnNpZ25lZCBtb2Rlc2V0X3BpcGVz
LAo+ICsJCQkJdW5zaWduZWQgcHJlcGFyZV9waXBlcywKPiArCQkJCXVuc2lnbmVkIGRpc2FibGVf
cGlwZXMpCj4gICB7Cj4gICAJaW50IHJldDsKPiAgIAo+IC0JcmV0ID0gX19pbnRlbF9zZXRfbW9k
ZShjcnRjLCBtb2RlLCB4LCB5LCBmYik7Cj4gKwlyZXQgPSBfX2ludGVsX3NldF9tb2RlKGNydGMs
IG1vZGUsIHgsIHksIGZiLCBwaXBlX2NvbmZpZywgbW9kZXNldF9waXBlcywKPiArCQkJICAgICAg
IHByZXBhcmVfcGlwZXMsIGRpc2FibGVfcGlwZXMpOwo+ICAgCj4gICAJaWYgKHJldCA9PSAwKQo+
ICAgCQlpbnRlbF9tb2Rlc2V0X2NoZWNrX3N0YXRlKGNydGMtPmRldik7Cj4gQEAgLTEwODA3LDYg
KzEwODMwLDI2IEBAIHN0YXRpYyBpbnQgaW50ZWxfc2V0X21vZGUoc3RydWN0IGRybV9jcnRjICpj
cnRjLAo+ICAgCXJldHVybiByZXQ7Cj4gICB9Cj4gICAKPiArc3RhdGljIGludCBpbnRlbF9zZXRf
bW9kZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gKwkJCSAgc3RydWN0IGRybV9kaXNwbGF5X21v
ZGUgKm1vZGUsCj4gKwkJCSAgaW50IHgsIGludCB5LCBzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpm
YikKPiArewo+ICsJc3RydWN0IGludGVsX2NydGNfY29uZmlnICpwaXBlX2NvbmZpZzsKPiArCXVu
c2lnbmVkIG1vZGVzZXRfcGlwZXMsIHByZXBhcmVfcGlwZXMsIGRpc2FibGVfcGlwZXM7Cj4gKwo+
ICsJcGlwZV9jb25maWcgPSBpbnRlbF9tb2Rlc2V0X2NvbXB1dGVfY29uZmlnKGNydGMsIG1vZGUs
IGZiLAo+ICsJCQkJCQkgICAmbW9kZXNldF9waXBlcywKPiArCQkJCQkJICAgJnByZXBhcmVfcGlw
ZXMsCj4gKwkJCQkJCSAgICZkaXNhYmxlX3BpcGVzKTsKPiArCj4gKwlpZiAoSVNfRVJSKHBpcGVf
Y29uZmlnKSkKPiArCQlyZXR1cm4gUFRSX0VSUihwaXBlX2NvbmZpZyk7Cj4gKwo+ICsJcmV0dXJu
IGludGVsX3NldF9tb2RlX3BpcGVzKGNydGMsIG1vZGUsIHgsIHksIGZiLCBwaXBlX2NvbmZpZywK
PiArCQkJCSAgICBtb2Rlc2V0X3BpcGVzLCBwcmVwYXJlX3BpcGVzLAo+ICsJCQkJICAgIGRpc2Fi
bGVfcGlwZXMpOwo+ICt9Cj4gKwo+ICAgdm9pZCBpbnRlbF9jcnRjX3Jlc3RvcmVfbW9kZShzdHJ1
Y3QgZHJtX2NydGMgKmNydGMpCj4gICB7Cj4gICAJaW50ZWxfc2V0X21vZGUoY3J0YywgJmNydGMt
Pm1vZGUsIGNydGMtPngsIGNydGMtPnksIGNydGMtPnByaW1hcnktPmZiKTsKPiBAQCAtMTMxNTYs
OCArMTMxOTksOCBAQCB2b2lkIGludGVsX21vZGVzZXRfc2V0dXBfaHdfc3RhdGUoc3RydWN0IGRy
bV9kZXZpY2UgKmRldiwKPiAgIAkJCXN0cnVjdCBkcm1fY3J0YyAqY3J0YyA9Cj4gICAJCQkJZGV2
X3ByaXYtPnBpcGVfdG9fY3J0Y19tYXBwaW5nW3BpcGVdOwo+ICAgCj4gLQkJCV9faW50ZWxfc2V0
X21vZGUoY3J0YywgJmNydGMtPm1vZGUsIGNydGMtPngsIGNydGMtPnksCj4gLQkJCQkJIGNydGMt
PnByaW1hcnktPmZiKTsKPiArCQkJaW50ZWxfc2V0X21vZGUoY3J0YywgJmNydGMtPm1vZGUsIGNy
dGMtPngsIGNydGMtPnksCj4gKwkJCQkgICAgICAgY3J0Yy0+cHJpbWFyeS0+ZmIpOwo+ICAgCQl9
Cj4gICAJfSBlbHNlIHsKPiAgIAkJaW50ZWxfbW9kZXNldF91cGRhdGVfc3RhZ2VkX291dHB1dF9z
dGF0ZShkZXYpOwo+IAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au
b3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n
ZngK