public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Ander Conselvan de Oliveira <conselvan2@gmail.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>, intel-gfx@lists.freedesktop.org
Cc: shuang.he@linux.intel.com
Subject: Re: [PATCH 5/6] drm/i915: update pipe size at set_config time
Date: Mon, 10 Nov 2014 18:09:45 +0200	[thread overview]
Message-ID: <5460E349.4020500@gmail.com> (raw)
In-Reply-To: <1415226371-1880-5-git-send-email-jbarnes@virtuousgeek.org>

Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>

On 11/06/2014 12:26 AM, Jesse Barnes wrote:
> This only affects the fastboot path as-is.  In that case, we simply need
> to make sure that we update the pipe size at the first mode set.  Rather
> than putting it off until we decide to flip (if indeed we do end up
> flipping), update the pipe size as appropriate a bit earlier in the
> set_config call.
> 
> This sets us up for better pipe tracking in later patches.
> 
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> ---
>   drivers/gpu/drm/i915/intel_display.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index c86eee6..3f1515d 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -2906,8 +2906,6 @@ intel_pipe_set_base(struct drm_crtc *crtc, int x, int y,
>   		return ret;
>   	}
>   
> -	intel_update_pipe_size(intel_crtc);
> -
>   	dev_priv->display.update_primary_plane(crtc, fb, x, y);
>   
>   	if (intel_crtc->active)
> @@ -11247,6 +11245,8 @@ static int intel_crtc_set_config(struct drm_mode_set *set)
>   	if (!config->mode_changed)
>   		kfree(pipe_config);
>   
> +	intel_update_pipe_size(to_intel_crtc(set->crtc));
> +
>   	if (config->mode_changed) {
>   		ret = intel_set_mode_pipes(set->crtc, set->mode,
>   					   set->x, set->y, set->fb, pipe_config,
> 

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2014-11-10 16:10 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-05 22:26 [PATCH 1/6] drm/i915: factor out compute_config from __intel_set_mode v3 Jesse Barnes
2014-11-05 22:26 ` [PATCH 2/6] drm/i915: use compute_config in set_config v3 Jesse Barnes
2014-11-07  9:41   ` Ander Conselvan de Oliveira
2014-11-07 16:59     ` Jesse Barnes
2014-11-07 21:11     ` [PATCH] drm/i915: use compute_config in set_config v4 Jesse Barnes
2014-11-10 16:09       ` Ander Conselvan de Oliveira
2014-11-05 22:26 ` [PATCH 3/6] drm/i915/hdmi: fetch infoframe status in get_config v2 Jesse Barnes
2014-11-10 16:09   ` Ander Conselvan de Oliveira
2014-11-11 15:00   ` Daniel Vetter
2014-11-11 15:19     ` Ville Syrjälä
2014-11-11 15:23       ` Daniel Vetter
2014-11-11 15:59         ` Jesse Barnes
2014-11-05 22:26 ` [PATCH 4/6] drm/i915: check for audio and infoframe changes across mode sets v2 Jesse Barnes
2014-11-10 16:09   ` Ander Conselvan de Oliveira
2014-12-01 10:25   ` Jani Nikula
2014-12-01 16:04     ` Jesse Barnes
2014-12-01 16:09       ` Chris Wilson
2014-12-01 16:30         ` Daniel Vetter
2014-12-01 16:37           ` Chris Wilson
2014-12-01 17:23             ` Daniel Vetter
2014-12-01 17:35               ` Jani Nikula
2014-12-01 19:26                 ` Daniel Vetter
2014-12-01 16:16     ` Daniel Vetter
2014-12-01 17:22       ` Jesse Barnes
2014-11-05 22:26 ` [PATCH 5/6] drm/i915: update pipe size at set_config time Jesse Barnes
2014-11-10 16:09   ` Ander Conselvan de Oliveira [this message]
2014-11-11 15:08     ` Daniel Vetter
2014-11-05 22:26 ` [PATCH 6/6] drm/i915: calculate pfit changes in set_config v2 Jesse Barnes
2014-11-06  8:43   ` [PATCH 6/6] drm/i915: calculate pfit changes in shuang.he
2014-11-10 16:20   ` [PATCH 6/6] drm/i915: calculate pfit changes in set_config v2 Ander Conselvan de Oliveira
2014-11-10 16:32     ` Jesse Barnes
2014-11-06  9:04 ` [PATCH 1/6] drm/i915: factor out compute_config from __intel_set_mode v3 Chris Wilson
2014-11-06 14:34   ` Daniel Vetter
2014-11-10 16:08 ` Ander Conselvan de Oliveira
  -- strict thread matches above, loose matches on Subject: below --
2014-10-30 18:53 [PATCH 1/6] drm/i915: factor out compute_config from __intel_set_mode v2 Jesse Barnes
2014-10-30 18:54 ` [PATCH 5/6] drm/i915: update pipe size at set_config time Jesse Barnes
2014-10-23 18:50 [PATCH 1/6] drm/i915: factor out compute_config from __intel_set_mode Jesse Barnes
2014-10-23 18:50 ` [PATCH 5/6] drm/i915: update pipe size at set_config time Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5460E349.4020500@gmail.com \
    --to=conselvan2@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=shuang.he@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox