From: Deepak S <deepak.s@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Drop WaRsForcewakeWaitTC0:vlv
Date: Tue, 18 Nov 2014 14:10:35 +0530 [thread overview]
Message-ID: <546B0603.1020603@intel.com> (raw)
In-Reply-To: <1415909573-8402-2-git-send-email-ville.syrjala@linux.intel.com>
On Friday 14 November 2014 01:42 AM, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> GEN6_GT_THREAD_STATUS_REG doesn't seem to exist on VLV. Reads just give
> 0x0 no matter what the state of the render and media wells.
>
> There was also some hint in the Gunit HAS that thread status not being
> needed on VLV, and hence dropped when bringing stuff over from the IVB
> design. Not really a definite comment about the specific register itself
> though.
>
> Also the w/a itself is no longer listed for VLV in the database. It was
> there some time ago in the past, but I guess someone figured out the
> mistake and dropped it.
>
> So let's just drop it from the code as well.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_uncore.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> index f318c03..3aa5c65 100644
> --- a/drivers/gpu/drm/i915/intel_uncore.c
> +++ b/drivers/gpu/drm/i915/intel_uncore.c
> @@ -223,10 +223,6 @@ static void __vlv_force_wake_get(struct drm_i915_private *dev_priv,
> FORCEWAKE_ACK_TIMEOUT_MS))
> DRM_ERROR("Timed out: waiting for media to ack.\n");
> }
> -
> - /* WaRsForcewakeWaitTC0:vlv */
> - if (!IS_CHERRYVIEW(dev_priv->dev))
> - __gen6_gt_wait_for_thread_c0(dev_priv);
> }
>
> static void __vlv_force_wake_put(struct drm_i915_private *dev_priv,
I did not find WA in DB.
S0 :) - Reviewed-by: Deepak S<deepak.s@linux.intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-11-17 8:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 20:12 [PATCH 1/2] drm/i915: Drop the HSW special case from __gen6_gt_wait_for_thread_c0() ville.syrjala
2014-11-13 20:12 ` [PATCH 2/2] drm/i915: Drop WaRsForcewakeWaitTC0:vlv ville.syrjala
2014-11-14 6:48 ` shuang.he
2014-11-18 8:40 ` Deepak S [this message]
2014-11-17 18:11 ` Daniel Vetter
2014-11-18 8:51 ` [PATCH 1/2] drm/i915: Drop the HSW special case from __gen6_gt_wait_for_thread_c0() Deepak S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546B0603.1020603@intel.com \
--to=deepak.s@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox