From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH] drm/i915: Bug fixes to ring 'head' updating Date: Tue, 18 Nov 2014 19:53:24 +0000 Message-ID: <546BA3B4.5060501@intel.com> References: <1415021344-24875-1-git-send-email-david.s.gordon@intel.com> <546B5F1E.5000004@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 8ECE46E56F for ; Tue, 18 Nov 2014 11:53:26 -0800 (PST) In-Reply-To: <546B5F1E.5000004@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMTgvMTEvMTQgMTU6MDAsIERlZXBhayBTIHdyb3RlOgo+IAo+IE9uIE1vbmRheSAwMyBOb3Zl bWJlciAyMDE0IDA2OjU5IFBNLCBEYXZlIEdvcmRvbiB3cm90ZToKPj4gRml4ZXMgdG8gYm90aCB0 aGUgTFJDIGFuZCB0aGUgbGVnYWN5IHJpbmdidWZmZXIgY29kZSB0byBjb3JyZWN0bHkKPj4gY2Fs Y3VsYXRlIGFuZCB1cGRhdGUgdGhlIGF2YWlsYWJsZSBzcGFjZSBpbiBhIHJpbmcuCj4+Cj4+IFRo ZSBsb2dpY2FsIHJpbmcgY29kZSB3YXMgdXBkYXRpbmcgdGhlIHNvZnR3YXJlIHJpbmcgJ2hlYWQn IHZhbHVlCj4+IGJ5IHJlYWRpbmcgdGhlIGhhcmR3YXJlICdIRUFEJyByZWdpc3Rlci4gSW4gTFJD IG1vZGUsIHRoaXMgaXMgbm90Cj4+IHZhbGlkIGFzIHRoZSBoYXJkd2FyZSBpcyBub3QgbmVjZXNz YXJpbHkgZXhlY3V0aW5nIHRoZSBzYW1lIGNvbnRleHQKPj4gdGhhdCBpcyBiZWluZyBwcm9jZXNz ZWQgYnkgdGhlIHNvZnR3YXJlLiBUaHVzIHJlYWRpbmcgdGhlIGgvdyBIRUFECj4+IGNvdWxkIHB1 dCBhbiB1bnJlbGF0ZWQgKHVuZGVmaW5lZCwgZWZmZWN0aXZlbHkgcmFuZG9tKSB2YWx1ZSBpbnRv Cj4+IHRoZSBzL3cgJ2hlYWQnIC0tIEEgQmFkIFRoaW5nIGZvciB0aGUgZnJlZSBzcGFjZSBjYWxj dWxhdGlvbnMuCj4+Cj4+IEluIGFkZGl0aW9uLCB0aGUgb2xkIGNvZGUgY291bGQgdXBkYXRlIGEg cmluZ2J1ZmZlcidzICdoZWFkJyB2YWx1ZQo+PiBmcm9tIHRoZSAnbGFzdF9yZXRpcmVkX2hlYWQn IGV2ZW4gd2hlbiB0aGUgbGF0dGVyIGhhZG4ndCBiZWVuIHJlY2VudGx5Cj4+IHVwZGF0ZWQgYW5k IHRoZXJlZm9yZSBoYWQgYSB2YWx1ZSBvZiAtMTsgdGhpcyB3b3VsZCBhbHNvIGNvbmZ1c2UgdGhl Cj4+IGZyZWVzcGFjZSBjYWxjdWxhdGlvbnMuIE5vdywgd2UgY29uc3VtZSAnbGFzdF9yZXRpcmVk X2hlYWQnIGluIGp1c3QKPj4gb25lIHBsYWNlLCBlbnN1cmluZyB0aGF0IHRoaXMgY29uZnVzaW9u IGRvZXMgbm90IGFyaXNlLgo+Pgo+PiBDaGFuZ2UtSWQ6IElkN2NlOTA5NmVkMTAwYTI4ODJjNjhh NTQyMDZmMzBiNmM4N2U5MmZhCj4+IFNpZ25lZC1vZmYtYnk6IERhdmUgR29yZG9uIDxkYXZpZC5z LmdvcmRvbkBpbnRlbC5jb20+Cj4+IC0tLQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf ZG1hLmMgICAgICAgICB8ICAgIDUgKystCj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf bHJjLmMgICAgICAgIHwgICAzNiArKysrKysrKysrLS0tLS0tLS0tLS0KPj4gICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMgfCAgIDUzCj4+ICsrKysrKysrKysrKysrKyst LS0tLS0tLS0tLS0tLS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVy LmggfCAgICAxICsKPj4gICA0IGZpbGVzIGNoYW5nZWQsIDQ4IGluc2VydGlvbnMoKyksIDQ3IGRl bGV0aW9ucygtKQo+Pgpbc25pcF0KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX3JpbmdidWZmZXIuYwo+PiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Jpbmdi dWZmZXIuYwo+PiBpbmRleCBhOGY3MmU4Li4xMTUwODYyIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jCj4+IEBAIC01MiwxNiArNTIsMjcgQEAgaW50ZWxfcmlu Z19pbml0aWFsaXplZChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpyaW5nKQo+PiAgICAgaW50IF9f aW50ZWxfcmluZ19zcGFjZShpbnQgaGVhZCwgaW50IHRhaWwsIGludCBzaXplKQo+PiAgIHsKPj4g LSAgICBpbnQgc3BhY2UgPSBoZWFkIC0gKHRhaWwgKyBJOTE1X1JJTkdfRlJFRV9TUEFDRSk7Cj4+ IC0gICAgaWYgKHNwYWNlIDwgMCkKPj4gKyAgICBpbnQgc3BhY2UgPSBoZWFkIC0gdGFpbDsKPj4g KyAgICBpZiAoc3BhY2UgPD0gMCkKPj4gICAgICAgICAgIHNwYWNlICs9IHNpemU7Cj4+IC0gICAg cmV0dXJuIHNwYWNlOwo+PiArICAgIHJldHVybiBzcGFjZSAtIEk5MTVfUklOR19GUkVFX1NQQUNF Owo+PiArfQo+PiArCj4+ICt2b2lkIGludGVsX3JpbmdfdXBkYXRlX3NwYWNlKHN0cnVjdCBpbnRl bF9yaW5nYnVmZmVyICpyaW5nYnVmKQo+PiArewo+PiArICAgIGlmIChyaW5nYnVmLT5sYXN0X3Jl dGlyZWRfaGVhZCAhPSAtMSkgewo+PiArICAgICAgICByaW5nYnVmLT5oZWFkID0gcmluZ2J1Zi0+ bGFzdF9yZXRpcmVkX2hlYWQ7Cj4+ICsgICAgICAgIHJpbmdidWYtPmxhc3RfcmV0aXJlZF9oZWFk ID0gLTE7Cj4+ICsgICAgfQo+PiArCj4+ICsgICAgcmluZ2J1Zi0+c3BhY2UgPSBfX2ludGVsX3Jp bmdfc3BhY2UocmluZ2J1Zi0+aGVhZCAmIEhFQURfQUREUiwKPj4gKyAgICAgICAgICAgICAgICAg ICAgICAgIHJpbmdidWYtPnRhaWwsIHJpbmdidWYtPnNpemUpOwo+PiAgIH0KPj4gICAgIGludCBp bnRlbF9yaW5nX3NwYWNlKHN0cnVjdCBpbnRlbF9yaW5nYnVmZmVyICpyaW5nYnVmKQo+PiAgIHsK Pj4gLSAgICByZXR1cm4gX19pbnRlbF9yaW5nX3NwYWNlKHJpbmdidWYtPmhlYWQgJiBIRUFEX0FE RFIsCj4+IC0gICAgICAgICAgICAgICAgICByaW5nYnVmLT50YWlsLCByaW5nYnVmLT5zaXplKTsK Pj4gKyAgICBpbnRlbF9yaW5nX3VwZGF0ZV9zcGFjZShyaW5nYnVmKTsKPj4gKyAgICByZXR1cm4g cmluZ2J1Zi0+c3BhY2U7Cj4+ICAgfQo+PiAgICAgYm9vbCBpbnRlbF9yaW5nX3N0b3BwZWQoc3Ry dWN0IGludGVsX2VuZ2luZV9jcyAqcmluZykKPj4gQEAgLTczLDcgKzg0LDcgQEAgYm9vbCBpbnRl bF9yaW5nX3N0b3BwZWQoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqcmluZykKPj4gICB2b2lkIF9f aW50ZWxfcmluZ19hZHZhbmNlKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcpCj4+ICAgewo+ PiAgICAgICBzdHJ1Y3QgaW50ZWxfcmluZ2J1ZmZlciAqcmluZ2J1ZiA9IHJpbmctPmJ1ZmZlcjsK Pj4gLSAgICByaW5nYnVmLT50YWlsICY9IHJpbmdidWYtPnNpemUgLSAxOwo+PiArICAgIGludGVs X3JpbmdfYWR2YW5jZShyaW5nKTsKPiAKPiBTaG91bGQgdGhpcyBiZSBpbiBhbm90aGVyIHBhdGNo Pwo+IAo+IE90aGVyIHRoYW4gdGhpcyBvdGhlciBjaGFuZ2VzIGxvb2tzIGZpbmUgdG8gbWUuXAo+ IEFsc28sIGFyZSB5b3UgcGxhbm5pbmcgdG8gYWRkIFdBUk5fT04gaWYgdGhlcmUgaXMgYSBtaXNt YXRjaCB3aXRoCj4gcmluZ19iZWdpbiAmIGFkZF9yZXF1ZXN0PwoKWWVzLCB0aGF0J3MgYW5vdGhl ciBwYXRjaCB0aGF0IEknbGwgYmUgc2VuZGluZyBvdXQgc29vbjsgaXQgYWxzbyBjaGVja3MKZm9y IHZhcmlvdXMgb3RoZXIgbWlzdGFrZXMgaW4gcmluZyBtYW5hZ2VtZW50LgoKTWVhbndoaWxlIEkn dmUgZGVjaWRlZCB0byBtb3ZlIHRoZSBsaW5lIGFib3ZlIGludG8gdGhhdCBwYXRjaCByYXRoZXIK dGhhbiB0aGlzIG9uZTsgYWxzbywgSSd2ZSByZWZhY3RvcmVkIHRoaXMgcGF0Y2ggdG8gYnJlYWsg b3V0IHRoZSB0d28Kc2VjdGlvbnMgdGhhdCBmaXggc3BlY2lmaWMgYnVncyBpbiB0aGUgTFJDIGNv ZGUsIHNvIEkgc2hhbGwgc2VuZCBvdXQgYQpuZXcgdmVyc2lvbiBzaG9ydGx5LgoKLkRhdmUuCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==