[PATCH v2 00/28] Replace seqno values with request structures

John.C.Harrison
2014-11-14T12:19:22Z

There is a general feeling that it is better to move away from using a simple
integer 'seqno' value to track batch buffer completion. Instead, the request
structure should be used. That provides for much more flexibility going
forwards. Especially which things like a GPU scheduler (which can re-order batch
buffers and hence seqnos after submission to the hardware), Android sync points
and other such features which potentially make seqno usage more and more
complex.

This patch set does the work of converting most of the driver to use request
structures in preference to seqno values. The only place left that still uses
seqnos is the semaphore code. It was decided to leave that alone for the time
being as the semaphores are hardware based and the hardware only understands
seqno values.

v2: Rebased to newer nightly tree which significantly changed some of the
display MMIO flip code (including making __wait_request public and renaming
it).

[Patches against drm-intel-nightly tree fetched 13/11/2014]

John Harrison (28):
drm/i915: Ensure OLS & PLR are always in sync
drm/i915: Add reference count to request structure
drm/i915: Add helper functions to aid seqno -> request transition
drm/i915: Replace last_[rwf]_seqno with last_[rwf]_req
drm/i915: Convert i915_gem_ring_throttle to use requests
drm/i915: Ensure requests stick around during waits
drm/i915: Remove 'outstanding_lazy_seqno'
drm/i915: Make 'i915_gem_check_olr' actually check by request not seqno
drm/i915: Convert 'last_flip_req' to be a request not a seqno
drm/i915: Convert i915_wait_seqno to i915_wait_request
drm/i915: Add IRQ friendly request deference facility
drm/i915: Convert mmio_flip::seqno to struct request
drm/i915: Convert __wait_seqno() to __wait_request()
drm/i915: Remove obsolete seqno parameter from 'i915_add_request'
drm/i915: Convert 'flip_queued_seqno' into 'flip_queued_request'
drm/i915: Convert trace functions from seqno to request
drm/i915: Convert 'trace_irq' to use requests rather than seqnos
drm/i915: Convert 'ring_idle()' to use requests not seqnos
drm/i915: Connect requests to rings at creation not submission
drm/i915: Convert 'i915_seqno_passed' calls into 'i915_gem_request_completed'
drm/i915: Remove the now redundant 'obj->ring'
drm/i915: Cache request completion status
drm/i915: Zero fill the request structure
drm/i915: Spinlock protection for request list
drm/i915: Interrupt driven request completion
drm/i915: Remove obsolete parameter to i915_gem_request_completed()
drm/i915: Add unique id to the request structure for debugging
drm/i915: Additional request structure tracing

drivers/gpu/drm/i915/i915_debugfs.c | 20 +-
drivers/gpu/drm/i915/i915_drv.h | 97 ++++++--
drivers/gpu/drm/i915/i915_gem.c | 319 ++++++++++++++++----------
drivers/gpu/drm/i915/i915_gem_context.c | 3 +-
drivers/gpu/drm/i915/i915_gem_execbuffer.c | 10 +-
drivers/gpu/drm/i915/i915_gem_gtt.h | 4 +-
drivers/gpu/drm/i915/i915_gem_render_state.c | 2 +-
drivers/gpu/drm/i915/i915_gem_tiling.c | 2 +-
drivers/gpu/drm/i915/i915_gpu_error.c | 7 +-
drivers/gpu/drm/i915/i915_irq.c | 16 +-
drivers/gpu/drm/i915/i915_trace.h | 69 +++---
drivers/gpu/drm/i915/intel_display.c | 47 ++--
drivers/gpu/drm/i915/intel_drv.h | 5 +-
drivers/gpu/drm/i915/intel_lrc.c | 61 ++---
drivers/gpu/drm/i915/intel_overlay.c | 26 ++-
drivers/gpu/drm/i915/intel_ringbuffer.c | 82 ++++---
drivers/gpu/drm/i915/intel_ringbuffer.h | 25 +-
17 files changed, 502 insertions(+), 293 deletions(-)