From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Farnsworth Subject: Re: [PATCH] drm/i915: fix sdvo hotplug support check and activation Date: Wed, 29 Aug 2012 16:55:12 +0100 Message-ID: <5472959.9uvtq7SlKM@f17simon> References: <1346238522-18314-1-git-send-email-jani.nikula@intel.com> <1346247838-6331-1-git-send-email-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1857299633==" Return-path: Received: from claranet-outbound-smtp06.uk.clara.net (claranet-outbound-smtp06.uk.clara.net [195.8.89.39]) by gabe.freedesktop.org (Postfix) with ESMTP id 4C3379F4D4 for ; Wed, 29 Aug 2012 09:50:03 -0700 (PDT) In-Reply-To: <1346247838-6331-1-git-send-email-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Jani Nikula List-Id: intel-gfx@lists.freedesktop.org --===============1857299633== Content-Type: multipart/signed; boundary="nextPart1672355.A7zWXC3d7f"; micalg="pgp-sha1"; protocol="application/pgp-signature" Content-Transfer-Encoding: 7Bit --nextPart1672355.A7zWXC3d7f Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" (apologies to Daniel and Jani, who've seen this twice - I accidentally sent it from the wrong address originally). On Wednesday 29 August 2012 16:43:58 Jani Nikula wrote: > The sdvo hotplug support check and activation has worked by coincidence for > TMDS0. The boolean value returned by intel_sdvo_supports_hotplug() was > masked with a bit shifted by device number, which also should have been one > of SDVO_OUTPUT_* bits instead. Boolean true masked with 1 shifted by 0 just > happened to match SDVO_OUTPUT_TMDS0... > > Get hotplug support as a bit mask, check the correct bits for support, and > use the correct bits for activating hotplug support. > > Signed-off-by: Jani Nikula > Reviewed-by: Simon Farnsworth The code you're fixing was written with the aid of ajax's educated guesses - it's nice to see an Intel employee fix it to match the spec. -- Simon Farnsworth Software Engineer ONELAN Ltd http://www.onelan.com --nextPart1672355.A7zWXC3d7f Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (GNU/Linux) iQEcBAABAgAGBQJQPjtlAAoJEIKsye9/dtRWTWwH/3TO2Y4OQycr/HXznc1leadR 9iPg5gnD+NqWJV1RVNpTvKIBUM7+C1LW0dBSRHHP3GN5xQ/AJnEBxxhUEWRO2UVN o2bDx9LwdyF6GSqZ+rf+HbQIQa5THv8E7PnzpkrrzceYRMGKMoBQyMCVPFPEiPmC wTxAb4KjLKjO+sjQ6ITU3kyrWzn6ytXGrnCnHjYidwOkZDcpfZIFXeq7gAKxTuZQ deznesF88N8j1qxkL5Z7RTY1/PqRYdP4yEbYk9U61ORLmWMWDTcNlHYTdg4Qp+BH LILMcaeONLRqt3MKbh0wHKKGhVXGH9pPS4Ln/PORnGn6BalwSiFHQG0H6JrVgEo= =bya0 -----END PGP SIGNATURE----- --nextPart1672355.A7zWXC3d7f-- --===============1857299633== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1857299633==--