From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH v2 3/3] drm/i915: Consolidate ring freespace calculations Date: Mon, 24 Nov 2014 14:32:25 +0000 Message-ID: <54734179.1080509@intel.com> References: <1415021344-24875-1-git-send-email-david.s.gordon@intel.com> <1416341242-5352-1-git-send-email-david.s.gordon@intel.com> <1416341242-5352-4-git-send-email-david.s.gordon@intel.com> <20141124100434.GN25711@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 9B8266E50A for ; Mon, 24 Nov 2014 06:32:47 -0800 (PST) In-Reply-To: <20141124100434.GN25711@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMjQvMTEvMTQgMTA6MDQsIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gT24gVHVlLCBOb3YgMTgs IDIwMTQgYXQgMDg6MDc6MjJQTSArMDAwMCwgRGF2ZSBHb3Jkb24gd3JvdGU6Cj4+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMKPj4gaW5kZXggYWUwOTI1OC4uYTA4YWU2NSAx MDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jCj4+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYwo+PiBAQCAtNTIs MTYgKzUyLDI3IEBAIGludGVsX3JpbmdfaW5pdGlhbGl6ZWQoc3RydWN0IGludGVsX2VuZ2luZV9j cyAqcmluZykKPj4gIAo+PiAgaW50IF9faW50ZWxfcmluZ19zcGFjZShpbnQgaGVhZCwgaW50IHRh aWwsIGludCBzaXplKQo+PiAgewo+PiAtCWludCBzcGFjZSA9IGhlYWQgLSAodGFpbCArIEk5MTVf UklOR19GUkVFX1NQQUNFKTsKPj4gLQlpZiAoc3BhY2UgPCAwKQo+PiArCWludCBzcGFjZSA9IGhl YWQgLSB0YWlsOwo+PiArCWlmIChzcGFjZSA8PSAwKQo+PiAgCQlzcGFjZSArPSBzaXplOwo+PiAt CXJldHVybiBzcGFjZTsKPj4gKwlyZXR1cm4gc3BhY2UgLSBJOTE1X1JJTkdfRlJFRV9TUEFDRTsK PiAKPiBDaGFuZ2luZyB0aGUgZnJlZSBzcGFjZSBjb21wdXRhdGlvbiBkb2Vzbid0IHNlZW0gcmVx dWlyZWQsIGJ1dCByZXN1bHRpbmcKPiBpbiBDaHJpcyZtZSBqdXN0IGRpc2N1c3NpbmcgaXQgb24g aXJjIHRvIGNvbnZpbmNlIG91cnNlbHZlcyBpdCdzIG5vdAo+IGJyb2tlbiBhY2NpZGVudGFsbHkg bm93LiBDYW4geW91IHBsZWFzZSByZXNwaW4geW91IHBhdGNoIHdpdGggdGhpcyBjaGFuZ2UKPiBk cm9wcGVkPwo+IAo+IEluIGdlbmVyYWxseSBpdCdzIGdvb2QgcHJhY3RpY2UgdG8gcmV2aWV3IHRo ZSBkaWZmIGFmdGVyIGNvbW1pdHRpbmcgYQo+IHBhdGNoIGFuZCBodW50IGZvciBhbnkgdW5lY2Vz c2FyeSBjaGFuZ2VzLiBJbW8gZXZlbiB3aGVuIHRoZSBlbmRyZXN1bHQKPiBsb29rcyBhIGJpdCB1 bGd5IChlLmcuIGNyYXp5IG9yZGVyaW5nIG9mIHN0YXRpYyBmdW5jdGlvbnMgd2hpY2ggcmVxdWly ZXMKPiB0b25zIG9mIHByZWRlY2xhcmF0aW9ucykgaXQncyBiZXR0ZXIgaWYgdGhlIHJlc3VsdGlu ZyBkaWZmIGxvb2tzIGNsZWFuZXIuCj4gQW5kIGlmIHRoaW5ncyBnZXQgb3V0IG9mIGhhbmQgd2Ug Y2FuIGFsd2F5cyBkbyBhIHB1cmUgY2xlYW51cCBwYXRjaC4KPiAtRGFuaWVsCgpUaGlzIGlzbid0 IGFuIGFjY2lkZW50YWwgY2hhbmdlOyBpdCdzIHRvIGltcHJvdmUgcmVzaWxpZW5jZSBpbiB0aGUg Y2FzZQp0aGF0IGhlYWQgYW5kL29yIHRhaWwgZW5kIHVwIHdpdGggdmFsdWVzIHRoZXkgc2hvdWxk bid0IGhhdmUuCgpIZXJlJ3MgYSBDIHByb2dyYW0gdG8gbW9kZWwgdGhlIHR3byBkaWZmZXJlbnQg Y2FsY3VsYXRpb25zIGluIGEgdGlueSByaW5nOgoKI2luY2x1ZGUgPHN0ZGlvLmg+CgojZGVmaW5l IEZSRUUgICAgNAojZGVmaW5lIFNJWkUgICAgOAoKbWFpbigpCnsKICAgICAgICBpbnQgaCwgdCwg czEsIHMyOwoKICAgICAgICBwcmludGYoIiVzXHQlc1x0JXNcdCVzXG4iLCAiSGVhZCIsICJUYWls IiwgIk9TcGFjZSIsICJOU3BhY2UiKTsKICAgICAgICBmb3IgKGggPSAwOyBoIDw9IFNJWkU7ICsr aCkKICAgICAgICB7CiAgICAgICAgICAgICAgICBmb3IgKHQgPSAwOyB0IDw9IFNJWkU7ICsrdCkK ICAgICAgICAgICAgICAgIHsKICAgICAgICAgICAgICAgICAgICAgICAgczEgPSBoIC0gKHQgKyBG UkVFKTsKICAgICAgICAgICAgICAgICAgICAgICAgaWYgKHMxIDwgMCkKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBzMSArPSBTSVpFOwoKICAgICAgICAgICAgICAgICAgICAgICAgczIg PSBoIC0gdDsKICAgICAgICAgICAgICAgICAgICAgICAgaWYgKHMyIDw9IDApCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgczIgKz0gU0laRTsKICAgICAgICAgICAgICAgICAgICAgICAg czIgLT0gRlJFRTsKCiAgICAgICAgICAgICAgICAgICAgICAgIHByaW50ZigiJTJkXHQlMmRcdCUy ZFx0JTJkXG4iLCBoLCB0LCBzMSwgczIpOwogICAgICAgICAgICAgICAgfQogICAgICAgICAgICAg ICAgcHJpbnRmKCJcbiIpOwogICAgICAgIH0KfQoKT1NwYWNlIChzMSkgdXNlcyB0aGUgb2xkIGNv ZGUsIHdoZXJlYXMgTlNwYWNlIChzMikgaXMgbXkgbmV3IG1ldGhvZC4KVGhleSBhZ3JlZSBmb3Ig YWxsIHdlbGwtYmVoYXZlZCBjYXNlcywgYnV0IGxvb2sgYXQgdGhpcyBzbmlwcGV0OgoKSGVhZAlU YWlsCU9TcGFjZQlOU3BhY2UKIDYJIDAJIDIJIDIKIDYJIDEJIDEJIDEKIDYJIDIJIDAJIDAKIDYJ IDMJIDcJLTEKIDYJIDQJIDYJLTIKIDYJIDUJIDUJLTMKIDYJIDYJIDQJIDQKIDYJIDcJIDMJIDMK IDYJIDgJIDIJIDIKCkJvdGggdGhlIG9sZCBhbmQgbmV3IGNvZGUgZ2l2ZSB0aGUgcmlnaHQgYW5z d2VycyBpZiBIRUFEIGFuZCBUQUlMIGhhdmUKbGVnaXRpbWF0ZSB2YWx1ZXMuIEJ1dCBpZiBUQUlM IHNob3VsZCBzb21laG93IGFkdmFuY2UgZnVydGhlciB0aGFuIGl0CnNob3VsZCwgYW5kIHJ1biBp bnRvIHRoZSByZXNlcnZlZCBhcmVhLCB0aGUgb2xkIGNvZGUgbWlnaHQgdGVsbCB5b3UgdGhhdAp0 aGVyZSdzIG5vdyBMT1RTIG9mIHNwYWNlIGF2YWlsYWJsZSwgd2hlcmVhcyB0aGUgbmV3IGNvZGUg cmV0dXJucyAibGVzcwp0aGFuIHplcm8iIHNwYWNlIGF2YWlsYWJsZS4KCkZvciBleGFtcGxlLCB0 aGUgb2xkIGNhbGN1bGF0aW9uIHRlbGxzIHVzIHRoYXQgaWYgaGVhZD02IGFuZCB0YWlsPTQgdGhl bgp0aGVyZSBhcmUgNiBzbG90cyBhdmFpbGFibGUgLS0gd2hpY2gganVzdCBjYW4ndCBiZSByaWdo dCwgYXMgYnkKZGVmaW5pdGlvbiB0aGUgYW5zd2VyIHNob3VsZCBuZXZlciBiZSBtb3JlIHRoYW4g KFNJWkUtUlNWRCkuIEknZCBtdWNoCnJhdGhlciBnZXQgdGhlIGFuc3dlciAiLTIiIGZvciB0aGlz IGNhc2UsIGFzIGl0J3MgdGhlbiBvYnZpb3VzIHRoYXQgdGhpcwpyZWFsbHkgc2hvdWxkbid0IGhh cHBlbi4KCkluIHBhcnRpY3VsYXIsIHRoaXMgbmV3IGNvZGUgd291bGQgbWVhbiB0aGF0IHRoZSBj b21tb25seS11c2VkIHRlc3QKKGF2YWlsYWJsZSA+PSByZXF1aXJlZCkgd291bGQgaW1tZWRpYXRl bHkgcmVqZWN0IGZ1cnRoZXIgd3JpdGVzIGludG8gdGhlCnJpbmcgYWZ0ZXIgYW4gb3ZlcnJ1biwg Z2l2aW5nIHNvbWUgY2hhbmNlIHRoYXQgd2UgY2FuIHJlY292ZXIgZnJvbSBvciBhdApsZWFzdCBk aWFnbm9zZSB0aGUgb3JpZ2luYWwgcHJvYmxlbTsgd2hlcmVhcyBhbGxvd2luZyBtb3JlIHdyaXRl cyB3b3VsZApsaWtlbHkgYm90aCBjb25mdXNlIHRoZSBoL3cgYW5kIGRlc3Ryb3kgdGhlIGV2aWRl bmNlLgoKSXQncyBhbHNvIGVhc2llciB0byB1bmRlcnN0YW5kLCBJTUhPIChpZiBleHBlcmllbmNl ZCBwcm9ncmFtbWVycyBzdWNoIGFzCnlvdSAmIENocmlzIGhhZCB0byBkaXNjdXNzIHRoZSBvbGQg Y29kZSB0byBiZSBjb25maWRlbnQgdGhhdCBpdCB3YXMKY29ycmVjdCwgdGhhdCBhbHJlYWR5IHN1 Z2dlc3RzIHRoYXQgaXQncyBub3QgYXMgY2xlYXIgYXMgaXQgY291bGQgYmUpLgoKVGhlIHVzZWQg c3BhY2UgaW4gYSByaW5nIGlzIGdpdmVuIGJ5IHRoZSBjeWNsaWMgZGlzdGFuY2UgZnJvbSB0aGUK Y29uc3VtZXIgdG8gdGhlIHByb2R1Y2VyOyBjb252ZXJzZWx5LCB0aGUgYXZhaWxhYmxlIHNwYWNl IGluIGEgcmluZyBpcwp0aGUgY3ljbGljIGRpc3RhbmNlIGZyb20gdGhlIHByb2R1Y2VyIHRvIHRo ZSBjb25zdW1lciwgTUlOVVMgdGhlIGFtb3VudApyZXNlcnZlZC4gVGhlIG5ldyBjb2RlIGV4cHJl c3NlcyB0aGF0IGRpcmVjdGx5LCB3aXRob3V0IGhhdmluZyB0byBmaWd1cmUKb3V0IHRoZSBtZWFu aW5nIG9mIEFERElORyB0aGUgcmVzZXJ2ZWQgYW1vdW50IHRvIHRoZSB0YWlsIGJlZm9yZQpzdWJ0 cmFjdGluZyBpdCBmcm9tIGhlYWQuIEluIEFTQ0lJIHBpeDoKCiAgICAgICAgICAgICAgICAgICsr KysrKysrKysrKysrKysrKysKICAgICAgICAgICAgICAgICAgKyAgICAgIGZyZWUgICAgICAgKyAg MAogICAgICAgICAgICAgICAgICArICAgICAgZnJlZSAgICAgICArICAxCiAgICAgICAgICAgICAg ICAgICsgICAgcmVzZXJ2ZWQgICAgICsgIDIKICAgICAgICAgICAgICAgICAgKyAgICByZXNlcnZl ZCAgICAgKyAgMwooY29uc3VtZXIpIEhFQUQtPiArICAgICAgdXNlZCAgICAgICArICA0CiAgICAg ICAgICAgICAgICAgICsgICAgICB1c2VkICAgICAgICsgIDUKICAgICAgICAgICAgICAgICAgKyAg ICAgIHVzZWQgICAgICAgKyAgNgogICAgICAgICAgICAgICAgICArICAgICAgdXNlZCAgICAgICAr ICA3CiAgICAgICAgICAgICAgICAgICsgICAgICB1c2VkICAgICAgICsgIDgKICAgICAgICAgICAg ICAgICAgKyAgICAgIHVzZWQgICAgICAgKyAgOQoocHJvZHVjZXIpIFRBSUwtPiArICAgICAgZnJl ZSAgICAgICArIDEwCiAgICAgICAgICAgICAgICAgICsgICAgICBmcmVlICAgICAgICsgMTEKICAg ICAgICAgICAgICAgICAgKysrKysrKysrKysrKysrKysrKwoKVGhlIHNrZXRjaCBhYm92ZSBzaG93 cyB0aGUgc2l0dWF0aW9uIHdpdGggc2l6ZT0xMiwgcmVzZXJ2ZWQ9MiwgVEFJTD0xMAphbmQgSEVB RD00LiBTbG90cyA0IHRvIDkgYXJlIHVzZWQgKFRBSUwtSEVBRCA9IDEwLTQgPSA2IHNsb3RzKS4g VGhlCmF2YWlsYWJsZSBzcGFjZSBpcyAoSEVBRC1UQUlMICgrU0laRSkgLSBSU1ZEID0gNC0xMCsx Mi0yID0gNCBzbG90cykuCgogICAgICAgICAgICAgICAgICArKysrKysrKysrKysrKysrKysrCiAg ICAgICAgICAgICAgICAgICsgICAgICB1c2VkICAgICAgICsgIDAKICAgICAgICAgICAgICAgICAg KyAgICAgIHVzZWQgICAgICAgKyAgMQoocHJvZHVjZXIpIFRBSUwtPiArICAgICAgZnJlZSAgICAg ICArICAyCiAgICAgICAgICAgICAgICAgICsgICAgICBmcmVlICAgICAgICsgIDMKICAgICAgICAg ICAgICAgICAgKyAgICByZXNlcnZlZCAgICAgKyAgNAogICAgICAgICAgICAgICAgICArICAgIHJl c2VydmVkICAgICArICA1Cihjb25zdW1lcikgSEVBRC0+ICsgICAgICB1c2VkICAgICAgICsgIDYK ICAgICAgICAgICAgICAgICAgKyAgICAgIHVzZWQgICAgICAgKyAgNwogICAgICAgICAgICAgICAg ICArICAgICAgdXNlZCAgICAgICArICA4CiAgICAgICAgICAgICAgICAgICsgICAgICB1c2VkICAg ICAgICsgIDkKICAgICAgICAgICAgICAgICAgKyAgICAgIHVzZWQgICAgICAgKyAxMAogICAgICAg ICAgICAgICAgICArICAgICAgdXNlZCAgICAgICArIDExCiAgICAgICAgICAgICAgICAgICsrKysr KysrKysrKysrKysrKysKCkFmdGVyIFRBSUwgaGFzIHdyYXBwZWQsIHdlIG1pZ2h0IGhhdmUgdGhp cyBzaXR1YXRpb24gd2l0aCBUQUlMPTIgYW5kCkhFQUQ9Ni4gVXNlZCBzcGFjZSBpcyAoVEFJTC1I RUFEICgrU0laRSkgPSAyLTYrMTIgPSA4IHNsb3RzKSwgYW5kCmF2YWlsYWJsZSBzcGFjZSBpcyAo SEVBRC1UQUlMIC0gUlNWRCkgPSA2LTItMiA9IDIgc2xvdHMuIFN0cmFpZ2h0Zm9yd2FyZAphbmQg ZWFzeSB0byB1bmRlcnN0YW5kIDopCgpTbywgSSdkIGRlZmluaXRlbHkgcHJlZmVyIHRvIGtlZXAg dGhpcyBuZXcgY29kZS4gV2Ugbm90IG9ubHkgd2FudCB0byBkbwp0aGUgY2FsY3VsYXRpb24gaW4g b25seSBvbmUgcGxhY2UsIGJ1dCB3ZSB3YW50IHRvIGRvIGl0IGluIHRoZSBiZXN0CnBvc3NpYmxl IHdheSwgd2l0aCB0aGUgbWluaW11bSBjaGFuY2Ugb2YgcHJvcGFnYXRpbmcgZXJyb3JzIGFuZApj b25mdXNpbmcgYm90aCBoL3cgYW5kIGRldmVsb3BlcnMgaWYgc29tZW9uZSBkb2VzIGludHJvZHVj ZSBhIHJpbmcKb3ZlcnJ1biBvciBvZmYtYnktb25lIGVycm9yIGluIHNvbWUgcmluZy1zdHVmZmlu ZyBjb2RlIGVsc2V3aGVyZS4KKEJUVywKCi5EYXZlLgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeAo=