Re: [PATCH v3 21/28] drm/i915: Remove the now redundant 'obj->ring'

John Harrison
2014-11-28T17:49:29Z

On 26/11/2014 13:43, Daniel Vetter wrote:
> On Mon, Nov 24, 2014 at 06:49:43PM +0000, John.C.Harrison@Intel.com wrote:
>> From: John Harrison <John.C.Harrison@Intel.com>
>>
>> The ring member of the object structure was always updated with the
>> last_read_seqno member. Thus with the conversion to last_read_req, obj->ring is
>> now a direct copy of obj->last_read_req->ring. This makes it somewhat redundant
>> and potentially misleading (especially as there was no comment to explain its
>> purpose).
>>
>> This checkin removes the redundant field. Many uses were simply testing for
>> non-null to see if the object is active on the GPU. Some of these have been
>> converted to check 'obj->active' instead. Others (where the last_read_req is
>> about to be used anyway) have been changed to check obj->last_read_req. The rest
>> simply pull the ring out from the request structure and proceed as before.
>>
>> For: VIZ-4377
>> Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
>> Reviewed-by: Thomas Daniel <Thomas.Daniel@intel.com>
> Ok merged up to this for now. I'd like to settle things a bit first (and
> also figure out what to do with the trace_irq stuff).
>
> Thanks for patches&review,
> Daniel

Now that the 3.19 pull request has gone, are you going to continue
merging these patches? Or is there something else you particularly want
to wait for?

Thanks,
John.