From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Harrison Subject: Re: [PATCH v3 06/28] drm/i915: Ensure requests stick around during waits Date: Wed, 26 Nov 2014 12:27:07 +0000 Message-ID: <5475C71B.1030409@Intel.com> References: <1416854990-1920-1-git-send-email-John.C.Harrison@Intel.com> <1416854990-1920-7-git-send-email-John.C.Harrison@Intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 82C366E48F for ; Wed, 26 Nov 2014 04:27:09 -0800 (PST) In-Reply-To: <1416854990-1920-7-git-send-email-John.C.Harrison@Intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Intel-GFX@Lists.FreeDesktop.Org List-Id: intel-gfx@lists.freedesktop.org TkI6IFRoZSB2MyB1cGRhdGUgd2FzIHRvIGZvbGQgaW4gYSBuZXcgcGF0Y2ggZm9yIGFzeW5jaHJv bm91cyBzaHJpbmtlciAKc2hlbmFuaWdhbnMuIFVuZm9ydHVuYXRlbHksIHRoZSBuZXcgcGF0Y2gg d2FzIG5vdCBhY3R1YWxseSB2YWxpZCBhdCB0aGlzIApwb2ludCBpbiB0aGUgcGF0Y2ggc2VyaWVz LCB0aHVzIHRoaXMgcGF0Y2ggbm93IGJyZWFrcyB0aGUgYnVpbGQgdW50aWwgYSAKbGF0ZXIgcGF0 Y2ggaW4gdGhlIHNlcmllcyBmaXhlcyBpdCB1cCBhZ2FpbiEgSSdsbCBwb3N0IG91dCBhbiB1cGRh dGVkIHY0IApzZXQgd2l0aCB0aGUgb3JkZXIgcmUtd29ya2VkIHNvIHRoYXQgaXQgc3RpbGwgYnVp bGRzIGFuZCBydW5zIGF0IGVhY2ggCnN0ZXAgYWxvbmcgdGhlIHdheS4uLgoKCk9uIDI0LzExLzIw MTQgMTg6NDksIEpvaG4uQy5IYXJyaXNvbkBJbnRlbC5jb20gd3JvdGU6Cj4gRnJvbTogSm9obiBI YXJyaXNvbiA8Sm9obi5DLkhhcnJpc29uQEludGVsLmNvbT4KPgo+IEFkZGVkIHJlZmVyZW5jZSBj b3VudGluZyBvZiB0aGUgcmVxdWVzdCBzdHJ1Y3R1cmUgYXJvdW5kIF9fd2FpdF9zZXFubygpIGNh bGxzLgo+IFRoaXMgaXMgYSBwcmVjdXJzb3IgdG8gdXBkYXRpbmcgdGhlIHdhaXQgY29kZSBpdHNl bGYgdG8gdGFrZSB0aGUgcmVxdWVzdCByYXRoZXIKPiB0aGFuIGEgc2Vxbm8uIEF0IHRoYXQgcG9p bnQsIGl0IHdvdWxkIGJlIGEgQmFkIElkZWEgZm9yIGEgcmVxdWVzdCBvYmplY3QgdG8gYmUKPiBy ZXRpcmVkIGFuZCBmcmVlZCB3aGlsZSB0aGUgd2FpdCBjb2RlIGlzIHN0aWxsIHVzaW5nIGl0Lgo+ Cj4gdjM6Cj4KPiBOb3RlIHRoYXQgZXZlbiB0aG91Z2ggdGhlIG11dGV4IGxvY2sgaXMgaGVsZCBk dXJpbmcgYSBjYWxsIHRvIGk5MTVfd2FpdF9zZXFubygpLAo+IGl0IGlzIHN0aWxsIG5lY2Vzc2Fy eSB0byBleHBsaWNpdGx5IGJ1bXAgdGhlIHJlZmVyZW5jZSBjb3VudC4gSXQgYXBwZWFycyB0aGF0 Cj4gdGhlIHNocmlua2VyIGNhbiBhc3luY2hyb25vdXNseSByZXRpcmUgaXRlbXMgZXZlbiB0aG91 Z2ggdGhlIG11dGV4IGlzIGxvY2tlZC4KPgo+IEZvcjogVklaLTQzNzcKPiBTaWduZWQtb2ZmLWJ5 OiBKb2huIEhhcnJpc29uIDxKb2huLkMuSGFycmlzb25ASW50ZWwuY29tPgo+IFJldmlld2VkLWJ5 OiBUaG9tYXMgRGFuaWVsIDxUaG9tYXMuRGFuaWVsQGludGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgfCAgIDI4ICsrKysrKysrKysrKysrKysrKysrKysr LS0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAyMyBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygt KQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gaW5kZXggOWFjOTE1Ny4uNzEzMDNhMSAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IEBAIC0xMzMzLDggKzEzMzMsMTEgQEAgaTkxNV93 YWl0X3NlcW5vKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcsIHVpbnQzMl90IHNlcW5vKQo+ ICAgCQlyZXR1cm4gcmV0Owo+ICAgCj4gICAJcmVzZXRfY291bnRlciA9IGF0b21pY19yZWFkKCZk ZXZfcHJpdi0+Z3B1X2Vycm9yLnJlc2V0X2NvdW50ZXIpOwo+IC0JcmV0dXJuIF9faTkxNV93YWl0 X3NlcW5vKHJpbmcsIHNlcW5vLCByZXNldF9jb3VudGVyLCBpbnRlcnJ1cHRpYmxlLAo+IC0JCQkJ IE5VTEwsIE5VTEwpOwo+ICsJaTkxNV9nZW1fcmVxdWVzdF9yZWZlcmVuY2UocmVxKTsKPiArCXJl dCA9IF9faTkxNV93YWl0X3NlcW5vKHJpbmcsIHNlcW5vLCByZXNldF9jb3VudGVyLCBpbnRlcnJ1 cHRpYmxlLAo+ICsJCQkJTlVMTCwgTlVMTCk7Cj4gKwlpOTE1X2dlbV9yZXF1ZXN0X3VucmVmZXJl bmNlKHJlcSk7Cj4gKwlyZXR1cm4gcmV0Owo+ICAgfQo+ICAgCj4gICBzdGF0aWMgaW50Cj4gQEAg LTE0MTcsMTAgKzE0MjAsMTIgQEAgaTkxNV9nZW1fb2JqZWN0X3dhaXRfcmVuZGVyaW5nX19ub25i bG9ja2luZyhzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqLAo+ICAgCQlyZXR1cm4gcmV0 Owo+ICAgCj4gICAJcmVzZXRfY291bnRlciA9IGF0b21pY19yZWFkKCZkZXZfcHJpdi0+Z3B1X2Vy cm9yLnJlc2V0X2NvdW50ZXIpOwo+ICsJaTkxNV9nZW1fcmVxdWVzdF9yZWZlcmVuY2UocmVxKTsK PiAgIAltdXRleF91bmxvY2soJmRldi0+c3RydWN0X211dGV4KTsKPiAgIAlyZXQgPSBfX2k5MTVf d2FpdF9zZXFubyhyaW5nLCBzZXFubywgcmVzZXRfY291bnRlciwgdHJ1ZSwgTlVMTCwKPiAgIAkJ CQlmaWxlX3ByaXYpOwo+ICAgCW11dGV4X2xvY2soJmRldi0+c3RydWN0X211dGV4KTsKPiArCWk5 MTVfZ2VtX3JlcXVlc3RfdW5yZWZlcmVuY2UocmVxKTsKPiAgIAlpZiAocmV0KQo+ICAgCQlyZXR1 cm4gcmV0Owo+ICAgCj4gQEAgLTI5MjAsNiArMjkyNSw3IEBAIGk5MTVfZ2VtX3dhaXRfaW9jdGwo c3RydWN0IGRybV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwgc3RydWN0IGRybV9maWxlICpmaWxl KQo+ICAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZh dGU7Cj4gICAJc3RydWN0IGRybV9pOTE1X2dlbV93YWl0ICphcmdzID0gZGF0YTsKPiAgIAlzdHJ1 Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqOwo+ICsJc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1 ZXN0ICpyZXE7Cj4gICAJc3RydWN0IGludGVsX2VuZ2luZV9jcyAqcmluZyA9IE5VTEw7Cj4gICAJ dW5zaWduZWQgcmVzZXRfY291bnRlcjsKPiAgIAl1MzIgc2Vxbm8gPSAwOwo+IEBAIC0yOTQ2LDcg KzI5NTIsOCBAQCBpOTE1X2dlbV93YWl0X2lvY3RsKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHZv aWQgKmRhdGEsIHN0cnVjdCBkcm1fZmlsZSAqZmlsZSkKPiAgIAlpZiAoIW9iai0+YWN0aXZlIHx8 ICFvYmotPmxhc3RfcmVhZF9yZXEpCj4gICAJCWdvdG8gb3V0Owo+ICAgCj4gLQlzZXFubyA9IGk5 MTVfZ2VtX3JlcXVlc3RfZ2V0X3NlcW5vKG9iai0+bGFzdF9yZWFkX3JlcSk7Cj4gKwlyZXEgPSBv YmotPmxhc3RfcmVhZF9yZXE7Cj4gKwlzZXFubyA9IGk5MTVfZ2VtX3JlcXVlc3RfZ2V0X3NlcW5v KHJlcSk7Cj4gICAJV0FSTl9PTihzZXFubyA9PSAwKTsKPiAgIAlyaW5nID0gb2JqLT5yaW5nOwo+ ICAgCj4gQEAgLTI5NjAsMTAgKzI5NjcsMTUgQEAgaTkxNV9nZW1fd2FpdF9pb2N0bChzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRhLCBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGUpCj4gICAK PiAgIAlkcm1fZ2VtX29iamVjdF91bnJlZmVyZW5jZSgmb2JqLT5iYXNlKTsKPiAgIAlyZXNldF9j b3VudGVyID0gYXRvbWljX3JlYWQoJmRldl9wcml2LT5ncHVfZXJyb3IucmVzZXRfY291bnRlcik7 Cj4gKwlpOTE1X2dlbV9yZXF1ZXN0X3JlZmVyZW5jZShyZXEpOwo+ICAgCW11dGV4X3VubG9jaygm ZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ICAgCj4gLQlyZXR1cm4gX19pOTE1X3dhaXRfc2Vxbm8ocmlu Zywgc2Vxbm8sIHJlc2V0X2NvdW50ZXIsIHRydWUsCj4gLQkJCQkgJmFyZ3MtPnRpbWVvdXRfbnMs IGZpbGUtPmRyaXZlcl9wcml2KTsKPiArCXJldCA9IF9faTkxNV93YWl0X3NlcW5vKHJpbmcsIHNl cW5vLCByZXNldF9jb3VudGVyLCB0cnVlLCAmYXJncy0+dGltZW91dF9ucywKPiArCQkJICAgZmls ZS0+ZHJpdmVyX3ByaXYpOwo+ICsJbXV0ZXhfbG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ICsJ aTkxNV9nZW1fcmVxdWVzdF91bnJlZmVyZW5jZShyZXEpOwo+ICsJbXV0ZXhfdW5sb2NrKCZkZXYt PnN0cnVjdF9tdXRleCk7Cj4gKwlyZXR1cm4gcmV0Owo+ICAgCj4gICBvdXQ6Cj4gICAJZHJtX2dl bV9vYmplY3RfdW5yZWZlcmVuY2UoJm9iai0+YmFzZSk7Cj4gQEAgLTQxMjIsNiArNDEzNCw4IEBA IGk5MTVfZ2VtX3JpbmdfdGhyb3R0bGUoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgc3RydWN0IGRy bV9maWxlICpmaWxlKQo+ICAgCQl0YXJnZXQgPSByZXF1ZXN0Owo+ICAgCX0KPiAgIAlyZXNldF9j b3VudGVyID0gYXRvbWljX3JlYWQoJmRldl9wcml2LT5ncHVfZXJyb3IucmVzZXRfY291bnRlcik7 Cj4gKwlpZiAodGFyZ2V0KQo+ICsJCWk5MTVfZ2VtX3JlcXVlc3RfcmVmZXJlbmNlKHRhcmdldCk7 Cj4gICAJc3Bpbl91bmxvY2soJmZpbGVfcHJpdi0+bW0ubG9jayk7Cj4gICAKPiAgIAlpZiAodGFy Z2V0ID09IE5VTEwpCj4gQEAgLTQxMzMsNiArNDE0NywxMCBAQCBpOTE1X2dlbV9yaW5nX3Rocm90 dGxlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0cnVjdCBkcm1fZmlsZSAqZmlsZSkKPiAgIAlp ZiAocmV0ID09IDApCj4gICAJCXF1ZXVlX2RlbGF5ZWRfd29yayhkZXZfcHJpdi0+d3EsICZkZXZf cHJpdi0+bW0ucmV0aXJlX3dvcmssIDApOwo+ICAgCj4gKwltdXRleF9sb2NrKCZkZXYtPnN0cnVj dF9tdXRleCk7Cj4gKwlpOTE1X2dlbV9yZXF1ZXN0X3VucmVmZXJlbmNlKHRhcmdldCk7Cj4gKwlt dXRleF91bmxvY2soJmRldi0+c3RydWN0X211dGV4KTsKPiArCj4gICAJcmV0dXJuIHJldDsKPiAg IH0KPiAgIAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK