Re: [PATCH v4 4/4] drm/i915: Additional request structure tracing

Daniel Vetter
2014-12-05T20:50:00Z

On Fri, Dec 05, 2014 at 09:48:03PM +0100, Daniel Vetter wrote:
> On Fri, Dec 05, 2014 at 01:49:36PM +0000, John.C.Harrison@Intel.com wrote:
> > From: John Harrison <John.C.Harrison@Intel.com>
> >
> > Added the request structure's 'uniq' identifier to the trace information. Also
> > renamed the '_complete' trace event to '_notify' as it actually happens in the
> > IRQ 'notify_ring()' function. The intention is to add a new '_complete' trace
> > event which occurs when a request structure is actually marked as complete.
> > However, at the moment the completion status is re-tested every time the query
> > is made so there isn't a completion event as such.
> >
> > v2: New patch added to series.
> >
> > v3: Rebased to remove completion caching as that is apparently contentious.
> >
> > Change-Id: Ic9bcde67d175c6c03b96217cdcb6e4cc4aa45d67
> > For: VIZ-4377
> > Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
> > Reviewed-by: Thomas Daniel <Thomas.Daniel@intel.com>
>
> Ok I guess you'll hate this by now, but struct fence provides all this
> already, too. It doesn't use the uniq id trick you have put instead just
> uses the pointer. But there's create/destroy tracepoints too afaik, so I
> think we're covered.
>
> I've merged the first two patches from this series, thanks.

Well changed my mind again since it's just an extension of what we have.
So patches 3&4 are merged, too. But yeah I think we really sould switch
over to the fence stuff for all this.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch