From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH 1/2] drm/i915: compute wait_ioctl timeout correctly Date: Fri, 28 Nov 2014 13:46:27 +0000 Message-ID: <54787CB3.7000108@intel.com> References: <1417166995-10803-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 50B786EE54 for ; Fri, 28 Nov 2014 05:46:29 -0800 (PST) In-Reply-To: <1417166995-10803-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , Intel Graphics Development Cc: Daniel Vetter , Thomas Gleixner , John Stultz List-Id: intel-gfx@lists.freedesktop.org T24gMjgvMTEvMTQgMDk6MjksIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gV2UndmUgbG9zdCB0aGUg KzEgcmVxdWlyZWQgZm9yIGNvcnJlY3QgdGltZW91dHMgaW4KPiAKPiBjb21taXQgNWVkMGJkZjIx YTg1ZDc4ZTA0Zjg5ZjE1Y2NmMjI3NTYyMTc3Y2JkOQo+IEF1dGhvcjogVGhvbWFzIEdsZWl4bmVy IDx0Z2x4QGxpbnV0cm9uaXguZGU+Cj4gRGF0ZTogICBXZWQgSnVsIDE2IDIxOjA1OjA2IDIwMTQg KzAwMDAKPiAKPiAgICAgZHJtOiBpOTE1OiBVc2UgbnNlYyBiYXNlZCBpbnRlcmZhY2VzCj4gCj4g ICAgIFVzZSBrdGltZV9nZXRfcmF3X25zKCkgYW5kIGdldCByaWQgb2YgdGhlIGJhY2sgYW5kIGZv cnRoIHRpbWVzcGVjCj4gICAgIGNvbnZlcnNpb25zLgo+IAo+ICAgICBTaWduZWQtb2ZmLWJ5OiBU aG9tYXMgR2xlaXhuZXIgPHRnbHhAbGludXRyb25peC5kZT4KPiAgICAgQWNrZWQtYnk6IERhbmll bCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gICAgIFNpZ25lZC1vZmYtYnk6IEpv aG4gU3R1bHR6IDxqb2huLnN0dWx0ekBsaW5hcm8ub3JnPgo+IAo+IFNvIGZpeCB0aGlzIHVwIGJ5 IHJlaW5zdGF0aW5nIG91ciBoYW5kcm9sbGVkIF90aW1lb3V0IGZ1bmN0aW9uLiBXaGlsZQo+IGF0 IGl0IGJvdGhlciB3aXRoIGhhbmRsaW5nIE1BWF9KSUZGSUVTLgo+IAo+IEJ1Z3ppbGxhOiBodHRw czovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD04Mjc0OQo+IENjOiBUaG9t YXMgR2xlaXhuZXIgPHRnbHhAbGludXRyb25peC5kZT4KPiBDYzogSm9obiBTdHVsdHogPGpvaG4u c3R1bHR6QGxpbmFyby5vcmc+Cj4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVs LnZldHRlckBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2 LmggfCAxMCArKysrKysrKysrCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgfCAg MyArKy0KPiAgMiBmaWxlcyBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0p Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gaW5kZXggMDJiM2NiMzJjOGE2Li5jYWFlMzM3 YzAxOTkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBAQCAtMzAzMCw2ICszMDMwLDE2 IEBAIHN0YXRpYyBpbmxpbmUgdW5zaWduZWQgbG9uZyBtc2Vjc190b19qaWZmaWVzX3RpbWVvdXQo Y29uc3QgdW5zaWduZWQgaW50IG0pCj4gIAlyZXR1cm4gbWluX3QodW5zaWduZWQgbG9uZywgTUFY X0pJRkZZX09GRlNFVCwgaiArIDEpOwo+ICB9Cj4gIAo+ICtzdGF0aWMgaW5saW5lIHVuc2lnbmVk IGxvbmcgbnNlY3NfdG9famlmZmllc190aW1lb3V0KGNvbnN0IHU2NCBtKQo+ICt7Cj4gKwl1bnNp Z25lZCBsb25nIGogPSBuc2Vjc190b19qaWZmaWVzKG0pOwoKbnNlY3NfdG9famlmZmllcygpIG1h eSBiZSAocmVsYXRpdmVseSkgZXhwZW5zaXZlIChtdWwvZGl2L2V0YyksIHNvIEknZApiZSBpbmNs aW5lZCB0byBtb3ZlIHRoZSBjYWxsIHVudGlsIGFmdGVyIHRoZSB0ZXN0IGJlbG93LiBJdCB3b3Vs ZCBiZQpuaWNlIGlmIHRoZSB0ZXN0IHR1cm5lZCBpbnRvIGEgc2luZ2xlIGNvbXBhcmlzb24sIHNp bmNlIHRoZSBSSFMgaXMgYQpjb25zdGFudCBmb3IgYSBnaXZlbiBrZXJuZWwgYnVpbGQ7IGJ1dCBp dCBsb29rcyBsaWtlIGppZmZpZXNfdG9fdXNlY3MoKQppc24ndCBleHBhbmRlZCBpbmxpbmUsIHNp bmNlIGl0J3MgaW4gdGltZS5jIDotKCBJbiB3aGljaCBjYXNlIHN3YXBwaW5nCnRoZSBsaW5lcyBh cm91bmQgbWF5IGFsc28gaGVscCB0aGUgY29tcGlsZXIga2VlcCAnaicgbGl2ZS4KCj4gKwlpZiAo bSA+ICh1NjQpamlmZmllc190b191c2VjcyhNQVhfSklGRllfT0ZGU0VUKSAqIDEwMDApCgpJIHRo aW5rIHRoZXJlJ3MgYSBwcm9ibGVtIHdpdGggdGhpcyBsaW5lIGFueXdheS4gSW4ga2VybmVsL3Rp bWUvdGltZS5jOgoKLy8gV2FybmluZyEgUmVzdWx0IHR5cGUgbWF5IGJlIG5hcnJvd2VyIHRoYW4g cGFyYW1ldGVyIHR5cGUgLSBEU0cKdW5zaWduZWQgaW50IGppZmZpZXNfdG9fdXNlY3MoY29uc3Qg dW5zaWduZWQgbG9uZyBqKQp7CiNpZiBIWiA8PSBVU0VDX1BFUl9TRUMgJiYgIShVU0VDX1BFUl9T RUMgJSBIWikKICAgICAgICByZXR1cm4gKFVTRUNfUEVSX1NFQyAvIEhaKSAqIGo7CiNlbGlmIEha ID4gVVNFQ19QRVJfU0VDICYmICEoSFogJSBVU0VDX1BFUl9TRUMpCiAgICAgICAgcmV0dXJuIChq ICsgKEhaIC8gVVNFQ19QRVJfU0VDKSAtIDEpLyhIWiAvIFVTRUNfUEVSX1NFQyk7CiNlbHNlCiMg aWYgQklUU19QRVJfTE9ORyA9PSAzMgogICAgICAgIHJldHVybiAoSFpfVE9fVVNFQ19NVUwzMiAq IGopID4+IEhaX1RPX1VTRUNfU0hSMzI7CiMgZWxzZQogICAgICAgIHJldHVybiAoaiAqIEhaX1RP X1VTRUNfTlVNKSAvIEhaX1RPX1VTRUNfREVOOwojIGVuZGlmCiNlbmRpZgp9CgpBbHNvLCBpbmNs dWRlL2xpbnV4L2ppZmZpZXMuaDoKCiNkZWZpbmUgTUFYX0pJRkZZX09GRlNFVCAoKExPTkdfTUFY ID4+IDEpLTEpCgphbmQgaW5jbHVkZS9saW51eC9rZXJuZWwuaDoKCiNkZWZpbmUgTE9OR19NQVgg ICAgICAgICgobG9uZykofjBVTD4+MSkpCgpTbywgb24gYSA2NC1iaXQgYnVpbGQgd2UnbGwgaGF2 ZSBMT05HX01BWCA9PSAweDdmZmZfZmZmZl9mZmZmX2ZmZmYgYW5kCk1BWF9KSUZGWV9PRkZTRVQg PT0gMHgzZmZmX2ZmZmZfZmZmZl9mZmZlLiBNdWx0aXBseWluZyB0aGF0IGJ5IDEwMDAKZ2l2ZXMg YW4gYW5zd2VyIHRoYXQgZG9lc24ndCBmaXQgaW4gYW4gdW5zaWduZWQgaW50IQoKRXZlbiBvbiBh IDMyLWJpdCBidWlsZCAod2hlcmUgTE9OR19NQVggPT0gMHg3ZmZmX2ZmZmYgYW5kCk1BWF9KSUZG WV9PRkZTRVQgPT0gMHgzZmZmX2ZmZmUpIE1BWF9KSUZGWV9PRkZTRVQgY2FuJ3QgYmUgbXVsdGlw bGllZCBieQphbnkgdHlwaWNhbCB2YWx1ZSBvZiBIWiAoNTAsIDYwLCAxMDAwKSB3aXRob3V0IG92 ZXJmbG93IQoKSSB0aGluayB0aGUgb25seSB3YXkgdG8gZ2V0IHRoaXMgcmlnaHQsIGdpdmUgdGhl IHNvbWV3aGF0IGJyb2tlbiBuYXR1cmUKb2YgdGhlIGtlcm5lbCBmdW5jdGlvbiBzaWduYXR1cmVz IGFuZCBpdHMgbGFjayBvZiBhIHU2NCBqaWZmaWVzLXRvLW5zZWNzCmZ1bmN0aW9uLCBpcyB0byBj b252ZXJ0IE9ORSBqaWZmeSB0byAodW5zaWduZWQgaW50KSB1c2VjcywKdGhlbiB3aWRlbiB0byB1 NjQgYmVmb3JlIGNvbnZlcnRpbmcgdG8gbnNlY3MgYW5kIHVzaW5nIHRoYXQgZm9yIHRoZSByZXN0 Cm9mIHRoZSBjYWxjdWxhdGlvbnMuCgouRGF2ZS4KCj4gKwkJcmV0dXJuIE1BWF9KSUZGWV9PRkZT RVQ7Cj4gKwo+ICsJcmV0dXJuIG1pbl90KHVuc2lnbmVkIGxvbmcsIE1BWF9KSUZGWV9PRkZTRVQs IGogKyAxKTsKPiArfQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngK