public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Singh, Gaurav K" <gaurav.k.singh@intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
	intel-gfx <intel-gfx@lists.freedesktop.org>
Cc: Shobhit Kumar <shobhit.kumar@intel.com>
Subject: Re: [PATCH 0/9] BYT DSI Dual Link Support
Date: Thu, 04 Dec 2014 11:07:27 +0530	[thread overview]
Message-ID: <547FF317.4070407@intel.com> (raw)
In-Reply-To: <87zjb7a3cv.fsf@intel.com>


On 12/1/2014 7:17 PM, Jani Nikula wrote:
> On Sat, 29 Nov 2014, Gaurav K Singh <gaurav.k.singh@intel.com> wrote:
>> Hi,
>>
>> These set of patches build on top of the existing DSI Video mode support to
>> enable dual link MIPI panels with high resolutions. These patches have been
>> tested on a 25x16 panel and works well.
> Good job, it's starting to look good. Please go ahead and start
> addressing the review comments I made. I've glanced through all the
> patches, but I'll still have a more in-depth look.
>
> Thanks,
> Jani.
Hi Jani,

Thanks for the review comments. I have addressed all your review 
comments and have uploaded the new patch set. Please review.

With regards,
Gaurav
>
>> v2: Commit message added to all patches. All review comments of Jani, Nikula
>> have been addressed in the second version of patches.
>>
>> v3: for_each_dsi_port macro used instead of for loop for dual link support
>>
>> Regards
>> Gaurav
>>
>> Gaurav K Singh (9):
>>    drm/i915: New functions added for enabling & disabling MIPI Port Ctrl
>>      reg
>>    drm/i915: Added port as parameter to the functions which does
>>      read/write of DSI Controller
>>    drm/i915: Add support for port enable/disable for dual link
>>      configuration
>>    drm/i915: Pixel Clock changes for DSI dual link
>>    drm/i915: Dual link needs Shutdown and Turn on packet for both ports
>>    drm/i915: Enable DSI PLL for both DSI0 and DSI1 in case of dual link
>>    drm/i915: MIPI Timings related changes for dual link
>>    drm/i915: Update the DSI disable path to support dual link panel
>>      disabling
>>    drm/i915: Update the DSI enable path to support dual link panel
>>      enabling
>>
>>   drivers/gpu/drm/i915/i915_reg.h            |    5 +
>>   drivers/gpu/drm/i915/intel_bios.h          |    3 +-
>>   drivers/gpu/drm/i915/intel_dsi.c           |  415 +++++++++++++++++-----------
>>   drivers/gpu/drm/i915/intel_dsi.h           |    7 +
>>   drivers/gpu/drm/i915/intel_dsi_cmd.c       |  101 ++++---
>>   drivers/gpu/drm/i915/intel_dsi_cmd.h       |   46 +--
>>   drivers/gpu/drm/i915/intel_dsi_panel_vbt.c |   49 +++-
>>   drivers/gpu/drm/i915/intel_dsi_pll.c       |    9 +-
>>   8 files changed, 383 insertions(+), 252 deletions(-)
>>
>> -- 
>> 1.7.9.5
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2014-12-04  5:37 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-29  9:55 [PATCH 0/9] BYT DSI Dual Link Support Gaurav K Singh
2014-11-29  9:55 ` [PATCH 1/9] drm/i915: New functions added for enabling & disabling MIPI Port Ctrl reg Gaurav K Singh
2014-11-29  9:56 ` [PATCH 2/9] drm/i915: Added port as parameter to the functions which does read/write of DSI Controller Gaurav K Singh
2014-12-01 13:40   ` Jani Nikula
2014-11-29  9:56 ` [PATCH 3/9] drm/i915: Add support for port enable/disable for dual link configuration Gaurav K Singh
2014-12-01 13:23   ` Jani Nikula
2014-12-01 14:11     ` Jani Nikula
2014-12-01 18:05       ` Singh, Gaurav K
2014-12-01 19:21         ` Jani Nikula
2014-11-29  9:56 ` [PATCH 4/9] drm/i915: Pixel Clock changes for DSI dual link Gaurav K Singh
2014-11-29  9:56 ` [PATCH 5/9] drm/i915: Dual link needs Shutdown and Turn on packet for both ports Gaurav K Singh
2014-11-29  9:56 ` [PATCH 6/9] drm/i915: Enable DSI PLL for both DSI0 and DSI1 in case of dual link Gaurav K Singh
2014-12-01 13:27   ` Jani Nikula
2014-12-01 17:37     ` Singh, Gaurav K
2014-11-29  9:56 ` [PATCH 7/9] drm/i915: MIPI Timings related changes for " Gaurav K Singh
2014-11-29  9:56 ` [PATCH 8/9] drm/i915: Update the DSI disable path to support dual link panel disabling Gaurav K Singh
2014-11-29  9:56 ` [PATCH 9/9] drm/i915: Update the DSI enable path to support dual link panel enabling Gaurav K Singh
2014-12-03 17:34   ` shuang.he
2014-12-01 13:47 ` [PATCH 0/9] BYT DSI Dual Link Support Jani Nikula
2014-12-04  5:37   ` Singh, Gaurav K [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-09-24  8:46 Gaurav K Singh
2014-09-24  9:01 ` Daniel Vetter
2014-09-25 12:47   ` Shobhit Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=547FF317.4070407@intel.com \
    --to=gaurav.k.singh@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=shobhit.kumar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox