From: Michel Thierry <michel.thierry@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/bdw: Add WaHdcDisableFetchWhenMasked
Date: Thu, 04 Dec 2014 15:36:32 +0000 [thread overview]
Message-ID: <54807F80.5080706@intel.com> (raw)
In-Reply-To: <20141204152556.GE10649@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 1571 bytes --]
On 12/4/2014 3:25 PM, Ville Syrjälä wrote:
> On Thu, Dec 04, 2014 at 03:07:52PM +0000, Michel Thierry wrote:
>> We already have it for chv, but was missing for bdw.
>>
>> Signed-off-by: Michel Thierry <michel.thierry@intel.com>
>> ---
>> drivers/gpu/drm/i915/intel_ringbuffer.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
>> index 788e1b6..91ddcd1 100644
>> --- a/drivers/gpu/drm/i915/intel_ringbuffer.c
>> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
>> @@ -756,9 +756,11 @@ static int bdw_init_workarounds(struct intel_engine_cs *ring)
>> * workaround for for a possible hang in the unlikely event a TLB
>> * invalidation occurs during a PSD flush.
>> */
>> + /* WaHdcDisableFetchWhenMasked:bdw */
>> /* WaDisableFenceDestinationToSLM:bdw (GT3 pre-production) */
>> WA_SET_BIT_MASKED(HDC_CHICKEN0,
>> HDC_FORCE_NON_COHERENT |
>> + HDC_DONOT_FETCH_MEM_WHEN_MASKED |
>> (IS_BDW_GT3(dev) ? HDC_FENCE_DEST_SLM_DISABLE : 0));
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> We also seem to miss the w/a name for the "force non-coherent" thing.
> Can you add that as well?
Sure, I'll add the missing _WaForceEnableNonCoherent:bdw_ label
>>
>> /* Wa4x4STCOptimizationDisable:bdw */
>> --
>> 2.1.1
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5510 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-12-04 15:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 15:07 [PATCH] drm/i915/bdw: Add WaHdcDisableFetchWhenMasked Michel Thierry
2014-12-04 15:25 ` Ville Syrjälä
2014-12-04 15:36 ` Michel Thierry [this message]
2014-12-05 14:41 ` Daniel Vetter
2014-12-09 13:37 ` Michel Thierry
2014-12-10 9:18 ` Daniel Vetter
2014-12-10 9:47 ` Michel Thierry
2014-12-04 15:40 ` [PATCH v2] " Michel Thierry
2014-12-04 23:11 ` shuang.he
2014-12-04 19:58 ` [PATCH] " shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54807F80.5080706@intel.com \
--to=michel.thierry@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox