public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Singh, Gaurav K" <gaurav.k.singh@intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
	intel-gfx <intel-gfx@lists.freedesktop.org>
Cc: Shobhit Kumar <shobhit.kumar@intel.com>
Subject: Re: [PATCH] drm/i915: Use DSI Pll1 for enabling MIPI DSI on	Port C
Date: Tue, 09 Dec 2014 11:06:30 +0530	[thread overview]
Message-ID: <54868A5E.6040409@intel.com> (raw)
In-Reply-To: <87zjayml51.fsf@intel.com>


On 12/8/2014 5:03 PM, Jani Nikula wrote:
> On Sun, 07 Dec 2014, Gaurav K Singh <gaurav.k.singh@intel.com> wrote:
>> DSI Pll1 is used for enabling DSI on Port C.
>>
>> Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
>> ---
>>   drivers/gpu/drm/i915/intel_dsi_pll.c |    7 +++++--
>>   1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_dsi_pll.c b/drivers/gpu/drm/i915/intel_dsi_pll.c
>> index 8957f10..9b7f6a5 100644
>> --- a/drivers/gpu/drm/i915/intel_dsi_pll.c
>> +++ b/drivers/gpu/drm/i915/intel_dsi_pll.c
>> @@ -241,9 +241,12 @@ static void vlv_configure_dsi_pll(struct intel_encoder *encoder)
>>   		return;
>>   	}
>>   
>> -	dsi_mnp.dsi_pll_ctrl |= DSI_PLL_CLK_GATE_DSI0_DSIPLL;
>> +	if ((intel_dsi->ports == ((1 << PORT_A) | (1 << PORT_C))) ||
>> +	    (intel_dsi->ports == (1 << PORT_A)))
>> +		dsi_mnp.dsi_pll_ctrl |= DSI_PLL_CLK_GATE_DSI0_DSIPLL;
>>   
>> -	if (intel_dsi->dual_link)
>> +	if ((intel_dsi->ports == ((1 << PORT_A) | (1 << PORT_C))) ||
>> +	    (intel_dsi->ports == (1 << PORT_C)))
>>   		dsi_mnp.dsi_pll_ctrl |= DSI_PLL_CLK_GATE_DSI1_DSIPLL;
> In other words, patches 1 and 2 can be squashed into one that has:
>
> 	if (intel_dsi->ports & (1 << PORT_A))
> 		dsi_mnp.dsi_pll_ctrl |= DSI_PLL_CLK_GATE_DSI0_DSIPLL;
>
> 	if (intel_dsi->ports & (1 << PORT_C))
> 		dsi_mnp.dsi_pll_ctrl |= DSI_PLL_CLK_GATE_DSI1_DSIPLL;
>
> Right?
>
> BR,
> Jani.
Jani,

Yes, uploaded the new patch addressing your comments.

With regards,
Gaurav
>
>>   
>>   	DRM_DEBUG_KMS("dsi pll div %08x, ctrl %08x\n",
>> -- 
>> 1.7.9.5
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2014-12-09  5:36 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-07 10:43 [PATCH 0/4] BYT DSI Enable on Port C Gaurav K Singh
2014-12-07 10:43 ` [PATCH 1/4] drm/i915: Use DSI Pll1 for enabling MIPI DSI " Gaurav K Singh
2014-12-07 11:21   ` [PATCH] " Gaurav K Singh
2014-12-08 11:33     ` Jani Nikula
2014-12-09  5:36       ` Singh, Gaurav K [this message]
2014-12-09  0:45     ` shuang.he
2014-12-09  5:27     ` [PATCH 1/4] " Gaurav K Singh
2014-12-09  8:27       ` Jani Nikula
2014-12-07 10:43 ` [PATCH 2/4] drm/i915: DSI sequence related changes for DSI " Gaurav K Singh
2014-12-09  9:51   ` Singh, Gaurav K
2014-12-09 10:30     ` Jani Nikula
2014-12-09 13:49       ` Singh, Gaurav K
2014-12-10  9:20       ` Daniel Vetter
2014-12-10  9:35         ` Singh, Gaurav K
2014-12-10 16:37         ` [PATCH 2/4] drm/i915: Changes related to the sequence port no for Gaurav K Singh
2014-12-10 17:01           ` Daniel Vetter
2014-12-07 10:43 ` [PATCH 3/4] drm/i915: Enable MIPI PHY transparent latch for DSI Port C Gaurav K Singh
2014-12-09  8:36   ` Jani Nikula
2014-12-07 10:43 ` [PATCH 4/4] drm/i915: Get HW state changes required for DSI port C Gaurav K Singh
2014-12-08 11:37   ` Jani Nikula
2014-12-08 13:13     ` Singh, Gaurav K
2014-12-08 13:31       ` Jani Nikula
2014-12-09  5:29         ` [PATCH 4/4] drm/i915: Software workaround for getting the HW status of DSI Port C on BYT Gaurav K Singh
2014-12-09  8:34           ` Jani Nikula
2014-12-09  9:49             ` Daniel Vetter
2014-12-09  0:41   ` [PATCH 4/4] drm/i915: Get HW state changes required for DSI port C shuang.he

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54868A5E.6040409@intel.com \
    --to=gaurav.k.singh@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=shobhit.kumar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox