Re: [PATCH 2/4] drm/i915: DSI sequence related changes for DSI Port C

["Singh, Gaurav K" <gaurav.k.singh@intel.com>]

On 12/9/2014 4:00 PM, Jani Nikula wrote:
> On Tue, 09 Dec 2014, "Singh, Gaurav K" <gaurav.k.singh@intel.com> wrote:
>> On 12/7/2014 4:13 PM, Gaurav K Singh wrote:
>>> For DSI Port A & C, the seq_port value has been set to 0 now in VBT
>>> Now  the sequence of DSI single link on Port A and Port C will based
>>> on the DVO port from VBT block 2.
>>>
>>> Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
>>> ---
>>>    drivers/gpu/drm/i915/intel_dsi_panel_vbt.c |    9 ++++++++-
>>>    1 file changed, 8 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
>>> index f8c2269..e7e2e52 100644
>>> --- a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
>>> +++ b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
>>> @@ -110,7 +110,14 @@ static u8 *mipi_exec_send_packet(struct intel_dsi *intel_dsi, u8 *data)
>>>    	vc = (byte >> MIPI_VIRTUAL_CHANNEL_SHIFT) & 0x3;
>>>    	seq_port = (byte >> MIPI_PORT_SHIFT) & 0x3;
>>>    
>>> -	port = intel_dsi_seq_port_to_port(seq_port);
>>> +	/* For DSI Port A & C, the seq_port value has been set to 0 now in VBT
>>> +	 * Now  the sequence of DSI single link on Port A and Port C will based
>>> +	 * on the DVO port from VBT block 2.
>>> +	 */
>>> +	if (intel_dsi->ports == (1 << PORT_C))
>>> +		port = PORT_C;
>>> +	else
>>> +		port = intel_dsi_seq_port_to_port(seq_port);
>>>    	/* LP or HS mode */
>>>    	intel_dsi->hs = mode;
>>>    
>> Jani,
>>
>> Need your reviewed-by on this patch too.
> Okay, I was confused because there were actually five patches in this
> four patch series! ;)
>
> The *code* is
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
> because I understand it, but frankly both the commit message and the
> comment confuse me more.
Thanks Jani. I uploaded the next version of my 1/4 patch over my message 
id only, but sorry for the confusion.

Daniel,
Could you please merge this patch too, got reviewed-by from Jani. Thanks.

With regards,
Gaurav

>
>
>> With regards,
>> Gaurav
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx