From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0877EC433EF for ; Thu, 7 Jul 2022 12:52:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EAFA418A670; Thu, 7 Jul 2022 12:52:13 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 36CF518A670; Thu, 7 Jul 2022 12:52:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657198333; x=1688734333; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=sUmpYmaViu+lemc46xSk7xcNUF62Nnomsua089pJL4w=; b=NM22LX4aYeFNqHnEqGjBw0JknJQiiO1teGcBEDQ1flf43+OIJCgi63Ro yki0mcucow2D0/GUA6uiYvD6dv1nelu+MmIPgTsbEA1aIdiN8PKCKsPtN a/0poTD7W6tLtc8a/tjuV7+tu4HV9dOJS+41Br8+kOIPp7XiA7J599c4D NUdRsj7vnL3lsFBKNHzBEnhEuhmV0eRihkauoJecxgTH78oNO3xBqlf10 sQ8LxVCXZaBUagBONIw2Mg8S5MB+PjxmbgPUoLy7m9pxP66wZgDoZFa3k 1mppEsE0fOPjPwRxWtUQJTckLkTbFWTRbWwRu2VM+/tt1nqSmoHQ7hcdY A==; X-IronPort-AV: E=McAfee;i="6400,9594,10400"; a="264431338" X-IronPort-AV: E=Sophos;i="5.92,252,1650956400"; d="scan'208";a="264431338" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2022 05:52:12 -0700 X-IronPort-AV: E=Sophos;i="5.92,252,1650956400"; d="scan'208";a="661375986" Received: from nirmoyda-mobl.ger.corp.intel.com (HELO [10.252.2.229]) ([10.252.2.229]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2022 05:52:11 -0700 Message-ID: <5487db31-4c7b-2f7a-69df-211a14e5d2d8@linux.intel.com> Date: Thu, 7 Jul 2022 14:52:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Matthew Auld , igt-dev@lists.freedesktop.org References: <20220707122336.391524-1-matthew.auld@intel.com> From: "Das, Nirmoy" In-Reply-To: <20220707122336.391524-1-matthew.auld@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] Revert "lib/i915: request CPU_ACCESS for fb objects" X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, Nirmoy Das Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Reviewed-by: Nirmoy Das On 7/7/2022 2:23 PM, Matthew Auld wrote: > This reverts commit 3cf110f8dcd1f4f02cf84339664b413abdaebf7d. > > This is too big of a hammer it seems, since we can't really support > flat-CCS with lmem + smem objects, and here adding the flag means we > also attach the smem placement, which seems to break kms_ccs. > > Signed-off-by: Matthew Auld > Cc: Juha-Pekka Heikkila > Cc: Nirmoy Das > --- > lib/ioctl_wrappers.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c > index 7713e78b..09eb3ce7 100644 > --- a/lib/ioctl_wrappers.c > +++ b/lib/ioctl_wrappers.c > @@ -635,8 +635,7 @@ uint32_t gem_buffer_create_fb_obj(int fd, uint64_t size) > uint32_t handle; > > if (gem_has_lmem(fd)) > - handle = gem_create_with_cpu_access_in_memory_regions(fd, size, > - REGION_LMEM(0)); > + handle = gem_create_in_memory_regions(fd, size, REGION_LMEM(0)); > else > handle = gem_create(fd, size); >