From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ander Conselvan de Oliveira Subject: Re: [RFC][PATCH 6/8] drm/i915: Remove intel_crtc->new_config pointer Date: Wed, 10 Dec 2014 15:48:47 +0200 Message-ID: <54884F3F.3000105@gmail.com> References: <1418052069-14831-1-git-send-email-ander.conselvan.de.oliveira@intel.com> <1418052069-14831-7-git-send-email-ander.conselvan.de.oliveira@intel.com> <20141208163610.GC27182@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 502046E5C5 for ; Wed, 10 Dec 2014 05:48:47 -0800 (PST) In-Reply-To: <20141208163610.GC27182@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , Ander Conselvan de Oliveira Cc: intel-gfx@lists.freedesktop.org, shuang.he@linux.intel.com List-Id: intel-gfx@lists.freedesktop.org T24gMTIvMDgvMjAxNCAwNjozNiBQTSwgRGFuaWVsIFZldHRlciB3cm90ZToKPiBPbiBNb24sIERl YyAwOCwgMjAxNCBhdCAwNToyMTowN1BNICswMjAwLCBBbmRlciBDb25zZWx2YW4gZGUgT2xpdmVp cmEgd3JvdGU6Cj4+IFRoZXJlIGFyZSBubyBtb3JlIHVzZXJzIG9mIHRoYXQgcG9pbnRlciBzaW5j ZSB0aGUgbmV3IGNvbmZpZyBpcyBub3cKPj4gcGFzc2VkIGRvd24gdGhlIGNhbGwgY2hhaW4gZHVy aW5nIG1vZGUgc2V0LiBBbHNvLCB3aGVuIHRoZSBzd2l0Y2ggdG8KPj4gYXRvbWljIGhhcHBlbnMs IHRoZSByaWdodCBjb25maWcgKHN0YXRlKSBzaG91bGQgYmUgZGVyaXZlZCBmcm9tIGFuCj4+IGF0 b21pYyBzdGF0ZSBzdHJ1Y3R1cmUuCj4KPiBBaCwgZG9lc24ndCBzZWVtIG11Y2ggd29yayBhY3R1 YWxseSB0byByZW1vdmUgb3VyIHVzYWdlIG9mIC0+bmV3X2NvbmZpZy4KPiBXaGljaCBpcyBuaWNl IHNpbmNlIGl0J2xsIGFsaWduIHVzIG1vcmUgd2l0aCBob3cgdGhlIGhlbHBlcnMgd29yay4KCkV4 Y2VwdCBmb3IgdGhlIHVnbGluZXNzIGluIHBhdGNoIDUsIGl0IHdhcyBwcmV0dHkgc3RyYWlnaHQg Zm9yd2FyZC4gQnV0IAp0aGF0IGNhbiBiZSBmaXhlZCBvbmNlIHdlIGhhdmUgYSBnbG9iYWwgc3Rh dGUgb2JqZWN0LgoKPiBTbyBvdmVyYWxsIEkgdGhpbmsgdGhpcyBwYXRjaCBzZXJpZXMgaXMgZ29v ZCB0byBnbyAoYnV0IEkndmUgZG9uZSBvbmx5IGEKPiByYXRoZXIgY3Vyc29yeSBoaWdoLWxldmVs IHJlYWRpbmcpLgoKRm9yIHNvbWUgcmVhc29uIFBSVFMgaWdub3JlZCB0aGlzIG9uZSAobWF5YmUg YmVjYXVzZSBpdCBpcyBhbiBSRkM/KSwgc28gCkkgc3VibWl0dGVkIGEgdGFzayBtYW51YWxseS4g SWYgdGhhdCBzdWNjZWVkcywgSSdsbCByZXNlbmQgd2l0aG91dCB0aGUgClJGQyBzdGF0dXMuCgpD aGVlcnMsCkFuZGVyCgo+Cj4gVGhhbmtzLCBEYW5pZWwKPgo+PiAtLS0KPj4gICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCA0NiArKysrKysrKy0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCAgICAgfCAg MSAtCj4+ICAgMiBmaWxlcyBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAzNyBkZWxldGlvbnMo LSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXku YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+PiBpbmRleCBhOWYzMDM0 Li5hMDMyYTFkIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNw bGF5LmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4+IEBA IC04NTgzLDcgKzg1ODMsNiBAQCByZXRyeToKPj4KPj4gICAJaW50ZWxfY3J0YyA9IHRvX2ludGVs X2NydGMoY3J0Yyk7Cj4+ICAgCWludGVsX2NydGMtPm5ld19lbmFibGVkID0gdHJ1ZTsKPj4gLQlp bnRlbF9jcnRjLT5uZXdfY29uZmlnID0gJmludGVsX2NydGMtPmNvbmZpZzsKPj4gICAJb2xkLT5k cG1zX21vZGUgPSBjb25uZWN0b3ItPmRwbXM7Cj4+ICAgCW9sZC0+bG9hZF9kZXRlY3RfdGVtcCA9 IHRydWU7Cj4+ICAgCW9sZC0+cmVsZWFzZV9mYiA9IE5VTEw7Cj4+IEBAIC04NjIzLDEwICs4NjIy LDYgQEAgcmV0cnk6Cj4+Cj4+ICAgIGZhaWw6Cj4+ICAgCWludGVsX2NydGMtPm5ld19lbmFibGVk ID0gY3J0Yy0+ZW5hYmxlZDsKPj4gLQlpZiAoaW50ZWxfY3J0Yy0+bmV3X2VuYWJsZWQpCj4+IC0J CWludGVsX2NydGMtPm5ld19jb25maWcgPSAmaW50ZWxfY3J0Yy0+Y29uZmlnOwo+PiAtCWVsc2UK Pj4gLQkJaW50ZWxfY3J0Yy0+bmV3X2NvbmZpZyA9IE5VTEw7Cj4+ICAgZmFpbF91bmxvY2s6Cj4+ ICAgCWlmIChyZXQgPT0gLUVERUFETEspIHsKPj4gICAJCWRybV9tb2Rlc2V0X2JhY2tvZmYoY3R4 KTsKPj4gQEAgLTg2NTMsNyArODY0OCw2IEBAIHZvaWQgaW50ZWxfcmVsZWFzZV9sb2FkX2RldGVj dF9waXBlKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4+ICAgCQl0b19pbnRlbF9j b25uZWN0b3IoY29ubmVjdG9yKS0+bmV3X2VuY29kZXIgPSBOVUxMOwo+PiAgIAkJaW50ZWxfZW5j b2Rlci0+bmV3X2NydGMgPSBOVUxMOwo+PiAgIAkJaW50ZWxfY3J0Yy0+bmV3X2VuYWJsZWQgPSBm YWxzZTsKPj4gLQkJaW50ZWxfY3J0Yy0+bmV3X2NvbmZpZyA9IE5VTEw7Cj4+ICAgCQlpbnRlbF9z ZXRfbW9kZShjcnRjLCBOVUxMLCAwLCAwLCBOVUxMKTsKPj4KPj4gICAJCWlmIChvbGQtPnJlbGVh c2VfZmIpIHsKPj4gQEAgLTk4MzksMTQgKzk4MzMsOCBAQCBzdGF0aWMgdm9pZCBpbnRlbF9tb2Rl c2V0X3VwZGF0ZV9zdGFnZWRfb3V0cHV0X3N0YXRlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4+ ICAgCQkJdG9faW50ZWxfY3J0YyhlbmNvZGVyLT5iYXNlLmNydGMpOwo+PiAgIAl9Cj4+Cj4+IC0J Zm9yX2VhY2hfaW50ZWxfY3J0YyhkZXYsIGNydGMpIHsKPj4gKwlmb3JfZWFjaF9pbnRlbF9jcnRj KGRldiwgY3J0YykKPj4gICAJCWNydGMtPm5ld19lbmFibGVkID0gY3J0Yy0+YmFzZS5lbmFibGVk Owo+PiAtCj4+IC0JCWlmIChjcnRjLT5uZXdfZW5hYmxlZCkKPj4gLQkJCWNydGMtPm5ld19jb25m aWcgPSAmY3J0Yy0+Y29uZmlnOwo+PiAtCQllbHNlCj4+IC0JCQljcnRjLT5uZXdfY29uZmlnID0g TlVMTDsKPj4gLQl9Cj4+ICAgfQo+Pgo+PiAgIC8qKgo+PiBAQCAtMTAzNTUsMTIgKzEwMzQzLDgg QEAgaW50ZWxfbW9kZXNldF91cGRhdGVfc3RhdGUoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdW5z aWduZWQgcHJlcGFyZV9waXBlcykKPj4gICAJaW50ZWxfbW9kZXNldF9jb21taXRfb3V0cHV0X3N0 YXRlKGRldik7Cj4+Cj4+ICAgCS8qIERvdWJsZSBjaGVjayBzdGF0ZS4gKi8KPj4gLQlmb3JfZWFj aF9pbnRlbF9jcnRjKGRldiwgaW50ZWxfY3J0Yykgewo+PiArCWZvcl9lYWNoX2ludGVsX2NydGMo ZGV2LCBpbnRlbF9jcnRjKQo+PiAgIAkJV0FSTl9PTihpbnRlbF9jcnRjLT5iYXNlLmVuYWJsZWQg IT0gaW50ZWxfY3J0Y19pbl91c2UoJmludGVsX2NydGMtPmJhc2UpKTsKPj4gLQkJV0FSTl9PTihp bnRlbF9jcnRjLT5uZXdfY29uZmlnICYmCj4+IC0JCQlpbnRlbF9jcnRjLT5uZXdfY29uZmlnICE9 ICZpbnRlbF9jcnRjLT5jb25maWcpOwo+PiAtCQlXQVJOX09OKGludGVsX2NydGMtPmJhc2UuZW5h YmxlZCAhPSAhIWludGVsX2NydGMtPm5ld19jb25maWcpOwo+PiAtCX0KPj4KPj4gICAJbGlzdF9m b3JfZWFjaF9lbnRyeShjb25uZWN0b3IsICZkZXYtPm1vZGVfY29uZmlnLmNvbm5lY3Rvcl9saXN0 LCBoZWFkKSB7Cj4+ICAgCQlpZiAoIWNvbm5lY3Rvci0+ZW5jb2RlciB8fCAhY29ubmVjdG9yLT5l bmNvZGVyLT5jcnRjKQo+PiBAQCAtMTA5NTcsOSArMTA5NDEsNiBAQCBzdGF0aWMgaW50IF9faW50 ZWxfc2V0X21vZGUoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+Pgo+PiAgIAkqc2F2ZWRfbW9kZSA9 IGNydGMtPm1vZGU7Cj4+Cj4+IC0JaWYgKG1vZGVzZXRfcGlwZXMpCj4+IC0JCXRvX2ludGVsX2Ny dGMoY3J0YyktPm5ld19jb25maWcgPSBwaXBlX2NvbmZpZzsKPj4gLQo+PiAgIAkvKgo+PiAgIAkg KiBTZWUgaWYgdGhlIGNvbmZpZyByZXF1aXJlcyBhbnkgYWRkaXRpb25hbCBwcmVwYXJhdGlvbiwg ZS5nLgo+PiAgIAkgKiB0byBhZGp1c3QgZ2xvYmFsIHN0YXRlIHdpdGggcGlwZXMgb2ZmLiAgV2Ug bmVlZCB0byBkbyB0aGlzCj4+IEBAIC0xMDk4NCw3ICsxMDk2NSwxMyBAQCBzdGF0aWMgaW50IF9f aW50ZWxfc2V0X21vZGUoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+PiAgIAkJCWdvdG8gZG9uZTsK Pj4KPj4gICAJCWZvcl9lYWNoX2ludGVsX2NydGNfbWFza2VkKGRldiwgbW9kZXNldF9waXBlcywg aW50ZWxfY3J0Yykgewo+PiAtCQkJc3RydWN0IGludGVsX2NydGNfc3RhdGUgKnN0YXRlID0gaW50 ZWxfY3J0Yy0+bmV3X2NvbmZpZzsKPj4gKwkJCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpzdGF0 ZTsKPj4gKwo+PiArCQkJaWYgKCZpbnRlbF9jcnRjLT5iYXNlID09IGNydGMpCj4+ICsJCQkJc3Rh dGUgPSBwaXBlX2NvbmZpZzsKPj4gKwkJCWVsc2UKPj4gKwkJCQlzdGF0ZSA9IGludGVsX2NydGMt PmNvbmZpZzsKPj4gKwo+PiAgIAkJCXJldCA9IGRldl9wcml2LT5kaXNwbGF5LmNydGNfY29tcHV0 ZV9jbG9jayhpbnRlbF9jcnRjLAo+PiAgIAkJCQkJCQkJICAgc3RhdGUpOwo+PiAgIAkJCWlmIChy ZXQpIHsKPj4gQEAgLTExMDE0LDcgKzExMDAxLDYgQEAgc3RhdGljIGludCBfX2ludGVsX3NldF9t b2RlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPj4gICAJCS8qIG1vZGVfc2V0L2VuYWJsZS9kaXNh YmxlIGZ1bmN0aW9ucyByZWx5IG9uIGEgY29ycmVjdCBwaXBlCj4+ICAgCQkgKiBjb25maWcuICov Cj4+ICAgCQl0b19pbnRlbF9jcnRjKGNydGMpLT5jb25maWcgPSAqcGlwZV9jb25maWc7Cj4+IC0J CXRvX2ludGVsX2NydGMoY3J0YyktPm5ld19jb25maWcgPSAmdG9faW50ZWxfY3J0YyhjcnRjKS0+ Y29uZmlnOwo+Pgo+PiAgIAkJLyoKPj4gICAJCSAqIENhbGN1bGF0ZSBhbmQgc3RvcmUgdmFyaW91 cyBjb25zdGFudHMgd2hpY2gKPj4gQEAgLTExMTc3LDE1ICsxMTE2Myw5IEBAIHN0YXRpYyB2b2lk IGludGVsX3NldF9jb25maWdfcmVzdG9yZV9zdGF0ZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ PiAgIAlpbnQgY291bnQ7Cj4+Cj4+ICAgCWNvdW50ID0gMDsKPj4gLQlmb3JfZWFjaF9pbnRlbF9j cnRjKGRldiwgY3J0Yykgewo+PiArCWZvcl9lYWNoX2ludGVsX2NydGMoZGV2LCBjcnRjKQo+PiAg IAkJY3J0Yy0+bmV3X2VuYWJsZWQgPSBjb25maWctPnNhdmVfY3J0Y19lbmFibGVkW2NvdW50Kytd Owo+Pgo+PiAtCQlpZiAoY3J0Yy0+bmV3X2VuYWJsZWQpCj4+IC0JCQljcnRjLT5uZXdfY29uZmln ID0gJmNydGMtPmNvbmZpZzsKPj4gLQkJZWxzZQo+PiAtCQkJY3J0Yy0+bmV3X2NvbmZpZyA9IE5V TEw7Cj4+IC0JfQo+PiAtCj4+ICAgCWNvdW50ID0gMDsKPj4gICAJZm9yX2VhY2hfaW50ZWxfZW5j b2RlcihkZXYsIGVuY29kZXIpIHsKPj4gICAJCWVuY29kZXItPm5ld19jcnRjID0KPj4gQEAgLTEx MzkxLDExICsxMTM3MSw2IEBAIGludGVsX21vZGVzZXRfc3RhZ2Vfb3V0cHV0X3N0YXRlKHN0cnVj dCBkcm1fZGV2aWNlICpkZXYsCj4+ICAgCQkJCSAgICAgIGNydGMtPm5ld19lbmFibGVkID8gImVu IiA6ICJkaXMiKTsKPj4gICAJCQljb25maWctPm1vZGVfY2hhbmdlZCA9IHRydWU7Cj4+ICAgCQl9 Cj4+IC0KPj4gLQkJaWYgKGNydGMtPm5ld19lbmFibGVkKQo+PiAtCQkJY3J0Yy0+bmV3X2NvbmZp ZyA9ICZjcnRjLT5jb25maWc7Cj4+IC0JCWVsc2UKPj4gLQkJCWNydGMtPm5ld19jb25maWcgPSBO VUxMOwo+PiAgIAl9Cj4+Cj4+ICAgCXJldHVybiAwOwo+PiBAQCAtMTE0MjIsNyArMTEzOTcsNiBA QCBzdGF0aWMgdm9pZCBkaXNhYmxlX2NydGNfbm9mYihzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykK Pj4gICAJfQo+Pgo+PiAgIAljcnRjLT5uZXdfZW5hYmxlZCA9IGZhbHNlOwo+PiAtCWNydGMtPm5l d19jb25maWcgPSBOVUxMOwo+PiAgIH0KPj4KPj4gICBzdGF0aWMgaW50IGludGVsX2NydGNfc2V0 X2NvbmZpZyhzdHJ1Y3QgZHJtX21vZGVfc2V0ICpzZXQpCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Ry di5oCj4+IGluZGV4IDBhODQ2NjcuLjE3NWI4NTMgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2Rydi5oCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Rydi5oCj4+IEBAIC00NDAsNyArNDQwLDYgQEAgc3RydWN0IGludGVsX2NydGMgewo+Pgo+PiAg IAlzdHJ1Y3QgaW50ZWxfcGxhbmVfY29uZmlnIHBsYW5lX2NvbmZpZzsKPj4gICAJc3RydWN0IGlu dGVsX2NydGNfc3RhdGUgY29uZmlnOwo+PiAtCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpuZXdf Y29uZmlnOwo+PiAgIAlib29sIG5ld19lbmFibGVkOwo+Pgo+PiAgIAkvKiByZXNldCBjb3VudGVy IHZhbHVlIHdoZW4gdGhlIGxhc3QgZmxpcCB3YXMgc3VibWl0dGVkICovCj4+IC0tCj4+IDEuOS4x Cj4+Cj4+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4+ IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y Zwo+PiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cj4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCklu dGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==