Re: [PATCH 1/8] drm/i915: Rebalance runtime pm vs forcewake

Chris Wilson
2014-12-12T16:45:29Z

On Fri, Dec 12, 2014 at 02:22:31PM -0200, Paulo Zanoni wrote:
> 2014-12-08 16:27 GMT-02:00 Mika Kuoppala <mika.kuoppala@linux.intel.com>:
> > From: Chris Wilson <chris@chris-wilson.co.uk>
> >
> > Calling intel_runtime_pm_put() is illegal from a soft-irq context, so
> > revert the crude hack
> >
> > commit aa0b3b5bb8768c1a6a6788869d9c7015eae7e80c
> > Author: Paulo Zanoni <paulo.r.zanoni@intel.com>
> > Date: Tue Apr 1 14:55:07 2014 -0300
> >
> > drm/i915: don't schedule force_wake_timer at gen6_read
> >
> > and apply the single line corrective instead.
> >
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=80913
> > Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> This patch adds tons and tons of new WARNs when running
> igt/tests/pm_rpm on BDW, including:
>
> WARNING: CPU: 1 PID: 228 at drivers/gpu/drm/i915/intel_uncore.c:623
> assert_force_wake_inactive+0x36/0x40 [i915]()
> WARN_ON(dev_priv->uncore.forcewake_count > 0)

The assert is in the incorrect place, it should be after the suspend
disables forcewake.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre