Re: [PATCH 8/8] drm/i915: Enum forcewake domains and domain identifiers

Daniel Vetter
2014-12-09T13:36:26Z

On Tue, Dec 09, 2014 at 03:32:05PM +0200, Jani Nikula wrote:
> On Tue, 09 Dec 2014, Mika Kuoppala <mika.kuoppala@linux.intel.com> wrote:
> > Make the domains and domain identifiers enums. To emphasize
> > the difference in order to avoid mistakes.
> >
> > Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_drv.h | 41 +++++++++++++++++----------------
> > drivers/gpu/drm/i915/intel_uncore.c | 45 +++++++++++++++++++------------------
> > 2 files changed, 45 insertions(+), 41 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> > index 0d47397..5c6c372 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.h
> > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > @@ -533,11 +533,28 @@ struct drm_i915_display_funcs {
> > void (*enable_backlight)(struct intel_connector *connector);
> > };
> >
> > +enum fw_domain_id {
>
> Does anyone else think of "firmware" first when seeing "fw", and
> "forcewake" only after a moment?

Hm yeah.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch