From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Infrastructure for supporting different GGTT views per object
Date: Mon, 15 Dec 2014 11:23:46 +0000 [thread overview]
Message-ID: <548EC4C2.8050107@linux.intel.com> (raw)
In-Reply-To: <20141215102426.GW27182@phenom.ffwll.local>
On 12/15/2014 10:24 AM, Daniel Vetter wrote:
> On Wed, Dec 10, 2014 at 05:27:58PM +0000, Tvrtko Ursulin wrote:
>> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
>> index de241eb..c6610bc 100644
>> --- a/drivers/gpu/drm/i915/i915_gem.c
>> +++ b/drivers/gpu/drm/i915/i915_gem.c
>> @@ -2098,8 +2098,7 @@ i915_gem_shrink(struct drm_i915_private *dev_priv,
>> /* For the unbound phase, this should be a no-op! */
>> list_for_each_entry_safe(vma, v,
>> &obj->vma_list, vma_link)
>> - if (i915_vma_unbind(vma))
>> - break;
>> + i915_vma_unbind(vma);
>
> This hunk adds a new warning. It's the 2nd time a __must_check warning
> from someone from vpg london crept through all the premerge testing. Can
> you please double-check whether you have some crazy gcc flags settings or
> something in your builders?
>
> I've dropped the hunk locally.
Yes sorry, somehow I've lost the relevant flag from Kconfig. Doesn't
matter for this hunk I suppose since it was in the air anyway.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-12-15 11:23 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 14:59 [PATCH 0/3] Multiple GGTT views Tvrtko Ursulin
2014-12-03 14:59 ` [PATCH 1/3] drm/i915: Stop putting GGTT VMA at the head of the list Tvrtko Ursulin
2014-12-04 9:48 ` Chris Wilson
2014-12-04 10:02 ` Tvrtko Ursulin
2014-12-04 10:17 ` Chris Wilson
2014-12-04 10:30 ` Tvrtko Ursulin
2014-12-04 10:39 ` Chris Wilson
2014-12-04 10:48 ` Tvrtko Ursulin
2014-12-04 10:54 ` Daniel Vetter
2014-12-03 14:59 ` [PATCH 2/3] drm/i915: Infrastructure for supporting different GGTT views per object Tvrtko Ursulin
2014-12-04 9:53 ` Chris Wilson
2014-12-04 10:19 ` Tvrtko Ursulin
2014-12-04 10:26 ` Chris Wilson
2014-12-04 10:59 ` Daniel Vetter
2014-12-04 12:17 ` Tvrtko Ursulin
2014-12-04 12:27 ` Chris Wilson
2014-12-04 13:01 ` Daniel Vetter
2014-12-03 14:59 ` [PATCH 3/3] drm/i915: Documentation for multiple GGTT views Tvrtko Ursulin
2014-12-04 7:12 ` shuang.he
2014-12-05 12:11 ` [PATCH v2 0/2] Multiple " Tvrtko Ursulin
2014-12-05 12:11 ` [PATCH 1/2] drm/i915: Infrastructure for supporting different GGTT views per object Tvrtko Ursulin
2014-12-05 14:25 ` Daniel Vetter
2014-12-09 15:23 ` Michel Thierry
2014-12-10 9:16 ` Daniel Vetter
2014-12-10 10:17 ` Tvrtko Ursulin
2014-12-05 12:11 ` [PATCH 2/2] drm/i915: Documentation for multiple GGTT views Tvrtko Ursulin
2014-12-09 15:41 ` Michel Thierry
2014-12-10 17:27 ` [PATCH v3 0/2] Multiple " Tvrtko Ursulin
2014-12-10 17:27 ` [PATCH 1/2] drm/i915: Infrastructure for supporting different GGTT views per object Tvrtko Ursulin
2014-12-11 10:18 ` Michel Thierry
2014-12-15 10:24 ` Daniel Vetter
2014-12-15 11:23 ` Tvrtko Ursulin [this message]
2014-12-10 17:27 ` [PATCH 2/2] drm/i915: Documentation for multiple GGTT views Tvrtko Ursulin
2014-12-11 3:41 ` shuang.he
2014-12-11 10:19 ` Michel Thierry
2014-12-15 8:30 ` Daniel Vetter
2014-12-15 10:01 ` Michel Thierry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548EC4C2.8050107@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox