From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michel Thierry Subject: Re: [PATCH] drm/i915: Use true PPGTT in Gen8 if execlists are enabled Date: Mon, 15 Dec 2014 14:49:13 +0000 Message-ID: <548EF4E9.2080106@intel.com> References: <1418299638-16927-1-git-send-email-michel.thierry@intel.com> <20141215101114.GS27182@phenom.ffwll.local> <548ED852.6030108@intel.com> <20141215142208.GA27182@phenom.ffwll.local> <20141215142809.GC27182@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1960230703==" Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 84DE46E548 for ; Mon, 15 Dec 2014 06:49:42 -0800 (PST) In-Reply-To: <20141215142809.GC27182@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org This is a cryptographically signed message in MIME format. --===============1960230703== Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha1; boundary="------------ms010602060906060408030303" This is a cryptographically signed message in MIME format. --------------ms010602060906060408030303 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: quoted-printable On 12/15/2014 2:28 PM, Daniel Vetter wrote: > On Mon, Dec 15, 2014 at 03:22:08PM +0100, Daniel Vetter wrote: >> On Mon, Dec 15, 2014 at 12:47:14PM +0000, Michel Thierry wrote: >>> On 12/15/2014 10:11 AM, Daniel Vetter wrote: >>>> On Thu, Dec 11, 2014 at 12:07:18PM +0000, Michel Thierry wrote: >>>>> When execlists submission is enabled, try full ppgtt by default. >>>>> >>>>> Note, this patch considers that execlist support has been enabled b= y >>>>> default on Gen8. >>>>> >>>>> Signed-off-by: Michel Thierry >>>>> --- >>>>> drivers/gpu/drm/i915/i915_gem_gtt.c | 9 ++++++--- >>>>> 1 file changed, 6 insertions(+), 3 deletions(-) >>>>> >>>>> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/= i915/i915_gem_gtt.c >>>>> index 171f6ea..4ed3904 100644 >>>>> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c >>>>> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c >>>>> @@ -40,8 +40,8 @@ static int sanitize_enable_ppgtt(struct drm_devic= e *dev, int enable_ppgtt) >>>>> has_aliasing_ppgtt =3D INTEL_INFO(dev)->gen >=3D 6; >>>>> has_full_ppgtt =3D INTEL_INFO(dev)->gen >=3D 7; >>>>> - if (IS_GEN8(dev)) >>>>> - has_full_ppgtt =3D false; /* XXX why? */ >>>>> + if (IS_GEN8(dev) && !i915.enable_execlists) >>>>> + has_full_ppgtt =3D false; /* Only enforce with execlists */ >>>> Imo this has outlived it's usefulness - enable_ppgtt is an unsafe >>>> parameter so everyone setting it themselves gets what they need. >>>> Afair this was just because of the execlist depency on gen8 for ppgt= t. >>>> -Daniel >>> Not sure if I'm following you up on this... >>> The aim was to change the default value to _full_ only when execlists= are >>> also enable (after Thomas' patch). In gen8, we don't want to have fu= ll >>> ppgtt with legacy ring submission. >> Yeah I gotten confused. The comment is a bit misleading thought, maybe= >> "Full ppgtt needs execlist since otherwise the ctx switch can hang"? > Actually I wasnt' confused: gen8+ has full ppgtt, like gen7. It's broke= n > without execlist though, so what we should do is just change the defaul= t > below. Otherwise if a user explicitly sets execlist=3D0 and ppgtt=3D2 w= e won't > obey that, which doesn't make sense - for isolating bugs this might be = a > valid testcase (even when we know there's problems). So your patch shou= ld > do two things: > - Generally allow full ppgtt on gen8 - the current restriction doesn't > make sense. > - Switch the default to full ppgtt when execlist is enabled on gen8+, l= eave > the default to aliasing/disabled everywhere else as is. > -Daniel Thanks for clarifying. I'll send a new patch. -Michel --------------ms010602060906060408030303 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIRkjCC BOswggPToAMCAQICEFLpAsoR6ESdlGU4L6MaMLswDQYJKoZIhvcNAQEFBQAwbzELMAkGA1UE BhMCU0UxFDASBgNVBAoTC0FkZFRydXN0IEFCMSYwJAYDVQQLEx1BZGRUcnVzdCBFeHRlcm5h bCBUVFAgTmV0d29yazEiMCAGA1UEAxMZQWRkVHJ1c3QgRXh0ZXJuYWwgQ0EgUm9vdDAeFw0x MzAzMTkwMDAwMDBaFw0yMDA1MzAxMDQ4MzhaMHkxCzAJBgNVBAYTAlVTMQswCQYDVQQIEwJD QTEUMBIGA1UEBxMLU2FudGEgQ2xhcmExGjAYBgNVBAoTEUludGVsIENvcnBvcmF0aW9uMSsw KQYDVQQDEyJJbnRlbCBFeHRlcm5hbCBCYXNpYyBJc3N1aW5nIENBIDRBMIIBIjANBgkqhkiG 9w0BAQEFAAOCAQ8AMIIBCgKCAQEA4LDMgJ3YSVX6A9sE+jjH3b+F3Xa86z3LLKu/6WvjIdvU bxnoz2qnvl9UKQI3sE1zURQxrfgvtP0bPgt1uDwAfLc6H5eqnyi+7FrPsTGCR4gwDmq1WkTQ gNDNXUgb71e9/6sfq+WfCDpi8ScaglyLCRp7ph/V60cbitBvnZFelKCDBh332S6KG3bAdnNG B/vk86bwDlY6omDs6/RsfNwzQVwo/M3oPrux6y6zyIoRulfkVENbM0/9RrzQOlyK4W5Vk4EE sfW2jlCV4W83QKqRccAKIUxw2q/HoHVPbbETrrLmE6RRZ/+eWlkGWl+mtx42HOgOmX0BRdTR o9vH7yeBowIDAQABo4IBdzCCAXMwHwYDVR0jBBgwFoAUrb2YejS0Jvf6xCZU7wO94CTLVBow HQYDVR0OBBYEFB5pKrTcKP5HGE4hCz+8rBEv8Jj1MA4GA1UdDwEB/wQEAwIBhjASBgNVHRMB Af8ECDAGAQH/AgEAMDYGA1UdJQQvMC0GCCsGAQUFBwMEBgorBgEEAYI3CgMEBgorBgEEAYI3 CgMMBgkrBgEEAYI3FQUwFwYDVR0gBBAwDjAMBgoqhkiG+E0BBQFpMEkGA1UdHwRCMEAwPqA8 oDqGOGh0dHA6Ly9jcmwudHJ1c3QtcHJvdmlkZXIuY29tL0FkZFRydXN0RXh0ZXJuYWxDQVJv b3QuY3JsMDoGCCsGAQUFBwEBBC4wLDAqBggrBgEFBQcwAYYeaHR0cDovL29jc3AudHJ1c3Qt cHJvdmlkZXIuY29tMDUGA1UdHgQuMCygKjALgQlpbnRlbC5jb20wG6AZBgorBgEEAYI3FAID oAsMCWludGVsLmNvbTANBgkqhkiG9w0BAQUFAAOCAQEAKcLNo/2So1Jnoi8G7W5Q6FSPq1fm yKW3sSDf1amvyHkjEgd25n7MKRHGEmRxxoziPKpcmbfXYU+J0g560nCo5gPF78Wd7ZmzcmCc m1UFFfIxfw6QA19bRpTC8bMMaSSEl8y39Pgwa+HENmoPZsM63DdZ6ziDnPqcSbcfYs8qd/m5 d22rpXq5IGVUtX6LX7R/hSSw/3sfATnBLgiJtilVyY7OGGmYKCAS2I04itvSS1WtecXTt9OZ DyNbl7LtObBrgMLhZkpJW+pOR9f3h5VG2S5uKkA7Th9NC9EoScdwQCAIw+UWKbSQ0Isj2UFL 7fHKvmqWKVTL98sRzvI3seNC4DCCBiowggUSoAMCAQICChZNwGIAAAAAT+swDQYJKoZIhvcN AQEFBQAweTELMAkGA1UEBhMCVVMxCzAJBgNVBAgTAkNBMRQwEgYDVQQHEwtTYW50YSBDbGFy YTEaMBgGA1UEChMRSW50ZWwgQ29ycG9yYXRpb24xKzApBgNVBAMTIkludGVsIEV4dGVybmFs IEJhc2ljIElzc3VpbmcgQ0EgNEEwHhcNMTQwNDI4MTIyMzQ3WhcNMTcwNDEyMTIyMzQ3WjBD MRgwFgYDVQQDEw9UaGllcnJ5LCBNaWNoZWwxJzAlBgkqhkiG9w0BCQEWGG1pY2hlbC50aGll cnJ5QGludGVsLmNvbTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAKuvwFQqpb2d bD6xItCPUz74nZG7NRczIbUcL8TFaJXQPU+wJhpZBXYhTv+Qme/ZgAlIF/caUKQZ0uYGcYVY yf7dPp+lShl6+CYqz/NDvSb28jxvMgK/3MLQaVQP/82V7nYbe/2JPpAXJVDW/PQk6j+I/tgK zAIxbr1IZB91KecP3p3ksnKuohDkJA4FEK/f9LWo18lSa92yYDhJ6kEV90a2VPA4l6UYngGs OYhVAAsRoba+ROSiuVG5yDyrKwrAhAXdSbpIH1KO91MsCNlUPEtKdunnSL6eoFXfe9cA9+iZ qrvddLWCmDkjsqCsXrBJs87gE8lj733wU+rUiIPnq08CAwEAAaOCAugwggLkMAsGA1UdDwQE AwIHgDA8BgkrBgEEAYI3FQcELzAtBiUrBgEEAYI3FQiGw4x1hJnlUYP9gSiFjp9TgpHACWeB 3r05lfBDAgFkAgEIMB0GA1UdDgQWBBRFUVbAqJvKLf4iKYvg6Gx6sRNhZjAfBgNVHSMEGDAW gBQeaSq03Cj+RxhOIQs/vKwRL/CY9TCByQYDVR0fBIHBMIG+MIG7oIG4oIG1hlRodHRwOi8v d3d3LmludGVsLmNvbS9yZXBvc2l0b3J5L0NSTC9JbnRlbCUyMEV4dGVybmFsJTIwQmFzaWMl MjBJc3N1aW5nJTIwQ0ElMjA0QS5jcmyGXWh0dHA6Ly9jZXJ0aWZpY2F0ZXMuaW50ZWwuY29t L3JlcG9zaXRvcnkvQ1JML0ludGVsJTIwRXh0ZXJuYWwlMjBCYXNpYyUyMElzc3VpbmclMjBD QSUyMDRBLmNybDCB7wYIKwYBBQUHAQEEgeIwgd8waQYIKwYBBQUHMAKGXWh0dHA6Ly93d3cu aW50ZWwuY29tL3JlcG9zaXRvcnkvY2VydGlmaWNhdGVzL0ludGVsJTIwRXh0ZXJuYWwlMjBC YXNpYyUyMElzc3VpbmclMjBDQSUyMDRBLmNydDByBggrBgEFBQcwAoZmaHR0cDovL2NlcnRp ZmljYXRlcy5pbnRlbC5jb20vcmVwb3NpdG9yeS9jZXJ0aWZpY2F0ZXMvSW50ZWwlMjBFeHRl cm5hbCUyMEJhc2ljJTIwSXNzdWluZyUyMENBJTIwNEEuY3J0MB8GA1UdJQQYMBYGCCsGAQUF BwMEBgorBgEEAYI3CgMMMCkGCSsGAQQBgjcVCgQcMBowCgYIKwYBBQUHAwQwDAYKKwYBBAGC NwoDDDBNBgNVHREERjBEoCgGCisGAQQBgjcUAgOgGgwYbWljaGVsLnRoaWVycnlAaW50ZWwu Y29tgRhtaWNoZWwudGhpZXJyeUBpbnRlbC5jb20wDQYJKoZIhvcNAQEFBQADggEBAMYpBdhi VzoxuD58VMj2xc6Zsz7cg0Bpiji7sfDrhswhYwWogsBukXFwhukKmSqRIwvdSIoWfBDA4kIS qvgrMTYPtDl59awxdvn+jWx/P0APyC3tBg4z+1u0waM3smppq5/8f8Hew2S0IWP7tIJeQ+NY IE+iX5NclbuK4mFNJa74Rw7uaWBY+4zBNDaaaCgosmPfP5sBQnJzYL0jnNJTWXZP74JUPj/7 9SXg+C0dSORUqkkIsCy0jPGzT3ypk75JJ80znb0uoO4kgW2hO7dAAEe1GkONG4Ab1Bsk4zJl 1FaFkOf5aAepzm4rwnVtRMpaL8rjce3VOfpCvcIg+WDFXUAwggZxMIIFWaADAgECAgoWTN75 AAAAAE/qMA0GCSqGSIb3DQEBBQUAMHkxCzAJBgNVBAYTAlVTMQswCQYDVQQIEwJDQTEUMBIG A1UEBxMLU2FudGEgQ2xhcmExGjAYBgNVBAoTEUludGVsIENvcnBvcmF0aW9uMSswKQYDVQQD EyJJbnRlbCBFeHRlcm5hbCBCYXNpYyBJc3N1aW5nIENBIDRBMB4XDTE0MDQyODEyMjI0OVoX DTE3MDQxMjEyMjI0OVowQzEYMBYGA1UEAxMPVGhpZXJyeSwgTWljaGVsMScwJQYJKoZIhvcN AQkBFhhtaWNoZWwudGhpZXJyeUBpbnRlbC5jb20wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAw ggEKAoIBAQDECX/a/YWv0J8ABUwU61b73w7YCBE18G1fMdlsadEZUpg0BbpMOu0rx68iUq9x zU575ggweIlkt/qBGnGZvDVP8Iit5hFLmtlPnds0OelpjzE1o9nsgdrGEoT2BgjoTja+yLnv wDldEPqAszih/nCQcqtyH4vEmmnBxsUwMR7oD9U+U8sRLmpqbE1g0OGEh+X5zLrdNBEMZAGu iE2VeqvgS3poayRiJ2nc43ufMDtDlUnozq2H7+CRXU6yFsprpVTx29YHIrJLZxp+rBOlNQAy 8Ba5zyKq/lRRs79YLH8qzCdZJS7PfLpgBn8B8vl+Kp9iMMKdxhIMms46S+Grv+7FAgMBAAGj ggMvMIIDKzALBgNVHQ8EBAMCBDAwPQYJKwYBBAGCNxUHBDAwLgYmKwYBBAGCNxUIhsOMdYSZ 5VGD/YEohY6fU4KRwAlnhLnZQYeE/04CAWQCAQ0wRAYJKoZIhvcNAQkPBDcwNTAOBggqhkiG 9w0DAgICAIAwDgYIKoZIhvcNAwQCAgCAMAcGBSsOAwIHMAoGCCqGSIb3DQMHMB0GA1UdDgQW BBRBzUHVb22UOyhMUTmF2b9/Rh7RMTAfBgNVHSMEGDAWgBQeaSq03Cj+RxhOIQs/vKwRL/CY 9TCByQYDVR0fBIHBMIG+MIG7oIG4oIG1hlRodHRwOi8vd3d3LmludGVsLmNvbS9yZXBvc2l0 b3J5L0NSTC9JbnRlbCUyMEV4dGVybmFsJTIwQmFzaWMlMjBJc3N1aW5nJTIwQ0ElMjA0QS5j cmyGXWh0dHA6Ly9jZXJ0aWZpY2F0ZXMuaW50ZWwuY29tL3JlcG9zaXRvcnkvQ1JML0ludGVs JTIwRXh0ZXJuYWwlMjBCYXNpYyUyMElzc3VpbmclMjBDQSUyMDRBLmNybDCB7wYIKwYBBQUH AQEEgeIwgd8waQYIKwYBBQUHMAKGXWh0dHA6Ly93d3cuaW50ZWwuY29tL3JlcG9zaXRvcnkv Y2VydGlmaWNhdGVzL0ludGVsJTIwRXh0ZXJuYWwlMjBCYXNpYyUyMElzc3VpbmclMjBDQSUy MDRBLmNydDByBggrBgEFBQcwAoZmaHR0cDovL2NlcnRpZmljYXRlcy5pbnRlbC5jb20vcmVw b3NpdG9yeS9jZXJ0aWZpY2F0ZXMvSW50ZWwlMjBFeHRlcm5hbCUyMEJhc2ljJTIwSXNzdWlu ZyUyMENBJTIwNEEuY3J0MB8GA1UdJQQYMBYGCCsGAQUFBwMEBgorBgEEAYI3CgMEMCkGCSsG AQQBgjcVCgQcMBowCgYIKwYBBQUHAwQwDAYKKwYBBAGCNwoDBDBNBgNVHREERjBEoCgGCisG AQQBgjcUAgOgGgwYbWljaGVsLnRoaWVycnlAaW50ZWwuY29tgRhtaWNoZWwudGhpZXJyeUBp bnRlbC5jb20wDQYJKoZIhvcNAQEFBQADggEBAGrtUHqoTWHttQxVewb/Uv6uL0YnPOVyFZs2 UKlnDV8zoUf4enk4FBIOKEqZIZ1Ektx5P1BaIHGfCVBP0Y4FIo2Twi4VHuWzkmECEKvjaur1 YTcuUHT3xQMsRS2CgUb2ttxGr381zG4CDKM9esAv0lDPzH+KgWhK1U+/gpq04AzLOQUHi5cP 1ZCINbo8AnunzRKhzegbQ6nr7frQlCUlrLMstzquhI0t8QjdFO3GKAjXF3wJf3aKnYNeFAWE xwLkdjM+TevhMpiNeBRJoEeUcGRRhe0YlhIoiryD5sZIeWGPBAhwOpZFGRdlXAcfbpwQ3K7a we2yqKeiU606TCcfppgxggO2MIIDsgIBATCBhzB5MQswCQYDVQQGEwJVUzELMAkGA1UECBMC Q0ExFDASBgNVBAcTC1NhbnRhIENsYXJhMRowGAYDVQQKExFJbnRlbCBDb3Jwb3JhdGlvbjEr MCkGA1UEAxMiSW50ZWwgRXh0ZXJuYWwgQmFzaWMgSXNzdWluZyBDQSA0QQIKFk3AYgAAAABP 6zAJBgUrDgMCGgUAoIICAzAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJ BTEPFw0xNDEyMTUxNDQ5MTNaMCMGCSqGSIb3DQEJBDEWBBSBgj62+8IEJuitga3fLikrlZfe cjBsBgkqhkiG9w0BCQ8xXzBdMAsGCWCGSAFlAwQBKjALBglghkgBZQMEAQIwCgYIKoZIhvcN AwcwDgYIKoZIhvcNAwICAgCAMA0GCCqGSIb3DQMCAgFAMAcGBSsOAwIHMA0GCCqGSIb3DQMC AgEoMIGYBgkrBgEEAYI3EAQxgYowgYcweTELMAkGA1UEBhMCVVMxCzAJBgNVBAgTAkNBMRQw EgYDVQQHEwtTYW50YSBDbGFyYTEaMBgGA1UEChMRSW50ZWwgQ29ycG9yYXRpb24xKzApBgNV BAMTIkludGVsIEV4dGVybmFsIEJhc2ljIElzc3VpbmcgQ0EgNEECChZM3vkAAAAAT+owgZoG CyqGSIb3DQEJEAILMYGKoIGHMHkxCzAJBgNVBAYTAlVTMQswCQYDVQQIEwJDQTEUMBIGA1UE BxMLU2FudGEgQ2xhcmExGjAYBgNVBAoTEUludGVsIENvcnBvcmF0aW9uMSswKQYDVQQDEyJJ bnRlbCBFeHRlcm5hbCBCYXNpYyBJc3N1aW5nIENBIDRBAgoWTN75AAAAAE/qMA0GCSqGSIb3 DQEBAQUABIIBAGtgthP0MZmoOPYBkvosq/FI/nsmmELaKKCs6QgOKDZRMDPBIAgkkv4Av50i JXO6Ful1YfCS5I9mMEdEce5YAIYPSuFLOLSsbs4blQ5Td3/SzfpKQV6Ce6Sihvp8e5niNnOB xAqoK/PW/+4YYHp3OjvM9Dk7uxyh1JjiqPdj022KBhUbyiW6UHC+3vsZCi2YYm8oKU2XQD1m kcFLMLkO20EWdl60UCbs1qr8/oCjrMmuVgbZbEcg6CFuLw5LbcjwuGA8h5S2O4izepGH3mPb q38VPX6D8k0rHRTO2uITxJ7JD/YZzgL43wdoo7MmjoZRY1kSd7fTCV+YNEPxlmLGQesAAAAA AAA= --------------ms010602060906060408030303-- --===============1960230703== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK --===============1960230703==--