public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: nick <xerofoify@gmail.com>
To: daniel.vetter@intel.com
Cc: airlied@linux.ie, intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: XXX comments in i915_reg.h
Date: Sat, 03 Jan 2015 00:21:55 -0500	[thread overview]
Message-ID: <54A77C73.8030704@gmail.com> (raw)

Greetings Daniel and others,
I am wondering about these XXX comments:
#define TV_V_CTL_1              0x6803c
/* XXX */
# define TV_NBR_END_SHIFT               16
# define TV_NBR_END_MASK                0x07ff0000
/* XXX */
# define TV_VI_END_F1_SHIFT             8
# define TV_VI_END_F1_MASK              0x00003f00
/* XXX */
# define TV_VI_END_F2_SHIFT             0
# define TV_VI_END_F2_MASK              0x0000003f
These seems to be no comments about why these are not
fixed or needed, I am going to remove these comments
unless one of the maintainers can send me a reason as
to a valid reason for them being there.
Regards,
Nick
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

                 reply	other threads:[~2015-01-03  5:21 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54A77C73.8030704@gmail.com \
    --to=xerofoify@gmail.com \
    --cc=airlied@linux.ie \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox