From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH] drm/i915: cleanup lrc engine state when lrc is freed Date: Fri, 09 Jan 2015 18:47:41 +0000 Message-ID: <54B0224D.2050407@intel.com> References: <1420724407-11767-1-git-send-email-mika.kuoppala@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id F0A786E943 for ; Fri, 9 Jan 2015 10:49:22 -0800 (PST) In-Reply-To: <1420724407-11767-1-git-send-email-mika.kuoppala@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mika Kuoppala , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMDgvMDEvMTUgMTM6NDAsIE1pa2EgS3VvcHBhbGEgd3JvdGU6Cj4gaTkxNV9nZW1fdmFsaWRh dGVfY29udGV4dCgpIHdpbGwgY2hlY2sgdGhlIGVuZ2luZS0+c3RhdGUgdG8gc2VlIGlmIGl0IGNh bgo+IHN1Ym1pdCBpbnRvIGEgcmluZ2J1ZmZlci4gQnV0IHdoZW4gd2UgYXJlIHJlbGVhc2luZyB0 aGUgY29udGV4dCB3ZSBsZWF2ZSB0aGUKPiBlbmdpbmUgc3RhdGUgdG8gYSBub24gbnVsbCB2YWx1 ZS4gVGh1cyBhZnRlciBhIHN1Y2Nlc3NmdWwgaGFuZyByZWNvdmVyeQo+IHdlIG1pZ2h0IG1pc3Rh a2VubHkgc3VibWl0IHRvIGEgbm9uIGluaXRpYWxpemVkIHJpbmdidWZmZXIgcmVzdWx0aW5nIGlu Ogo+IAo+IFsgMTk5MS4zNTY0MThdIC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0t LQo+IFsgMTk5MS4zNTkxOTJdIFdBUk5JTkc6IENQVTogMSBQSUQ6IDIzMzUgYXQgbGliL2lvbWFw LmM6NDMgYmFkX2lvX2FjY2VzcysweDNkLzB4NDAoKQo+IFsgMTk5MS4zNjE5NjZdIEJhZCBJTyBh Y2Nlc3MgYXQgcG9ydCAweDI0IChvdXRsKHZhbCxwb3J0KSkKPiBbIDE5OTEuMzY0NzUwXSBNb2R1 bGVzIGxpbmtlZCBpbjogc25kX2hkYV9jb2RlY19oZG1pIGk5MTUgeDg2X3BrZ190ZW1wX3RoZXJt YWwgY29yZXRlbXAga3ZtX2ludGVsIGt2bSBzbmRfaGRhX2ludGVsIHNuZF9oZGFfY29udHJvbGxl ciBzbmRfaGRhX2NvZGVjIGNyY3QxMGRpZl9wY2xtdWwgY3JjMzJfcGNsbXVsIGdoYXNoX2NsbXVs bmlfaW50ZWwgc25kX2h3ZGVwIHNuZF9wY20gYWVzbmlfaW50ZWwgYWVzX3g4Nl82NCBnbHVlX2hl bHBlciBscncgaTJjX2FsZ29fYml0IGdmMTI4bXVsIGFibGtfaGVscGVyIGRybV9rbXNfaGVscGVy IGNyeXB0ZCBzbmRfc2VxX21pZGkgc25kX3NlcV9taWRpX2V2ZW50IHNlcmlvX3JhdyBkcm0gc25k X3Jhd21pZGkgc25kX3NlcSBzbmRfc2VxX2RldmljZSBzbmRfdGltZXIgdmlkZW8gc25kIHNvdW5k Y29yZSBtZWlfbWUgbHBjX2ljaCBibmVwIG1hY19oaWQgYWNwaV9wYWQgbWVpIHJmY29tbSBibHVl dG9vdGggcGFycG9ydF9wYyBwcGRldiBscCBwYXJwb3J0IG5sc19pc284ODU5XzEgZTEwMDBlIHB0 cCBhaGNpIGxpYmFoY2kgcHBzX2NvcmUgc2RoY2lfYWNwaSBzZGhjaQo+IFsgMTk5MS4zNzA4Mjdd IENQVTogMSBQSUQ6IDIzMzUgQ29tbTogZ2VtX3JpbmdmaWxsIFRhaW50ZWQ6IEcgICAgICAgIFcg ICAgICAzLjE5LjAtcmMzKyAjNTAKPiBbIDE5OTEuMzczODM4XSBIYXJkd2FyZSBuYW1lOiBJbnRl bCBDb3Jwb3JhdGlvbiBCcm9hZHdlbGwgQ2xpZW50IHBsYXRmb3JtL1Nhd1Rvb3RoIFBlYWssIEJJ T1MgQkRXLUUxUjEuODZDLjAwOTIuUjAwLjE0MDgzMTE5NDIgMDgvMzEvMjAxNAo+IFsgMTk5MS4z NzY5MDJdICBmZmZmZmZmZjgxYWExYTQ2IGZmZmY4ODAxNDkxMGZhYzggZmZmZmZmZmY4MTczZGJj ZiAwMDAwMDAwMDAwMDAwMDAxCj4gWyAxOTkxLjM3OTk3OF0gIGZmZmY4ODAxNDkxMGZiMTggZmZm Zjg4MDE0OTEwZmIwOCBmZmZmZmZmZjgxMDcwMDdhIGZmZmY4ODAxNDkxMGZiMjgKPiBbIDE5OTEu MzgzMDM3XSAgZmZmZjg4MDE0NzIwOTk0MCBmZmZmODgwMGFhZmE4NzE4IGZmZmY4ODAwYWFmYTAw MDAgZmZmZjg4MDBhYWZhMTkxOAo+IFsgMTk5MS4zODYwOTRdIENhbGwgVHJhY2U6Cj4gWyAxOTkx LjM4OTE0MF0gIFs8ZmZmZmZmZmY4MTczZGJjZj5dIGR1bXBfc3RhY2srMHg0NS8weDU3Cj4gWyAx OTkxLjM5MjIwN10gIFs8ZmZmZmZmZmY4MTA3MDA3YT5dIHdhcm5fc2xvd3BhdGhfY29tbW9uKzB4 OGEvMHhjMAo+IFsgMTk5MS4zOTUyNjhdICBbPGZmZmZmZmZmODEwNzAwZjY+XSB3YXJuX3Nsb3dw YXRoX2ZtdCsweDQ2LzB4NTAKPiBbIDE5OTEuMzk4MzMwXSAgWzxmZmZmZmZmZmEwNTMyOTBjPl0g PyBpbnRlbF9sb2dpY2FsX3JpbmdfYmVnaW4rMHgzYy8weDI0MCBbaTkxNV0KPiBbIDE5OTEuNDAx Mzk1XSAgWzxmZmZmZmZmZjgxMzk4NWJkPl0gYmFkX2lvX2FjY2VzcysweDNkLzB4NDAKPiBbIDE5 OTEuNDA0NDYyXSAgWzxmZmZmZmZmZjgxMzk4NzYzPl0gaW93cml0ZTMyKzB4MzMvMHg0MAo+IFsg MTk5MS40MDc1MjldICBbPGZmZmZmZmZmYTA1MzM1ODU+XSBnZW44X2luaXRfcmNzX2NvbnRleHQr MHhkNS8weDE3MCBbaTkxNV0KPiBbIDE5OTEuNDEwNjA1XSAgWzxmZmZmZmZmZmEwNTMzZDE3Pl0g aW50ZWxfbHJfY29udGV4dF9kZWZlcnJlZF9jcmVhdGUrMHg2NTcvMHg4ZTAgW2k5MTVdCj4gWyAx OTkxLjQxMzY2OF0gIFs8ZmZmZmZmZmZhMDUwZWZmMT5dIGk5MTVfZ2VtX2RvX2V4ZWNidWZmZXIu aXNyYS4yMisweGVkMS8weGY2MCBbaTkxNV0KPiBbIDE5OTEuNDE2NzM2XSAgWzxmZmZmZmZmZjgx MWMwMTI1Pl0gPyBfX2ttYWxsb2MrMHg1NS8weDFiMAo+IFsgMTk5MS40MTk4MDFdICBbPGZmZmZm ZmZmYTA1MTAyOWM+XSA/IGk5MTVfZ2VtX2V4ZWNidWZmZXIyKzB4NmMvMHgyYzAgW2k5MTVdCj4g WyAxOTkxLjQyMjc3Ml0gIFs8ZmZmZmZmZmZhMDUxMDJlMT5dIGk5MTVfZ2VtX2V4ZWNidWZmZXIy KzB4YjEvMHgyYzAgW2k5MTVdCj4gWyAxOTkxLjQyNTYzMl0gIFs8ZmZmZmZmZmZhMDFiOGFiND5d IGRybV9pb2N0bCsweDFhNC8weDYzMCBbZHJtXQo+IFsgMTk5MS40Mjg0NTRdICBbPGZmZmZmZmZm ODExMjU4YmM+XSA/IGFjY3RfYWNjb3VudF9jcHV0aW1lKzB4MWMvMHgyMAo+IFsgMTk5MS40MzEy NTVdICBbPGZmZmZmZmZmODExZWUzNzg+XSBkb192ZnNfaW9jdGwrMHgyZjgvMHg1MTAKPiBbIDE5 OTEuNDM0MDA5XSAgWzxmZmZmZmZmZjgxMDlmODM0Pl0gPyB2dGltZV9hY2NvdW50X3VzZXIrMHg1 NC8weDYwCj4gWyAxOTkxLjQzNjc3OF0gIFs8ZmZmZmZmZmY4MTFlZTYxMT5dIFN5U19pb2N0bCsw eDgxLzB4YTAKPiBbIDE5OTEuNDM5NTUzXSAgWzxmZmZmZmZmZjgxNzQ1Y2I0Pl0gPyBpbnRfY2hl Y2tfc3lzY2FsbF9leGl0X3dvcmsrMHgzNC8weDNkCj4gWyAxOTkxLjQ0MjMwNl0gIFs8ZmZmZmZm ZmY4MTc0NWEyZD5dIHN5c3RlbV9jYWxsX2Zhc3RwYXRoKzB4MTYvMHgxYgo+IAo+IEZpeCB0aGlz IGJ5IHNldHRpbmcgYWxsIHRoZSBlbmdpbmUgZmllbGRzIHByb3Blcmx5IHdoZW4gbHJjIGlzIGZy ZWVkLgo+IAo+IENjOiBUaG9tYXMgRGFuaWVsIDx0aG9tYXMuZGFuaWVsQGludGVsLmNvbT4KPiBT aWduZWQtb2ZmLWJ5OiBNaWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGludGVsLmNvbT4KPiAt LS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMgfCA0ICsrKysKPiAgMSBmaWxl IGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9scmMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4g aW5kZXggNzY3MGEwZi4uMzI2ODRkOSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9scmMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4g QEAgLTE3NzcsNiArMTc3NywxMCBAQCB2b2lkIGludGVsX2xyX2NvbnRleHRfZnJlZShzdHJ1Y3Qg aW50ZWxfY29udGV4dCAqY3R4KQo+ICAJCQlpbnRlbF9kZXN0cm95X3JpbmdidWZmZXJfb2JqKHJp bmdidWYpOwo+ICAJCQlrZnJlZShyaW5nYnVmKTsKPiAgCQkJZHJtX2dlbV9vYmplY3RfdW5yZWZl cmVuY2UoJmN0eF9vYmotPmJhc2UpOwo+ICsJCQlXQVJOX09OKGN0eC0+ZW5naW5lW2ldLnVucGlu X2NvdW50ICE9IDApOwo+ICsJCQljdHgtPmVuZ2luZVtpXS51bnBpbl9jb3VudCA9IDA7Cj4gKwkJ CWN0eC0+ZW5naW5lW2ldLnJpbmdidWYgPSBOVUxMOwo+ICsJCQljdHgtPmVuZ2luZVtpXS5zdGF0 ZSA9IE5VTEw7Cj4gIAkJfQo+ICAJfQo+ICB9CgpIaSwKCkkgZG9uJ3QgcXVpdGUgc2VlIGhvdyB0 aGlzIGNhbiBmaXggdGhlIHByb2JsZW0gaWxsdXN0cmF0ZWQgYnkgdGhlIHN0YWNrCnRyYWNlIGFi b3ZlLiAgQUZBSUNTIGludGVsX2xyX2NvbnRleHRfZnJlZSgpIGlzIGNhbGxlZCAvb25seS8gZnJv bQppOTE1X2dlbV9jb250ZXh0X2ZyZWUoKSwgd2hpY2ggc2hvdWxkIG1lYW4gdGhhdCB0aGUgcmVm Y291bnQgb24gdGhlCmludGVsX2NvbnRleHQgb2JqZWN0IGlzIGFscmVhZHkgemVybywgYW5kIHRo YXQgaXQgd2lsbCBiZSBmcmVlZCBvbgpyZXR1cm4uIFNvIHRoZSBjb250ZW50cyBvZiBjdHgtPmVu Z2luZVtdIHNob3VsZCBiZSBpcnJlbGV2YW50IC4uLgoKdm9pZCBpOTE1X2dlbV9jb250ZXh0X2Zy ZWUoc3RydWN0IGtyZWYgKmN0eF9yZWYpCnsKICAgIHN0cnVjdCBpbnRlbF9jb250ZXh0ICpjdHgg PSBjb250YWluZXJfb2YoY3R4X3JlZiwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgdHlwZW9mKCpjdHgpLCByZWYpOwoKICAgIHRyYWNlX2k5MTVfY29udGV4dF9m cmVlKGN0eCk7CgogICAgaWYgKGk5MTUuZW5hYmxlX2V4ZWNsaXN0cykKICAgICAgICBpbnRlbF9s cl9jb250ZXh0X2ZyZWUoY3R4KTsKCiAgICBpOTE1X3BwZ3R0X3B1dChjdHgtPnBwZ3R0KTsKCiAg ICBpZiAoY3R4LT5sZWdhY3lfaHdfY3R4LnJjc19zdGF0ZSkKICAgICAgICBkcm1fZ2VtX29iamVj dF91bnJlZmVyZW5jZSgmY3R4LT5sZWdhY3lfaHdfY3R4LnJjc19zdGF0ZS0+YmFzZSk7CgogICAg bGlzdF9kZWwoJmN0eC0+bGluayk7CiAgICBrZnJlZShjdHgpOwp9CgouLi4gdW5sZXNzIHNvbWV0 aGluZyBpcyB0cnlpbmcgdG8gcmV1c2UgdGhlIGNvbnRleHQgd2hpbGUgaXQgaXMgc3RpbGwgaW4K dGhlIHByb2Nlc3Mgb2YgYmVpbmcgZGVsZXRlZCA6KAoKSW4gYWRkaXRpb24sIHRoZSBzdGFjayB0 cmFjZSBhYm92ZSBpbXBsaWVzIHRoYXQgY3R4LT5lbmdpbmVbXS5zdGF0ZSBXQVMKTlVMTCB3aGVu IGk5MTVfZ2VtX3ZhbGlkYXRlX2NvbnRleHQoKSB3YXMgY2FsbGVkLCBvdGhlcndpc2UgaXQgd291 bGQgbm90CmhhdmUgY2FsbGVkIGludGVsX2xyX2NvbnRleHRfZGVmZXJyZWRfY3JlYXRlKCkKCiAg ICBpZiAoaTkxNS5lbmFibGVfZXhlY2xpc3RzICYmICFjdHgtPmVuZ2luZVtyaW5nLT5pZF0uc3Rh dGUpIHsKICAgICAgICBpbnQgcmV0ID0gaW50ZWxfbHJfY29udGV4dF9kZWZlcnJlZF9jcmVhdGUo Y3R4LCByaW5nKTsKICAgICAgICBpZiAocmV0KSB7CiAgICAgICAgICAgICBEUk1fREVCVUcoIkNv dWxkIG5vdCBjcmVhdGUgTFJDICV1OiAlZFxuIiwgY3R4X2lkLCByZXQpOwogICAgICAgICAgICAg cmV0dXJuIEVSUl9QVFIocmV0KTsKICAgICAgICB9CiAgICB9CgphbmQgbGlrZXdpc2UgdGhhdCBm dW5jdGlvbiB3b3VsZCBub3QgaGF2ZSBjYWxsZWQgZ2VuOF9pbml0X3Jjc19jb250ZXh0KCkKdW5s ZXNzIHRoaXMgd2FzIGEgbmV3IGNvbnRleHQ6CgogICAgaWYgKGN0eCA9PSByaW5nLT5kZWZhdWx0 X2NvbnRleHQpCiAgICAgICAgbHJjX3NldHVwX2hhcmR3YXJlX3N0YXR1c19wYWdlKHJpbmcsIGN0 eF9vYmopOwogICAgZWxzZSBpZiAocmluZy0+aWQgPT0gUkNTICYmICFjdHgtPnJjc19pbml0aWFs aXplZCkgewogICAgICAgIGlmIChyaW5nLT5pbml0X2NvbnRleHQpIHsKICAgICAgICAgICAgcmV0 ID0gcmluZy0+aW5pdF9jb250ZXh0KHJpbmcsIGN0eCk7CiAgICAgICAgICAgIGlmIChyZXQpIHsK ICAgICAgICAgICAgICAgICBEUk1fRVJST1IoInJpbmcgaW5pdCBjb250ZXh0OiAlZFxuIiwgcmV0 KTsKICAgICAgICAgICAgICAgICBjdHgtPmVuZ2luZVtyaW5nLT5pZF0ucmluZ2J1ZiA9IE5VTEw7 CiAgICAgICAgICAgICAgICAgY3R4LT5lbmdpbmVbcmluZy0+aWRdLnN0YXRlID0gTlVMTDsKICAg ICAgICAgICAgICAgICBnb3RvIGVycm9yOwogICAgICAgICAgICB9CiAgICAgICAgfQoKICAgICAg ICBjdHgtPnJjc19pbml0aWFsaXplZCA9IHRydWU7CiAgICB9CgpOb3RlIHRoYXQgcmNzX2luaXRp YWxpemVkIGlzIG5ldmVyIGNsZWFyZWQsIGV2ZW4gd2l0aCB5b3VyIGNoYW5nZSwgc28KdGhhdCBp biBhIHVzZS1hZnRlci1mcmVlIHNpdHVhdGlvbiB3ZSB3b3VsZG4ndCBlbmQgdXAgaW4gdGhpcyBw YXRoLiBTbyBJCnRoaW5rIHRoZSBteXN0ZXJ5IGlzIGhvdyB0aGlzIGNvbnRleHQgZW5kZWQgdXAg aW4gYW4gaW5jb25zaXN0ZW50IHN0YXRlOgpoYXMgaXQgYmVlbiBwYXJ0aWFsbHkgZnJlZWQgYW5k IHRoZW4gcmV1c2VkLCBvciBoYXMgc29tZSBwYXJ0IG9mIHRoZSBuZXcKY29udGV4dCBhbGxvY2F0 aW9uIHBhdGggZmFpbGVkIGJ1dCBub3QgYmVlbiB1bndvdW5kIGNvcnJlY3RseT8KCkFuZCBpZiBz ZXR0aW5nIHRvIE5VTEwgYSBwb2ludGVyIHRoYXQncyBpbnNpZGUgYSBzdHJ1Y3R1cmUgdGhhdCdz IGluIHRoZQpwcm9jZXNzIG9mIGJlaW5nIGZyZWVkIGFjdHVhbGx5IG1ha2VzIGEgZGlmZmVyZW5j ZSwgZG9lc24ndCB0aGF0IG1lYW4KdGhlcmUncyBhIHVzZS1hZnRlci1mcmVlIGlzc3VlIHNvbWV3 aGVyZT8KCi5EYXZlLgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAo=