public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Dave Gordon <david.s.gordon@intel.com>
To: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] Add jobserver flag (+) to deb-pkg build commands
Date: Mon, 12 Jan 2015 18:14:50 +0000	[thread overview]
Message-ID: <54B40F1A.4020200@intel.com> (raw)
In-Reply-To: <1420820097-15317-1-git-send-email-david.s.gordon@intel.com>

On 09/01/15 16:14, Gordon, David S wrote:
> This gets rid of some annoying warnings and allows GNU make to parallelise more
> parts of a deb-pkg build. The message is ...
> 
> make[3]: warning: jobserver unavailable: using -j1.  Add `+' to parent make rule.
> 
> ... so I've added the '+' as suggested.
> 
> Signed-off-by: Dave Gordon <david.s.gordon@intel.com>
> ---
>  scripts/package/Makefile |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/package/Makefile b/scripts/package/Makefile
> index 99ca6e7..0dbfae7 100644
> --- a/scripts/package/Makefile
> +++ b/scripts/package/Makefile
> @@ -88,7 +88,7 @@ quiet_cmd_builddeb = BUILDDEB
>  
>  deb-pkg: FORCE
>  	$(MAKE) KBUILD_SRC=
> -	$(call cmd,builddeb)
> +	+$(call cmd,builddeb)
>  
>  clean-dirs += $(objtree)/debian/

FYI: this speeds up the deb-pkg part of the build by ~10% on my desktop
machine (8-core i7) when using my usual "-j16" option (rule-of-thumb: 2
jobs per core). YMMV; it should be an even bigger win on more parallel
machines, as without it all the targets within deb-pkg are run serially.

.Dave.

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

      parent reply	other threads:[~2015-01-12 18:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-09 16:14 [PATCH] Add jobserver flag (+) to deb-pkg build commands Dave Gordon
2015-01-09 22:07 ` shuang.he
2015-01-12 18:14 ` Dave Gordon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B40F1A.4020200@intel.com \
    --to=david.s.gordon@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox