From: Sean V Kelley <seanvk@posteo.de>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 0/7] drm/i915: Disable hpd for disabled eDP ports
Date: Mon, 12 Jan 2015 16:46:12 -0800 [thread overview]
Message-ID: <54B46AD4.5030908@posteo.de> (raw)
In-Reply-To: <1420806078-20507-1-git-send-email-ville.syrjala@linux.intel.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 01/09/2015 04:21 AM, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> My BSW has a nasty problem where it generates tons of spurious hpd
> interrupts when the eDP display is disabled. The best solution
> seems to be to disable hpd for eDP ports when the port is disabled
> since we don't care about long hpds anyway and short hpds are only
> relevant while the link is up and running.
>
How did these spurious interrupts affect your system? Did you see
this on both B and C Stepping?
Sean
> This series tries to implement that, and I've included a few
> random fixes/refactorings to the hpd code as well.
>
> Ville Syrjälä (7): drm/i915: Make hpd arrays big enough to avoid
> out of bounds access drm/i915: Remove I915_HAS_HOTPLUG() check from
> i915_hpd_irq_setup() drm/i915: Don't register HDMI connectors for
> eDP ports on VLV/CHV drm/i915: Don't pretend SDVO hotplug works on
> 915 drm/i915: Set intel_connector->polled to DRM_CONNECTOR_POLL_HPD
> when appropriate drm/i915: Unify hpd setup between init and hpd
> storm handling drm/i915: Disable HPD for disabled eDP ports
>
> drivers/gpu/drm/i915/i915_irq.c | 172
> ++++++++++++++++++++---------------
> drivers/gpu/drm/i915/intel_crt.c | 4 +-
> drivers/gpu/drm/i915/intel_display.c | 6 +-
> drivers/gpu/drm/i915/intel_dp.c | 18 ++++
> drivers/gpu/drm/i915/intel_dp_mst.c | 2 +
> drivers/gpu/drm/i915/intel_drv.h | 3 +
> drivers/gpu/drm/i915/intel_hdmi.c | 2 +
> drivers/gpu/drm/i915/intel_sdvo.c | 4 + 8 files changed, 136
> insertions(+), 75 deletions(-)
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBAgAGBQJUtGrNAAoJEGScDsMo8QYOmWsQAMORWtlFc8743+LrJ6y6+rX0
+uF3u/v6F+nQr7ijDqMAGuLfCHc04MFJl+uFzCI4p6/DoGTtL9s98EjLlLq/epGI
GuRimDfAx/VsYz18JIByXTbslduoXjq5Cf2C+6atN+AJ3zFEx+j9CRuDcniFVioJ
wufpSdp+p3ruLSSIj/s2IiaiveKUZ2mROxIoiJsfBeS0vvbNCVh87JlQQCJ21xlZ
L6kGGQq7n7lTa6uIxUo9JoU00yRvB3WsPxlSI8K8aDiYIiYxG+ovchUNCj7s0+IE
ePBdYPaZpA4i6/i8HPqXlPveAq8Y4rA2TX6dICd5SRok8PAz7lVVKoMSwS59BMX7
rq9dSFTPkgbU5iwATcmIqQ1plvFAwDpixJ/xpQWjAwm+JF85mW/1GEoPfpImERAY
3CQvi8fkmdVhkcwOQ0SXRMzkIzVjROVkG5PABwgDw4LSFzdP84x07RHCH6omSRIa
NH8fO3cLYWGRmgc1UtP5rW5gBx6J/c+AMtjz74ePoaQOv7H6WaNWEnRnebyXqFo5
RT3Gk0QLS79FFBApZKm2XsWa7Qj6XTKDKPShQME/5kUF5a6yl/arkYyfRVmiNcPg
LWWjS6zUAXm0NjwB24pMuAtugIAGp8D13bWxFQ2501cwDxXHNUK7i9ppdl08A2A7
agVTLHHrEhf8LxXS9AWv
=1UId
-----END PGP SIGNATURE-----
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-01-13 0:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 12:21 [PATCH 0/7] drm/i915: Disable hpd for disabled eDP ports ville.syrjala
2015-01-09 12:21 ` [PATCH 1/7] drm/i915: Make hpd arrays big enough to avoid out of bounds access ville.syrjala
2015-01-09 14:41 ` [Intel-gfx] " Jani Nikula
2015-01-09 15:27 ` Ville Syrjälä
2015-01-09 12:21 ` [PATCH 2/7] drm/i915: Remove I915_HAS_HOTPLUG() check from i915_hpd_irq_setup() ville.syrjala
2015-01-09 14:52 ` Jani Nikula
2015-01-09 12:21 ` [PATCH 3/7] drm/i915: Don't register HDMI connectors for eDP ports on VLV/CHV ville.syrjala
2015-01-09 15:02 ` Jani Nikula
2015-01-12 23:48 ` Daniel Vetter
2015-01-09 12:21 ` [PATCH 4/7] drm/i915: Don't pretend SDVO hotplug works on 915 ville.syrjala
2015-01-09 15:04 ` Jani Nikula
2015-01-12 23:48 ` Daniel Vetter
2015-01-16 10:57 ` Ville Syrjälä
2015-01-09 12:21 ` [PATCH 5/7] drm/i915: Set intel_connector->polled to DRM_CONNECTOR_POLL_HPD when appropriate ville.syrjala
2015-01-09 12:21 ` [PATCH 6/7] drm/i915: Unify hpd setup between init and hpd storm handling ville.syrjala
2015-01-09 12:21 ` [PATCH 7/7] drm/i915: Disable HPD for disabled eDP ports ville.syrjala
2015-01-09 17:47 ` shuang.he
2015-01-13 0:46 ` Sean V Kelley [this message]
2015-01-13 9:36 ` [PATCH 0/7] drm/i915: Disable hpd " Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B46AD4.5030908@posteo.de \
--to=seanvk@posteo.de \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox