From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ander Conselvan de Oliveira Subject: Re: [PATCH] drm/i915: Fix all pipe->plane mappings before sanitizing crtc Date: Wed, 14 Jan 2015 12:50:46 +0200 Message-ID: <54B64A06.4040901@gmail.com> References: <1421135983-1581-1-git-send-email-ander.conselvan.de.oliveira@intel.com> <87h9vtfxlc.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 276BA6E75D for ; Wed, 14 Jan 2015 02:50:48 -0800 (PST) In-Reply-To: <87h9vtfxlc.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMDEvMTQvMjAxNSAxMjo0NyBQTSwgSmFuaSBOaWt1bGEgd3JvdGU6Cj4gT24gVHVlLCAxMyBK YW4gMjAxNSwgQW5kZXIgQ29uc2VsdmFuIGRlIE9saXZlaXJhIDxhbmRlci5jb25zZWx2YW4uZGUu b2xpdmVpcmFAaW50ZWwuY29tPiB3cm90ZToKPj4gSWYgUVVJUktfUElQRUFfRk9SQ0UgaXMgbmVj ZXNzYXJ5LCBpbnRlbF9zYW5pdGl6ZV9jcnRjKCkgbWlnaHQgdHJpZ2dlcgo+PiBhIG1vZGUgc2V0 LiBJbiB0aGF0IGNhc2UsIGlmIHBpcGUgQSBpcyBkaXNhYmxlZCBhbmQgcGlwZSBCIGlzIG1hcHBl ZCB0bwo+PiBwbGFuZSBCLCB0aGF0IG1vZGUgc2V0IGhhcHBlbnMgYmVmb3JlIHRoZSBtYXBwaW5n IGlzIGZpeGVkLiBEdWUgdG8gdGhlCj4+IHdyb25nIHN0YXRlLCB0aGUgY2FsbCB0byBkaXNhYmxl IHBpcGUgQiBkaXNhYmxlcyBwbGFuZSBBICh3aGljaCBpcwo+PiBhbHJlYWR5IGRpc2FibGVkKSBh bmQgbGF0ZXIgYW4gYXNzZXJ0aW9uIGZvciBwbGFuZSBCIGJlaW5nIGVuYWJsZWQKPj4gKHdoaWxl IGl0IHNob3VsZCBoYXZlIGJlZW4gZGlzYWJsZWQpIGlzIHRyaWdnZXJlZC4KPj4KPj4gUmVmZXJl bmNlczogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzI3ODIK Pgo+IElmIHRoZSBwYXRjaCBpcyBleHBlY3RlZCB0byBmaXggdGhlIGJ1ZywgcGxlYXNlIHVzZSBC dWd6aWxsYTouIElmIHlvdSdyZQo+IHJlZmVyZW5jaW5nIGEgYnVnIGJlY2F1c2UgaXQncyBvdGhl cndpc2UgcmVsZXZhbnQsIHBsZWFzZSB1c2UKPiBSZWZlcmVuY2VzOi4KPgo+IFdoaWNoIG9uZSBp cyB0aGlzPwoKVGhpcyBzaG93ZWQgdXAgaW4gdGhlIGRtZXNnIGF0dGFjaGVkIHRvIHRoZSByZWZl cmVuY2VkIGJ1ZywgYnV0IGlzIG5vdCAKdGhlIHJvb3QgY2F1c2Ugb2YgdGhlIHJlcG9ydGVkIHBy b2JsZW0uIEFzIGZhciBhcyBJIGtub3csIHRoZXJlIGlzIG5vIApvcGVuIGJ1ZyBmb3IgdGhpcyBw YXJ0aWN1bGFyIGlzc3VlLgoKQW5kZXIKCj4KPiBCUiwKPiBKYW5pLgo+Cj4KPj4gU2lnbmVkLW9m Zi1ieTogQW5kZXIgQ29uc2VsdmFuIGRlIE9saXZlaXJhIDxhbmRlci5jb25zZWx2YW4uZGUub2xp dmVpcmFAaW50ZWwuY29tPgo+PiAtLS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k aXNwbGF5LmMgfCA1MCArKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0KPj4gICAx IGZpbGUgY2hhbmdlZCwgMzIgaW5zZXJ0aW9ucygrKSwgMTggZGVsZXRpb25zKC0pCj4+Cj4+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4gaW5kZXggZDAxZGIxYi4uY2Y4NzUyOCAx MDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+PiBAQCAtMTMxMjcsMzAg KzEzMTI3LDIyIEBAIGludGVsX2NoZWNrX3BsYW5lX21hcHBpbmcoc3RydWN0IGludGVsX2NydGMg KmNydGMpCj4+ICAgCXJldHVybiB0cnVlOwo+PiAgIH0KPj4KPj4gLXN0YXRpYyB2b2lkIGludGVs X3Nhbml0aXplX2NydGMoc3RydWN0IGludGVsX2NydGMgKmNydGMpCj4+ICtzdGF0aWMgdm9pZCBp bnRlbF9maXhfcGxhbmVfbWFwcGluZyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+PiAgIHsKPj4g LQlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gY3J0Yy0+YmFzZS5kZXY7Cj4+IC0Jc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPj4gLQl1MzIgcmVn Owo+PiAtCj4+IC0JLyogQ2xlYXIgYW55IGZyYW1lIHN0YXJ0IGRlbGF5cyB1c2VkIGZvciBkZWJ1 Z2dpbmcgbGVmdCBieSB0aGUgQklPUyAqLwo+PiAtCXJlZyA9IFBJUEVDT05GKGNydGMtPmNvbmZp Zy5jcHVfdHJhbnNjb2Rlcik7Cj4+IC0JSTkxNV9XUklURShyZWcsIEk5MTVfUkVBRChyZWcpICYg flBJUEVDT05GX0ZSQU1FX1NUQVJUX0RFTEFZX01BU0spOwo+PiArCXN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPj4gKwlzdHJ1Y3QgaW50ZWxfY3J0YyAq Y3J0YzsKPj4KPj4gLQkvKiByZXN0b3JlIHZibGFuayBpbnRlcnJ1cHRzIHRvIGNvcnJlY3Qgc3Rh dGUgKi8KPj4gLQlpZiAoY3J0Yy0+YWN0aXZlKSB7Cj4+IC0JCXVwZGF0ZV9zY2FubGluZV9vZmZz ZXQoY3J0Yyk7Cj4+IC0JCWRybV92Ymxhbmtfb24oZGV2LCBjcnRjLT5waXBlKTsKPj4gLQl9IGVs c2UKPj4gLQkJZHJtX3ZibGFua19vZmYoZGV2LCBjcnRjLT5waXBlKTsKPj4gKwkvKiBnZW40KyBo YXMgYSBmaXhlZCBwbGFuZSAtPiBwaXBlIG1hcHBpbmcuKi8KPj4gKwlpZiAoSU5URUxfSU5GTyhk ZXYpLT5nZW4gPj0gNCkKPj4gKwkJcmV0dXJuOwo+Pgo+PiAtCS8qIFdlIG5lZWQgdG8gc2FuaXRp emUgdGhlIHBsYW5lIC0+IHBpcGUgbWFwcGluZyBmaXJzdCBiZWNhdXNlIHRoaXMgd2lsbAo+PiAt CSAqIGRpc2FibGUgdGhlIGNydGMgKGFuZCBoZW5jZSBjaGFuZ2UgdGhlIHN0YXRlKSBpZiBpdCBp cyB3cm9uZy4gTm90ZQo+PiAtCSAqIHRoYXQgZ2VuNCsgaGFzIGEgZml4ZWQgcGxhbmUgLT4gcGlw ZSBtYXBwaW5nLiAgKi8KPj4gLQlpZiAoSU5URUxfSU5GTyhkZXYpLT5nZW4gPCA0ICYmICFpbnRl bF9jaGVja19wbGFuZV9tYXBwaW5nKGNydGMpKSB7Cj4+ICsJZm9yX2VhY2hfaW50ZWxfY3J0Yyhk ZXYsIGNydGMpIHsKPj4gICAJCXN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5lY3RvcjsKPj4g ICAJCWJvb2wgcGxhbmU7Cj4+Cj4+ICsJCWlmIChpbnRlbF9jaGVja19wbGFuZV9tYXBwaW5nKGNy dGMpKQo+PiArCQkJY29udGludWU7Cj4+ICsKPj4gICAJCURSTV9ERUJVR19LTVMoIltDUlRDOiVk XSB3cm9uZyBwbGFuZSBjb25uZWN0aW9uIGRldGVjdGVkIVxuIiwKPj4gICAJCQkgICAgICBjcnRj LT5iYXNlLmJhc2UuaWQpOwo+Pgo+PiBAQCAtMTMxODQsNiArMTMxNzYsMjQgQEAgc3RhdGljIHZv aWQgaW50ZWxfc2FuaXRpemVfY3J0YyhzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykKPj4gICAJCVdB Uk5fT04oY3J0Yy0+YWN0aXZlKTsKPj4gICAJCWNydGMtPmJhc2UuZW5hYmxlZCA9IGZhbHNlOwo+ PiAgIAl9Cj4+ICt9Cj4+ICsKPj4gK3N0YXRpYyB2b2lkIGludGVsX3Nhbml0aXplX2NydGMoc3Ry dWN0IGludGVsX2NydGMgKmNydGMpCj4+ICt7Cj4+ICsJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9 IGNydGMtPmJhc2UuZGV2Owo+PiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9 IGRldi0+ZGV2X3ByaXZhdGU7Cj4+ICsJdTMyIHJlZzsKPj4gKwo+PiArCS8qIENsZWFyIGFueSBm cmFtZSBzdGFydCBkZWxheXMgdXNlZCBmb3IgZGVidWdnaW5nIGxlZnQgYnkgdGhlIEJJT1MgKi8K Pj4gKwlyZWcgPSBQSVBFQ09ORihjcnRjLT5jb25maWcuY3B1X3RyYW5zY29kZXIpOwo+PiArCUk5 MTVfV1JJVEUocmVnLCBJOTE1X1JFQUQocmVnKSAmIH5QSVBFQ09ORl9GUkFNRV9TVEFSVF9ERUxB WV9NQVNLKTsKPj4gKwo+PiArCS8qIHJlc3RvcmUgdmJsYW5rIGludGVycnVwdHMgdG8gY29ycmVj dCBzdGF0ZSAqLwo+PiArCWlmIChjcnRjLT5hY3RpdmUpIHsKPj4gKwkJdXBkYXRlX3NjYW5saW5l X29mZnNldChjcnRjKTsKPj4gKwkJZHJtX3ZibGFua19vbihkZXYsIGNydGMtPnBpcGUpOwo+PiAr CX0gZWxzZQo+PiArCQlkcm1fdmJsYW5rX29mZihkZXYsIGNydGMtPnBpcGUpOwo+Pgo+PiAgIAlp ZiAoZGV2X3ByaXYtPnF1aXJrcyAmIFFVSVJLX1BJUEVBX0ZPUkNFICYmCj4+ICAgCSAgICBjcnRj LT5waXBlID09IFBJUEVfQSAmJiAhY3J0Yy0+YWN0aXZlKSB7Cj4+IEBAIC0xMzQ0Miw2ICsxMzQ1 MiwxMCBAQCB2b2lkIGludGVsX21vZGVzZXRfc2V0dXBfaHdfc3RhdGUoc3RydWN0IGRybV9kZXZp Y2UgKmRldiwKPj4gICAJCWludGVsX3Nhbml0aXplX2VuY29kZXIoZW5jb2Rlcik7Cj4+ICAgCX0K Pj4KPj4gKwkvKiBXZSBuZWVkIHRvIHNhbml0aXplIHRoZSBwbGFuZSAtPiBwaXBlIG1hcHBpbmcg Zmlyc3QgYmVjYXVzZSB0aGlzIHdpbGwKPj4gKwkgKiBkaXNhYmxlIHRoZSBjcnRjIChhbmQgaGVu Y2UgY2hhbmdlIHRoZSBzdGF0ZSkgaWYgaXQgaXMgd3JvbmcuICovCj4+ICsJaW50ZWxfZml4X3Bs YW5lX21hcHBpbmcoZGV2KTsKPj4gKwo+PiAgIAlmb3JfZWFjaF9waXBlKGRldl9wcml2LCBwaXBl KSB7Cj4+ICAgCQljcnRjID0gdG9faW50ZWxfY3J0YyhkZXZfcHJpdi0+cGlwZV90b19jcnRjX21h cHBpbmdbcGlwZV0pOwo+PiAgIAkJaW50ZWxfc2FuaXRpemVfY3J0YyhjcnRjKTsKPj4gLS0KPj4g MS45LjEKPj4KPj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KPj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+PiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCj4+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngKPgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK