From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Reduce locking in command submission
Date: Thu, 15 Jan 2015 17:05:30 +0000 [thread overview]
Message-ID: <54B7F35A.9050405@linux.intel.com> (raw)
In-Reply-To: <20150115165402.GA8350@bwidawsk.net>
On 01/15/2015 04:54 PM, Ben Widawsky wrote:
> On Thu, Jan 15, 2015 at 11:21:30AM +0000, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> This eliminates six needless spin lock/unlock pairs when writing out ELSP. Apart
>> from tidier code main benefit is between 0.51% and 0.73% speedup on some OGL
>> tests under CHV (bench_OglBatch4 bench_OglDeferred respectively).
>
> With 95% confidence t-test on n=5
>
>>
>> Kindly benchmarked by Ben Widawsky.
>
> FWIW, as I mentioned on IRC, I think the reduction of the unnecessary forcewake
> (someone should fix the shadow register list) is probably more beneficial than
> removing the spin on an uncontested lock. I was tempted to try that myself, but
> I didn't have time or much interest since your patch accomplishes the same
> thing.
I missed that IRC discussion, but I don't think it was doing forcewakes
since the outer block in execlists_elsp_write bumps the counters which
made I915_WRITE & co skip them.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-01-15 17:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 15:41 [RFC] drm/i915: Reduce locking in command submission Tvrtko Ursulin
2014-12-15 13:06 ` Daniel Vetter
2014-12-16 13:34 ` Tvrtko Ursulin
2015-01-14 10:13 ` Tvrtko Ursulin
2015-01-15 11:21 ` [PATCH] " Tvrtko Ursulin
2015-01-15 16:54 ` Ben Widawsky
2015-01-15 17:05 ` Tvrtko Ursulin [this message]
2015-01-15 23:42 ` Ben Widawsky
2015-01-16 0:19 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B7F35A.9050405@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=ben@bwidawsk.net \
--cc=daniel.vetter@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox